Skip to content

Commit 052a99e

Browse files
committed
Self review
1 parent 86a1df5 commit 052a99e

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

.github/workflows/integrate.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,21 @@ jobs:
1717
name: "Code Coverage"
1818
uses: "phpDocumentor/.github/.github/workflows/code-coverage.yml@main"
1919
with:
20+
default: "none, ctype, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter, fileinfo, iconv"
2021
composer-root-version: "1.x-dev"
2122

2223
coding-standards:
2324
name: "Coding Standards"
2425
uses: "phpDocumentor/.github/.github/workflows/[email protected]"
2526
with:
27+
default: "none, ctype, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter, fileinfo, iconv"
2628
composer-root-version: "1.x-dev"
2729

2830
dependency-analysis:
2931
name: "Dependency analysis"
3032
uses: "phpDocumentor/.github/.github/workflows/[email protected]"
3133
with:
34+
default: "none, ctype, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter, fileinfo, iconv"
3235
composer-root-version: "1.x-dev"
3336

3437
lint-root:
@@ -41,12 +44,13 @@ jobs:
4144
name: "Static analysis"
4245
uses: "phpDocumentor/.github/.github/workflows/[email protected]"
4346
with:
44-
php-extensions: "none, ctype, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter, fileinfo, pcntl, posix"
47+
php-extensions: "none, ctype, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter, fileinfo, pcntl, posix, iconv"
4548
composer-root-version: "1.x-dev"
4649

4750
unit-tests:
4851
name: "Unit test"
4952
uses: "phpDocumentor/.github/.github/workflows/[email protected]"
5053
with:
54+
default: "none, ctype, dom, json, mbstring, phar, simplexml, tokenizer, xml, xmlwriter, fileinfo, iconv"
5155
composer-root-version: "1.x-dev"
5256
upcoming-releases: true

tests/unit/FqsenResolverTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,9 @@ public function testResolveFromPartialAlias(): void
8585
static::assertSame('\some\other\ns', (string) $result);
8686
}
8787

88+
/**
89+
* @covers ::resolve
90+
*/
8891
public function testResolveThrowsExceptionWhenGarbageInputIsPassed(): void
8992
{
9093
$this->expectException(InvalidArgumentException::class);

0 commit comments

Comments
 (0)