Improves test coverage

Author: jaapio

src/FqsenResolver.php

@@ -19,7 +19,7 @@ class FqsenResolver
     /** @var string Definition of the NAMESPACE operator in PHP */
     const OPERATOR_NAMESPACE = '\\';
 
-    public function resolve($fqsen, Context $context = null)
+    public function resolve($fqsen, Context $context = null): Fqsen
     {
         if ($context === null) {
             $context = new Context('');
@@ -39,7 +39,7 @@ public function resolve($fqsen, Context $context = null)
      *
      * @return bool
      */
-    private function isFqsen($type)
+    private function isFqsen($type): bool
     {
         return strpos($type, self::OPERATOR_NAMESPACE) === 0;
     }
@@ -52,7 +52,7 @@ private function isFqsen($type)
      * @return Fqsen
      * @throws \InvalidArgumentException when type is not a valid FQSEN.
      */
-    private function resolvePartialStructuralElementName($type, Context $context)
+    private function resolvePartialStructuralElementName($type, Context $context): Fqsen
     {
         $typeParts = explode(self::OPERATOR_NAMESPACE, $type, 2);
 

tests/unit/FqsenResolverTest.php

@@ -0,0 +1,76 @@
+<?php
+
+namespace phpDocumentor\Reflection\unit;
+
+use phpDocumentor\Reflection\FqsenResolver;
+use phpDocumentor\Reflection\Types\Context;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @coversDefaultClass \phpDocumentor\Reflection\FqsenResolver
+ * @covers ::<private>
+ */
+class FqsenResolverTest extends TestCase
+{
+    /**
+     * @covers ::resolve
+     */
+    public function testResolveFqsen()
+    {
+        $fqsenResolver = new FqsenResolver();
+
+        $context = new Context('', []);
+
+        $result = $fqsenResolver->resolve('\DocBlock', $context);
+        static::assertEquals('\DocBlock', (string)$result);
+    }
+
+    /**
+     * @covers ::resolve
+     */
+    public function testResolveWithoutContext()
+    {
+        $fqsenResolver = new FqsenResolver();
+
+        $result = $fqsenResolver->resolve('\DocBlock');
+        static::assertEquals('\DocBlock', (string)$result);
+    }
+
+    /**
+     * @covers ::resolve
+     */
+    public function testResolveFromAlias()
+    {
+        $fqsenResolver = new FqsenResolver();
+
+        $context = new Context('somens', ['ns' => 'some\other\ns']);
+
+        $result = $fqsenResolver->resolve('ns', $context);
+        static::assertEquals('\some\other\ns', (string)$result);
+    }
+
+    /**
+     * @covers ::resolve
+     */
+    public function testResolveFromPartialAlias()
+    {
+        $fqsenResolver = new FqsenResolver();
+
+        $context = new Context('somens', ['other' => 'some\other']);
+
+        $result = $fqsenResolver->resolve('other\ns', $context);
+        static::assertEquals('\some\other\ns', (string)$result);
+    }
+
+    /**
+     * @expectedException \InvalidArgumentException
+     */
+    public function testResolveThrowsExceptionWhenGarbageInputIsPassed()
+    {
+        $fqsenResolver = new FqsenResolver();
+
+        $context = new Context('', []);
+
+        $fqsenResolver->resolve('this is complete garbage', $context);
+    }
+}