Add more return types

Author: jaapio

src/FqsenResolver.php

@@ -17,7 +17,7 @@
 class FqsenResolver
 {
     /** @var string Definition of the NAMESPACE operator in PHP */
-    const OPERATOR_NAMESPACE = '\\';
+    private const OPERATOR_NAMESPACE = '\\';
 
     public function resolve(string $fqsen, Context $context = null): Fqsen
     {

src/Type.php

@@ -19,5 +19,5 @@ interface Type
      *
      * @return string
      */
-    public function __toString();
+    public function __toString(): string;
 }

src/TypeResolver.php

@@ -25,22 +25,22 @@
 final class TypeResolver
 {
     /** @var string Definition of the ARRAY operator for types */
-    const OPERATOR_ARRAY = '[]';
+    private const OPERATOR_ARRAY = '[]';
 
     /** @var string Definition of the NAMESPACE operator in PHP */
-    const OPERATOR_NAMESPACE = '\\';
+    private const OPERATOR_NAMESPACE = '\\';
 
     /** @var int the iterator parser is inside a compound context */
-    const PARSER_IN_COMPOUND = 0;
+    private const PARSER_IN_COMPOUND = 0;
 
     /** @var int the iterator parser is inside a nullable expression context */
-    const PARSER_IN_NULLABLE = 1;
+    private const PARSER_IN_NULLABLE = 1;
 
     /** @var int the iterator parser is inside an array expression context */
-    const PARSER_IN_ARRAY_EXPRESSION = 2;
+    private const PARSER_IN_ARRAY_EXPRESSION = 2;
 
     /** @var int the iterator parser is inside a collection expression context */
-    const PARSER_IN_COLLECTION_EXPRESSION = 3;
+    private const PARSER_IN_COLLECTION_EXPRESSION = 3;
 
     /**
      * @var array<string, string> List of recognized keywords and unto which Value Object they map

src/Types/AbstractList.php

@@ -64,6 +64,7 @@ public function getValueType(): Type
 
     /**
      * Returns a rendered output of the Type as it would be used in a DocBlock.
+     * @return string
      */
     public function __toString(): string
     {

src/Types/Boolean.php

@@ -24,7 +24,7 @@ final class Boolean implements Type
      *
      * @return string
      */
-    public function __toString()
+    public function __toString(): string
     {
         return 'bool';
     }

src/Types/Callable_.php

@@ -24,7 +24,7 @@ final class Callable_ implements Type
      *
      * @return string
      */
-    public function __toString()
+    public function __toString(): string
     {
         return 'callable';
     }

src/Types/Collection.php

@@ -55,6 +55,7 @@ public function getFqsen(): ?Fqsen
 
     /**
      * Returns a rendered output of the Type as it would be used in a DocBlock.
+     * @return string
      */
     public function __toString(): string
     {

src/Types/Compound.php

@@ -53,7 +53,7 @@ public function __construct(array $types)
      *
      * @return Type|null
      */
-    public function get($index)
+    public function get(int $index): ?Type
     {
         if (!$this->has($index)) {
             return null;
@@ -69,7 +69,7 @@ public function get($index)
      *
      * @return bool
      */
-    public function has($index)
+    public function has(int $index): bool
     {
         return isset($this->types[$index]);
     }
@@ -79,7 +79,7 @@ public function has($index)
      *
      * @return string
      */
-    public function __toString()
+    public function __toString(): string
     {
         return implode('|', $this->types);
     }

src/Types/Context.php

@@ -67,7 +67,7 @@ public function __construct($namespace, array $namespaceAliases = [])
      *
      * @return string
      */
-    public function getNamespace()
+    public function getNamespace(): string
     {
         return $this->namespace;
     }
@@ -78,7 +78,7 @@ public function getNamespace()
      *
      * @return string[]
      */
-    public function getNamespaceAliases()
+    public function getNamespaceAliases(): array
     {
         return $this->namespaceAliases;
     }

src/Types/ContextFactory.php

@@ -26,10 +26,10 @@
 final class ContextFactory
 {
     /** The literal used at the end of a use statement. */
-    const T_LITERAL_END_OF_USE = ';';
+    private const T_LITERAL_END_OF_USE = ';';
 
     /** The literal used between sets of use statements */
-    const T_LITERAL_USE_SEPARATOR = ',';
+    private const T_LITERAL_USE_SEPARATOR = ',';
 
     /**
      * Build a Context given a Class Reflection.