Skip to content

Commit 46523b1

Browse files
committed
Phive: upgrade used version of PHPUnit
The tests were not actually running on PHP 8, nor PHP 8.1, due to PHPUnit 8.4 being used, which is not compatible with PHP 8.0+. The first compatible version in the 8.x range is 8.5 and on the 9.x. range, 9.3. As for PHP 8.1, there is currently no guarantee yet, but your best bet is using the latest release of PHPUnit. The `push.yml` script already contains code to _downgrade_ the PHPUnit version used by Phive for PHP 7.2 back to PHPUnit 8, so it should be safe to upgrade the PHPUnit version for PHP 7.3 and above to PHPUnit 9.5.x. The only concession which needs to be made is for the `phpunit-with-coverage` to be run on PHP 7.3 (or to also downgrade to PHPUnit 8).
1 parent 4b39d91 commit 46523b1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/push.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Setup PHP
3636
uses: shivammathur/setup-php@v2
3737
with:
38-
php-version: 7.2
38+
php-version: 7.3
3939
ini-values: memory_limit=2G, display_errors=On, error_reporting=-1
4040
coverage: pcov
4141
tools: phive

phive.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<phive xmlns="https://phar.io/phive">
3-
<phar name="phpunit" version="^8.4" installed="8.4.3" location="./tools/phpunit" copy="true"/>
3+
<phar name="phpunit" version="^9.5" installed="9.5.8" location="./tools/phpunit" copy="true"/>
44
</phive>

0 commit comments

Comments
 (0)