Increase test coverage to 96%

mspirkov · mspirkov · commit 5597e1708583 · 2025-12-02T23:14:23.000+04:00
diff --git a/tests/unit/PseudoTypes/ArrayShapeItemTest.php b/tests/unit/PseudoTypes/ArrayShapeItemTest.php
@@ -15,7 +15,7 @@
 
 use PHPUnit\Framework\TestCase;
 
-class ArrayShapeItemTest extends TestCase
+final class ArrayShapeItemTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/ArrayShapeTest.php b/tests/unit/PseudoTypes/ArrayShapeTest.php
@@ -8,7 +8,7 @@
 use phpDocumentor\Reflection\Types\Mixed_;
 use PHPUnit\Framework\TestCase;
 
-class ArrayShapeTest extends TestCase
+final class ArrayShapeTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/CallableStringTest.php b/tests/unit/PseudoTypes/CallableStringTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class CallableStringTest extends TestCase
+final class CallableStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/ClassStringTest.php b/tests/unit/PseudoTypes/ClassStringTest.php
@@ -19,7 +19,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class ClassStringTest extends TestCase
+final class ClassStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/ConditionalForParameterTest.php b/tests/unit/PseudoTypes/ConditionalForParameterTest.php
@@ -10,7 +10,7 @@
 use phpDocumentor\Reflection\Types\Static_;
 use PHPUnit\Framework\TestCase;
 
-class ConditionalForParameterTest extends TestCase
+final class ConditionalForParameterTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/ConditionalTest.php b/tests/unit/PseudoTypes/ConditionalTest.php
@@ -12,7 +12,7 @@
 use phpDocumentor\Reflection\Types\Static_;
 use PHPUnit\Framework\TestCase;
 
-class ConditionalTest extends TestCase
+final class ConditionalTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/ConstExpressionTest.php b/tests/unit/PseudoTypes/ConstExpressionTest.php
@@ -18,7 +18,7 @@
 use phpDocumentor\Reflection\Types\Object_;
 use PHPUnit\Framework\TestCase;
 
-class ConstExpressionTest extends TestCase
+final class ConstExpressionTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/EnumStringTest.php b/tests/unit/PseudoTypes/EnumStringTest.php
@@ -19,7 +19,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class EnumStringTest extends TestCase
+final class EnumStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/FloatValueTest.php b/tests/unit/PseudoTypes/FloatValueTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\Float_;
 use PHPUnit\Framework\TestCase;
 
-class FloatValueTest extends TestCase
+final class FloatValueTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/GenericTest.php b/tests/unit/PseudoTypes/GenericTest.php
@@ -11,7 +11,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class GenericTest extends TestCase
+final class GenericTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/HtmlEscapedStringTest.php b/tests/unit/PseudoTypes/HtmlEscapedStringTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class HtmlEscapedStringTest extends TestCase
+final class HtmlEscapedStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/IntMaskOfTest.php b/tests/unit/PseudoTypes/IntMaskOfTest.php
@@ -8,7 +8,7 @@
 use phpDocumentor\Reflection\Types\Integer;
 use PHPUnit\Framework\TestCase;
 
-class IntMaskOfTest extends TestCase
+final class IntMaskOfTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/IntMaskTest.php b/tests/unit/PseudoTypes/IntMaskTest.php
@@ -7,7 +7,7 @@
 use phpDocumentor\Reflection\Types\Integer;
 use PHPUnit\Framework\TestCase;
 
-class IntMaskTest extends TestCase
+final class IntMaskTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/IntegerRangeTest.php b/tests/unit/PseudoTypes/IntegerRangeTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\Integer;
 use PHPUnit\Framework\TestCase;
 
-class IntegerRangeTest extends TestCase
+final class IntegerRangeTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/IntegerValueTest.php b/tests/unit/PseudoTypes/IntegerValueTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\Integer;
 use PHPUnit\Framework\TestCase;
 
-class IntegerValueTest extends TestCase
+final class IntegerValueTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/InterfaceStringTest.php b/tests/unit/PseudoTypes/InterfaceStringTest.php
@@ -19,7 +19,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class InterfaceStringTest extends TestCase
+final class InterfaceStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/KeyOfTest.php b/tests/unit/PseudoTypes/KeyOfTest.php
@@ -8,7 +8,7 @@
 use phpDocumentor\Reflection\Types\Object_;
 use PHPUnit\Framework\TestCase;
 
-class KeyOfTest extends TestCase
+final class KeyOfTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/ListShapeTest.php b/tests/unit/PseudoTypes/ListShapeTest.php
@@ -15,7 +15,7 @@
 
 use PHPUnit\Framework\TestCase;
 
-class ListShapeTest extends TestCase
+final class ListShapeTest extends TestCase
 {
     public function testToString(): void
     {
diff --git a/tests/unit/PseudoTypes/ListTest.php b/tests/unit/PseudoTypes/ListTest.php
@@ -20,7 +20,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class ListTest extends TestCase
+final class ListTest extends TestCase
 {
     public function testCreateWithoutParams(): void
     {
diff --git a/tests/unit/PseudoTypes/LiteralStringTest.php b/tests/unit/PseudoTypes/LiteralStringTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class LiteralStringTest extends TestCase
+final class LiteralStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/LowercaseStringTest.php b/tests/unit/PseudoTypes/LowercaseStringTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class LowercaseStringTest extends TestCase
+final class LowercaseStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/NegativeIntegerTest.php b/tests/unit/PseudoTypes/NegativeIntegerTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\Integer;
 use PHPUnit\Framework\TestCase;
 
-class NegativeIntegerTest extends TestCase
+final class NegativeIntegerTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/NonEmptyArrayTest.php b/tests/unit/PseudoTypes/NonEmptyArrayTest.php
@@ -20,7 +20,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class NonEmptyArrayTest extends TestCase
+final class NonEmptyArrayTest extends TestCase
 {
     public function testCreateWithoutParams(): void
     {
diff --git a/tests/unit/PseudoTypes/NonEmptyListTest.php b/tests/unit/PseudoTypes/NonEmptyListTest.php
@@ -20,7 +20,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class NonEmptyListTest extends TestCase
+final class NonEmptyListTest extends TestCase
 {
     public function testCreateWithoutParams(): void
     {
diff --git a/tests/unit/PseudoTypes/NonEmptyLowercaseStringTest.php b/tests/unit/PseudoTypes/NonEmptyLowercaseStringTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class NonEmptyLowercaseStringTest extends TestCase
+final class NonEmptyLowercaseStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/NonEmptyStringTest.php b/tests/unit/PseudoTypes/NonEmptyStringTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class NonEmptyStringTest extends TestCase
+final class NonEmptyStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/NumericStringTest.php b/tests/unit/PseudoTypes/NumericStringTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class NumericStringTest extends TestCase
+final class NumericStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/ObjectShapeTest.php b/tests/unit/PseudoTypes/ObjectShapeTest.php
@@ -7,7 +7,7 @@
 use phpDocumentor\Reflection\Types\Object_;
 use PHPUnit\Framework\TestCase;
 
-class ObjectShapeTest extends TestCase
+final class ObjectShapeTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/OffsetAccessTest.php b/tests/unit/PseudoTypes/OffsetAccessTest.php
@@ -9,7 +9,7 @@
 use phpDocumentor\Reflection\Types\Object_;
 use PHPUnit\Framework\TestCase;
 
-class OffsetAccessTest extends TestCase
+final class OffsetAccessTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/PositiveIntegerTest.php b/tests/unit/PseudoTypes/PositiveIntegerTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\Integer;
 use PHPUnit\Framework\TestCase;
 
-class PositiveIntegerTest extends TestCase
+final class PositiveIntegerTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/StringValueTest.php b/tests/unit/PseudoTypes/StringValueTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class StringValueTest extends TestCase
+final class StringValueTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/TraitStringTest.php b/tests/unit/PseudoTypes/TraitStringTest.php
@@ -19,7 +19,7 @@
 use phpDocumentor\Reflection\Types\String_;
 use PHPUnit\Framework\TestCase;
 
-class TraitStringTest extends TestCase
+final class TraitStringTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/PseudoTypes/TrueTest.php b/tests/unit/PseudoTypes/TrueTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Types\Boolean;
 use PHPUnit\Framework\TestCase;
 
-class TrueTest extends TestCase
+final class TrueTest extends TestCase
 {
     public function testExposesUnderlyingType(): void
     {
diff --git a/tests/unit/PseudoTypes/ValueOfTest.php b/tests/unit/PseudoTypes/ValueOfTest.php
@@ -9,7 +9,7 @@
 use phpDocumentor\Reflection\Types\Object_;
 use PHPUnit\Framework\TestCase;
 
-class ValueOfTest extends TestCase
+final class ValueOfTest extends TestCase
 {
     public function testCreate(): void
     {
diff --git a/tests/unit/TypeResolverTest.php b/tests/unit/TypeResolverTest.php
@@ -102,7 +102,9 @@ public function testResolvingKeywords(string $keyword, string $expectedClass): v
         $fixture = new TypeResolver();
 
         $resolvedType = $fixture->resolve($keyword, new Context(''));
+        $this->assertInstanceOf($expectedClass, $resolvedType);
 
+        $resolvedType = $fixture->resolve($keyword);
         $this->assertInstanceOf($expectedClass, $resolvedType);
     }
 
@@ -1339,4 +1341,11 @@ public function illegalLegacyFormatProvider(): array
             ],
         ];
     }
+
+    public function testCreateTypeFromNull(): void
+    {
+        $fixture = new TypeResolver();
+
+        $this->assertEquals(new Mixed_(), $fixture->createType(null, new Context('')));
+    }
 }
diff --git a/tests/unit/Types/ArrayTest.php b/tests/unit/Types/ArrayTest.php
@@ -16,7 +16,7 @@
 use phpDocumentor\Reflection\Fqsen;
 use PHPUnit\Framework\TestCase;
 
-class ArrayTest extends TestCase
+final class ArrayTest extends TestCase
 {
     public function testCreateWithoutParams(): void
     {
@@ -47,17 +47,17 @@ public function testCreateWithParams(): void
     }
 
     /**
-     * @dataProvider provideArrays
+     * @dataProvider provideToStringData
      */
-    public function testArrayStringifyCorrectly(Array_ $array, string $expectedString): void
+    public function testToString(Array_ $array, string $expectedString): void
     {
         $this->assertSame($expectedString, (string) $array);
     }
 
     /**
-     * @return mixed[]
+     * @return array<string, array{Array_, string}>
      */
-    public function provideArrays(): array
+    public function provideToStringData(): array
     {
         return [
             'simple array' => [new Array_(), 'array'],
diff --git a/tests/unit/Types/BooleanTest.php b/tests/unit/Types/BooleanTest.php
@@ -17,7 +17,7 @@
 
 final class BooleanTest extends TestCase
 {
-    public function testBooleanStringifyCorrectly(): void
+    public function testToString(): void
     {
         $type = new Boolean();
 
diff --git a/tests/unit/Types/CallableParameterTest.php b/tests/unit/Types/CallableParameterTest.php
diff --git a/tests/unit/Types/CompoundTest.php b/tests/unit/Types/CompoundTest.php
diff --git a/tests/unit/Types/ContextFactoryTest.php b/tests/unit/Types/ContextFactoryTest.php
diff --git a/tests/unit/Types/ContextTest.php b/tests/unit/Types/ContextTest.php
diff --git a/tests/unit/Types/IterableTest.php b/tests/unit/Types/IterableTest.php
diff --git a/tests/unit/Types/NeverTest.php b/tests/unit/Types/NeverTest.php
diff --git a/tests/unit/Types/NullableTest.php b/tests/unit/Types/NullableTest.php
diff --git a/tests/unit/Types/ObjectTest.php b/tests/unit/Types/ObjectTest.php
diff --git a/tests/unit/Types/ParentTest.php b/tests/unit/Types/ParentTest.php
diff --git a/tests/unit/Types/ResourceTest.php b/tests/unit/Types/ResourceTest.php
diff --git a/tests/unit/Types/ScalarTest.php b/tests/unit/Types/ScalarTest.php
diff --git a/tests/unit/Types/SelfTest.php b/tests/unit/Types/SelfTest.php
diff --git a/tests/unit/Types/StaticTest.php b/tests/unit/Types/StaticTest.php
diff --git a/tests/unit/Types/ThisTest.php b/tests/unit/Types/ThisTest.php
diff --git a/tests/unit/Types/VoidTest.php b/tests/unit/Types/VoidTest.php

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`use PHPUnit\Framework\TestCase;`
`17`	`17`
`18`		`-class ArrayShapeItemTest extends TestCase`
	`18`	`+final class ArrayShapeItemTest extends TestCase`
`19`	`19`	`{`
`20`	`20`	`public function testCreate(): void`
`21`	`21`	`{`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`use phpDocumentor\Reflection\Types\Mixed_;`
`9`	`9`	`use PHPUnit\Framework\TestCase;`
`10`	`10`
`11`		`-class ArrayShapeTest extends TestCase`
	`11`	`+final class ArrayShapeTest extends TestCase`
`12`	`12`	`{`
`13`	`13`	`public function testCreate(): void`
`14`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`	`use phpDocumentor\Reflection\Types\String_;`
`17`	`17`	`use PHPUnit\Framework\TestCase;`
`18`	`18`
`19`		`-class CallableStringTest extends TestCase`
	`19`	`+final class CallableStringTest extends TestCase`
`20`	`20`	`{`
`21`	`21`	`public function testCreate(): void`
`22`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`use phpDocumentor\Reflection\Types\String_;`
`20`	`20`	`use PHPUnit\Framework\TestCase;`
`21`	`21`
`22`		`-class ClassStringTest extends TestCase`
	`22`	`+final class ClassStringTest extends TestCase`
`23`	`23`	`{`
`24`	`24`	`public function testCreate(): void`
`25`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`use phpDocumentor\Reflection\Types\Static_;`
`11`	`11`	`use PHPUnit\Framework\TestCase;`
`12`	`12`
`13`		`-class ConditionalForParameterTest extends TestCase`
	`13`	`+final class ConditionalForParameterTest extends TestCase`
`14`	`14`	`{`
`15`	`15`	`public function testCreate(): void`
`16`	`16`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`use phpDocumentor\Reflection\Types\Static_;`
`13`	`13`	`use PHPUnit\Framework\TestCase;`
`14`	`14`
`15`		`-class ConditionalTest extends TestCase`
	`15`	`+final class ConditionalTest extends TestCase`
`16`	`16`	`{`
`17`	`17`	`public function testCreate(): void`
`18`	`18`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@`
`18`	`18`	`use phpDocumentor\Reflection\Types\Object_;`
`19`	`19`	`use PHPUnit\Framework\TestCase;`
`20`	`20`
`21`		`-class ConstExpressionTest extends TestCase`
	`21`	`+final class ConstExpressionTest extends TestCase`
`22`	`22`	`{`
`23`	`23`	`public function testCreate(): void`
`24`	`24`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`use phpDocumentor\Reflection\Types\String_;`
`12`	`12`	`use PHPUnit\Framework\TestCase;`
`13`	`13`
`14`		`-class GenericTest extends TestCase`
	`14`	`+final class GenericTest extends TestCase`
`15`	`15`	`{`
`16`	`16`	`public function testCreate(): void`
`17`	`17`	`{`