Merge pull request #96 from phpDocumentor/feature/blackfire

Profiling

Author: jaapio

.github/workflows/push.yml

@@ -9,14 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@master
-      - name: Restore/cache vendor folder
-        uses: actions/cache@v1
-        with:
-          path: vendor
-          key: all-build-${{ hashFiles('**/composer.lock') }}
-          restore-keys: |
-            all-build-${{ hashFiles('**/composer.lock') }}
-            all-build-
+
       - name: Restore/cache tools folder
         uses: actions/cache@v1
         with:
@@ -25,20 +18,24 @@ jobs:
           restore-keys: |
             all-tools-${{ github.sha }}-
             all-tools-
+
       - name: composer
         uses: docker://composer
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           args: install --no-interaction --prefer-dist --optimize-autoloader
+
       - name: composer-require-checker
         uses: docker://phpga/composer-require-checker-ga
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
           args: check --config-file ./composer-require-config.json composer.json
+
       - name: Install phive
         run: make install-phive
+
       - name: Install PHAR dependencies
         run: tools/phive.phar --no-progress install --copy --trust-gpg-keys 4AA394086372C20A,8A03EA3B385DBAA1 --force-accept-unsigned
 
@@ -222,3 +219,52 @@ jobs:
             all-build-
       - name: Roave BC Check
         uses: docker://nyholm/roave-bc-check-ga
+
+  profile:
+    runs-on: ubuntu-latest
+    name: profile
+    needs: [setup, phpunit]
+    services:
+      blackfire:
+        image: blackfire/blackfire
+        ports:
+          - 8707:8707
+        env:
+          BLACKFIRE_SERVER_ID: "517a7aa6-1ec8-4d29-bff8-dddecf4333de"
+          BLACKFIRE_SERVER_TOKEN: "21795bdce7c0b5d24f0ccbb42e2a7518feb5359840752b163652899f927cbf2b"
+
+    steps:
+      - uses: actions/checkout@master
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 7.2
+          extensions: blackfire
+          ini-values: memory_limit=2G, display_errors=On, error_reporting=-1, blackfire.agent_socket=tcp://localhost:8707
+          coverage: none
+
+      - name: Get Composer Cache Directory
+        id: composer-cache
+        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+
+      - name: Cache dependencies
+        uses: actions/cache@v1
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: ${{ runner.os }}-composer-
+
+      - name: Install dependencies
+        run: composer install --prefer-dist --no-progress --no-suggest
+
+      - name: Install phpbench
+        run: |
+          composer global require jaapio/phpbench-blackfire:1.x-dev@dev && \
+          sudo ln -sf "$(composer -q global config home)"/vendor/bin/phpbench /usr/local/bin/phpbench
+
+      - name: Run phpbench
+        run: phpbench run -l blackfire --revs=1 --tag="Build_PR_${{ github.event.number }}"
+        env:
+          BLACKFIRE_CLIENT_ID: ${{ secrets.BLACKFIRE_CLIENT_ID }}
+          BLACKFIRE_CLIENT_TOKEN: ${{ secrets.BLACKFIRE_CLIENT_TOKEN }}

composer.json

@@ -24,7 +24,7 @@
     },
     "autoload-dev": {
         "psr-4": {
-            "phpDocumentor\\Reflection\\": "tests/unit"
+            "phpDocumentor\\Reflection\\": ["tests/unit", "tests/benchmark"]
         }
     },
     "extra": {

phpbench.json

@@ -0,0 +1,10 @@
+{
+  "bootstrap": "vendor/autoload.php",
+  "path": "tests/benchmark",
+  "extensions": [
+    "Jaapio\\Blackfire\\Extension"
+  ],
+  "blackfire" : {
+    "env": "c12030d0-c177-47e2-b466-4994c40dc993"
+  }
+}

src/Types/ContextFactory.php

@@ -23,7 +23,6 @@
 use Reflector;
 use RuntimeException;
 use UnexpectedValueException;
-use function array_merge;
 use function file_exists;
 use function file_get_contents;
 use function get_class;
@@ -166,7 +165,8 @@ public function createForNamespace(string $namespace, string $fileContents) : Co
         $tokens           = new ArrayIterator(token_get_all($fileContents));
 
         while ($tokens->valid()) {
-            switch ($tokens->current()[0]) {
+            $currentToken = $tokens->current();
+            switch ($currentToken[0]) {
                 case T_NAMESPACE:
                     $currentNamespace = $this->parseNamespace($tokens);
                     break;
@@ -177,17 +177,18 @@ public function createForNamespace(string $namespace, string $fileContents) : Co
                     $braceLevel      = 0;
                     $firstBraceFound = false;
                     while ($tokens->valid() && ($braceLevel > 0 || !$firstBraceFound)) {
-                        if ($tokens->current() === '{'
-                            || $tokens->current()[0] === T_CURLY_OPEN
-                            || $tokens->current()[0] === T_DOLLAR_OPEN_CURLY_BRACES) {
+                        $currentToken = $tokens->current();
+                        if ($currentToken === '{'
+                            || $currentToken[0] === T_CURLY_OPEN
+                            || $currentToken[0] === T_DOLLAR_OPEN_CURLY_BRACES) {
                             if (!$firstBraceFound) {
                                 $firstBraceFound = true;
                             }
 
                             ++$braceLevel;
                         }
 
-                        if ($tokens->current() === '}') {
+                        if ($currentToken === '}') {
                             --$braceLevel;
                         }
 
@@ -197,7 +198,7 @@ public function createForNamespace(string $namespace, string $fileContents) : Co
                     break;
                 case T_USE:
                     if ($currentNamespace === $namespace) {
-                        $useStatements = array_merge($useStatements, $this->parseUseStatement($tokens));
+                        $useStatements += $this->parseUseStatement($tokens);
                     }
 
                     break;
@@ -243,12 +244,13 @@ private function parseUseStatement(ArrayIterator $tokens) : array
         while (true) {
             $this->skipToNextStringOrNamespaceSeparator($tokens);
 
-            $uses = array_merge($uses, $this->extractUseStatements($tokens));
-            if ($tokens->current()[0] === self::T_LITERAL_END_OF_USE) {
+            $uses += $this->extractUseStatements($tokens);
+            $currentToken = $tokens->current();
+            if ($currentToken[0] === self::T_LITERAL_END_OF_USE) {
                 return $uses;
             }
 
-            if ($tokens->current() === false) {
+            if ($currentToken === false) {
                 break;
             }
         }
@@ -263,7 +265,12 @@ private function parseUseStatement(ArrayIterator $tokens) : array
      */
     private function skipToNextStringOrNamespaceSeparator(ArrayIterator $tokens) : void
     {
-        while ($tokens->valid() && ($tokens->current()[0] !== T_STRING) && ($tokens->current()[0] !== T_NS_SEPARATOR)) {
+        while ($tokens->valid()) {
+            $currentToken = $tokens->current();
+            if ($currentToken[0] === T_STRING || $currentToken[0] === T_NS_SEPARATOR) {
+                break;
+            }
+
             $tokens->next();
         }
     }