Cleanup

Author: ahjdev

src/TypeResolver.php

@@ -359,16 +359,22 @@ function (TypeNode $nestedType) use ($context): Type {
                 return new This();
 
             case ConditionalTypeNode::class:
-            case ConditionalTypeForParameterNode::class:
-                [$class, $subject] = $type instanceof ConditionalTypeForParameterNode
-                    ? [ConditionalParameter::class, $type->parameterName]
-                    : [Conditional::class, $this->createType($type->subjectType, $context)];
-
-                $target    = $this->createType($type->targetType, $context);
-                $if        = $this->createType($type->if, $context);
-                $else      = $this->createType($type->else, $context);
+                return new Conditional(
+                    $this->createType($type->subjectType, $context),
+                    $this->createType($type->targetType, $context),
+                    $this->createType($type->if, $context),
+                    $this->createType($type->else, $context),
+                    $type->negated
+                );
 
-                return new $class($subject, $target, $if, $else, $type->negated);
+            case ConditionalTypeForParameterNode::class:
+                return new ConditionalParameter(
+                    $type->parameterName,
+                    $this->createType($type->targetType, $context),
+                    $this->createType($type->if, $context),
+                    $this->createType($type->else, $context),
+                    $type->negated
+                );
 
             case OffsetAccessTypeNode::class:
                 $offset = $this->createType($type->offset, $context);