Skip to content

Commit fbd1a9d

Browse files
committed
[!!!TASK] Make all classes final
This library has a very large number of extension points via interfaces and abstract classes. All other classes should not be extended by users and shall theirfor be marked as final. There are a few classes left that should also be marked as final but those require some extra attention.
1 parent 185b77e commit fbd1a9d

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/Graphs/DependencyInjection/Configuration.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
use function assert;
2121

22-
class Configuration implements ConfigurationInterface
22+
final class Configuration implements ConfigurationInterface
2323
{
2424
public function getConfigTreeBuilder(): TreeBuilder
2525
{

src/Graphs/DependencyInjection/GraphsExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
use function dirname;
2323

24-
class GraphsExtension extends Extension implements PrependExtensionInterface
24+
final class GraphsExtension extends Extension implements PrependExtensionInterface
2525
{
2626
/** @param mixed[] $configs */
2727
public function load(array $configs, ContainerBuilder $container): void

src/Graphs/Nodes/UmlNode.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
use phpDocumentor\Guides\Nodes\TextNode;
1717

18-
class UmlNode extends TextNode
18+
final class UmlNode extends TextNode
1919
{
2020
private string $caption = '';
2121

src/Graphs/Renderer/PlantumlRenderer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
use function sys_get_temp_dir;
2525
use function tempnam;
2626

27-
class PlantumlRenderer implements DiagramRenderer
27+
final class PlantumlRenderer implements DiagramRenderer
2828
{
2929
public function __construct(private readonly LoggerInterface $logger, private readonly string $plantUmlBinaryPath)
3030
{

0 commit comments

Comments
 (0)