[TASK] Use the Textrole factory of the DocumentParserContext

Author: linawolf

packages/guides-restructured-text/src/RestructuredText/Directives/DefaultRoleDirective.php

@@ -15,7 +15,6 @@
 
 use phpDocumentor\Guides\RestructuredText\Parser\Directive;
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
-use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
 
 /**
  * sets the default interpreted text role, the role that is used for interpreted text without an explicit role.
@@ -24,11 +23,6 @@
  */
 class DefaultRoleDirective extends ActionDirective
 {
-    public function __construct(
-        private readonly TextRoleFactory $textRoleFactory,
-    ) {
-    }
-
     public function getName(): string
     {
         return 'default-role';
@@ -39,6 +33,6 @@ public function processAction(
         Directive $directive,
     ): void {
         $name = $directive->getData();
-        $this->textRoleFactory->setDefaultTextRole($name);
+        $documentParserContext->getTextRoleFactoryForDocument()->setDefaultTextRole($name);
     }
 }

packages/guides-restructured-text/src/RestructuredText/Directives/RoleDirective.php

@@ -17,7 +17,6 @@
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\TextRoles\BaseTextRole;
 use phpDocumentor\Guides\RestructuredText\TextRoles\GenericTextRole;
-use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
 use Psr\Log\LoggerInterface;
 
 use function is_string;
@@ -33,7 +32,6 @@ class RoleDirective extends ActionDirective
 {
     public function __construct(
         private readonly LoggerInterface $logger,
-        private readonly TextRoleFactory $textRoleFactory,
     ) {
     }
 
@@ -53,7 +51,7 @@ public function processAction(
             $role = $match[2];
         }
 
-        $baseRole = $this->textRoleFactory->getTextRole($role);
+        $baseRole = $documentParserContext->getTextRoleFactoryForDocument()->getTextRole($role);
         if (!$baseRole instanceof BaseTextRole) {
             $this->logger->error('Text role "' . $role . '", class ' . $baseRole::class . ' cannot be extended. ');
 
@@ -71,6 +69,6 @@ public function processAction(
             $customRole->setBaseRole($role);
         }
 
-        $this->textRoleFactory->replaceTextRole($customRole);
+        $documentParserContext->getTextRoleFactoryForDocument()->replaceTextRole($customRole);
     }
 }

packages/guides-restructured-text/src/RestructuredText/Parser/Productions/InlineRules/DefaultTextRoleRule.php

@@ -7,17 +7,12 @@
 use phpDocumentor\Guides\Nodes\Inline\InlineNode;
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\Parser\InlineLexer;
-use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
 
 /**
  * Rule to parse for default text roles such as `something`
  */
 class DefaultTextRoleRule extends AbstractInlineRule
 {
-    public function __construct(private readonly TextRoleFactory $textRoleFactory)
-    {
-    }
-
     public function applies(InlineLexer $lexer): bool
     {
         return $lexer->token?->type === InlineLexer::BACKTICK;
@@ -40,7 +35,10 @@ public function apply(DocumentParserContext $documentParserContext, InlineLexer
 
                     $lexer->moveNext();
 
-                    return $this->textRoleFactory->getDefaultTextRole()->processNode($documentParserContext, '', $text, $text);
+                    return $documentParserContext
+                        ->getTextRoleFactoryForDocument()
+                        ->getDefaultTextRole()
+                        ->processNode($documentParserContext, '', $text, $text);
 
                 default:
                     $text .= $token->value;

packages/guides-restructured-text/src/RestructuredText/Parser/Productions/InlineRules/TextRoleRule.php

@@ -7,7 +7,6 @@
 use phpDocumentor\Guides\Nodes\Inline\InlineNode;
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\Parser\InlineLexer;
-use phpDocumentor\Guides\RestructuredText\TextRoles\TextRoleFactory;
 
 use function substr;
 
@@ -16,10 +15,6 @@
  */
 class TextRoleRule extends AbstractInlineRule
 {
-    public function __construct(private readonly TextRoleFactory $textRoleFactory)
-    {
-    }
-
     public function applies(InlineLexer $lexer): bool
     {
         return $lexer->token?->type === InlineLexer::COLON;
@@ -54,7 +49,7 @@ public function apply(DocumentParserContext $documentParserContext, InlineLexer
                     }
 
                     if ($inText) {
-                        $textRole = $this->textRoleFactory->getTextRole($role, $domain);
+                        $textRole = $documentParserContext->getTextRoleFactoryForDocument()->getTextRole($role, $domain);
                         $fullRole = ($domain ? $domain . ':' : '') . $role;
                         $lexer->moveNext();
 

packages/guides-restructured-text/tests/unit/Parser/InlineTokenParserTest.php

@@ -16,6 +16,8 @@
 use phpDocumentor\Guides\Nodes\Inline\StrongInlineNode;
 use phpDocumentor\Guides\Nodes\Inline\VariableInlineNode;
 use phpDocumentor\Guides\Nodes\InlineCompoundNode;
+use phpDocumentor\Guides\ParserContext;
+use phpDocumentor\Guides\RestructuredText\MarkupLanguageParser;
 use phpDocumentor\Guides\RestructuredText\Parser\Productions\InlineRules\AnnotationRoleRule;
 use phpDocumentor\Guides\RestructuredText\Parser\Productions\InlineRules\AnonymousPhraseRule;
 use phpDocumentor\Guides\RestructuredText\Parser\Productions\InlineRules\AnonymousReferenceRule;
@@ -37,38 +39,43 @@
 use phpDocumentor\Guides\RestructuredText\TextRoles\LiteralTextRole;
 use phpDocumentor\Guides\RestructuredText\TextRoles\ReferenceTextRole;
 use PHPUnit\Framework\Attributes\DataProvider;
-use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 final class InlineTokenParserTest extends TestCase
 {
     public Logger $logger;
-    private DocumentParserContext&MockObject $documentParserContext;
+    private DocumentParserContext $documentParserContext;
     private InlineParser $inlineTokenParser;
+    private DefaultTextRoleFactory $textRoleFactory;
 
     public function setUp(): void
     {
         $this->logger = new Logger('test');
-        $this->documentParserContext = $this->createMock(DocumentParserContext::class);
-        $defaultTextRoleFactory = new DefaultTextRoleFactory(
+        $this->textRoleFactory = new DefaultTextRoleFactory(
             new GenericTextRole(),
             new LiteralTextRole(),
             [
                 new ReferenceTextRole($this->logger),
                 new DocReferenceTextRole($this->logger),
             ],
         );
+        $this->documentParserContext = new DocumentParserContext(
+            '',
+            $this->createStub(ParserContext::class),
+            $this->textRoleFactory,
+            $this->createStub(MarkupLanguageParser::class),
+        );
         $this->inlineTokenParser = new InlineParser([
             new NamedReferenceRule(),
             new AnonymousReferenceRule(),
             new PlainTextRule(),
             new InternalReferenceRule(),
-            new TextRoleRule($defaultTextRoleFactory),
+            new TextRoleRule(),
             new NamedPhraseRule(),
             new AnonymousPhraseRule(),
             new AnnotationRoleRule(),
             new LiteralRule(),
-            new DefaultTextRoleRule($defaultTextRoleFactory),
+            new DefaultTextRoleRule(),
             new StandaloneHyperlinkRule(),
             new EmphasisRule(),
             new StrongRule(),

packages/guides-restructured-text/tests/unit/Parser/Productions/InlineRules/TextRoleRuleTest.php

@@ -6,6 +6,8 @@
 
 use Generator;
 use phpDocumentor\Guides\Nodes\Inline\InlineNode;
+use phpDocumentor\Guides\ParserContext;
+use phpDocumentor\Guides\RestructuredText\MarkupLanguageParser;
 use phpDocumentor\Guides\RestructuredText\Parser\DocumentParserContext;
 use phpDocumentor\Guides\RestructuredText\Parser\InlineLexer;
 use phpDocumentor\Guides\RestructuredText\TextRoles\TextRole;
@@ -87,10 +89,15 @@ public function __construct(
         $lexer->moveNext();
         $lexer->moveNext();
 
-        $textRoleRule = new TextRoleRule($textRoleFactory);
+        $textRoleRule = new TextRoleRule();
         self::assertTrue($textRoleRule->applies($lexer));
         $node = $textRoleRule->apply(
-            $this->createStub(DocumentParserContext::class),
+            new DocumentParserContext(
+                '',
+                $this->createStub(ParserContext::class),
+                $textRoleFactory,
+                $this->createStub(MarkupLanguageParser::class),
+            ),
             $lexer,
         );