Skip to content

Commit e4b7963

Browse files
linawolfgreg0ire
andcommitted
Apply suggestions from code review
Co-authored-by: Grégoire Paris <[email protected]>
1 parent 64710f0 commit e4b7963

File tree

8 files changed

+20
-20
lines changed

8 files changed

+20
-20
lines changed

docs/cli/configuration.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ The cli tool is able to read configuration from a ``guides.xml`` file.
88
You should put this file in the current working directory where you execute
99
the tool. Generally speaking, this is the root of your project.
1010

11-
Using a configuration file allows you to set project specific settings and
11+
Using a configuration file allows you to set project-specific settings and
1212
keep them under version control. Not all options available in the configuration
1313
are available on the command line. Such as the :ref:`extension configuration`.
1414

docs/cli/index.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Create your first documentation
1212
===============================
1313

1414
After :doc:`/installation` you can directly start to create your first documentation.
15-
to do this create a new directory named ``docs`` and create a file called ``index.rst`` in it.
15+
to do this, create a new directory named ``docs`` and create a file called ``index.rst`` in it.
1616

1717
.. code-block:: rst
1818
@@ -49,6 +49,6 @@ to learn more about the configuration.
4949
Extending
5050
=========
5151

52-
Like any other component in this repository the commandline tool can be extended. This can
53-
be done using an extension class. And reference this class in the configuration file. Like
52+
Like any other component in this repository, the commandline tool can be extended. This can
53+
be done using an extension class, and referencing this class in the configuration file, like
5454
shown for in the :ref:`.extension-configuration` section.

docs/components/compiler.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ Compiler
99
This library uses a simplified compiler design. This basically means that our pipeline contains less steps
1010
than a regular compiler. But its following the same semantics.
1111

12-
stages
12+
Stages
1313
======
1414

1515
Lexing and Parsing
@@ -41,7 +41,7 @@ Extending
4141
=========
4242

4343
The compiler is designed to be extended. This allows you to remove or add nodes to the AST or mutate the AST in any way
44-
you like. Compiler extension is mostly done when you want want to do dynamic calulations based on the AST. The mutations
44+
you like. Compiler extension is mostly done when you want want to do dynamic calculations based on the AST. The mutations
4545
will not have direct impact on the rendering process. Style changes should be done in the rendering phase.
4646

4747
To read more about extending the compiler, see :ref:`extending_compiler`.

docs/developers/compiler.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ If you want to extend the compiler to support new features there are two options
1616
NodeTransformer
1717
===============
1818

19-
Node transformers are used to transform specific types of nodes in the AST. This is usefull when you want to remove
19+
Node transformers are used to transform specific types of nodes in the AST. This is useful when you want to remove
2020
a node type or manipulate nodes of a specific type. Your new node transformer should implement the :php:class:`phpDocumentor\Guides\Compiler\NodeTransformer`
2121
interface and you should register it in the dependency injection container.
2222

@@ -33,13 +33,13 @@ interface and you should register it in the dependency injection container.
3333
.. note::
3434

3535
The tag `phpdoc.guides.compiler.nodeTransformers` is used to register the node transformer in the compiler. The higher
36-
the priority of the node transformer, the earlier it will be executed. Where higest priority is `PHP_INT_MAX`, lower
36+
the priority of the node transformer, the earlier it will be executed. Where highest priority is `PHP_INT_MAX`, lower
3737
number is lower priority.
3838

3939
CompilerPass
4040
============
4141

42-
If you want to do more complex transformations for example transformations that require multiple nodes to be transformed
42+
If you want to do more complex transformations, for example transformations that require multiple nodes to be transformed
4343
you should implement a :php:class:`phpDocumentor\Guides\Compiler\CompilerPass`. A compiler pass needs to be registered
4444
just like a node transformer.
4545

@@ -56,5 +56,5 @@ just like a node transformer.
5656
.. note::
5757

5858
The tag `phpdoc.guides.compiler.passes` is used to register the node transformer in the compiler. The higher
59-
the priority of the node transformer, the earlier it will be executed. Where higest priority is `PHP_INT_MAX`, lower
59+
the priority of the node transformer, the earlier it will be executed. Where highest priority is `PHP_INT_MAX`, lower
6060
number is lower priority.

docs/developers/directive.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ will do the actual processing of the directive.
88

99
.. hint::
1010

11-
This project contains a lot of directives. You can find them in the :php:namespace:`\phpDocumentor\Guides\RestructuredText\Directives` namespace.
12-
Including the way how to use them.
11+
This project contains a lot of directives. You can find them in the :php:namespace:`\phpDocumentor\Guides\RestructuredText\Directives` namespace,
12+
including the way to use them.
1313

14-
To implement a directive you need to create a class that extends :php:class:`\phpDocumentor\Guides\RestructuredText\Directives\BaseDirective`.
15-
And register it with the parser using a :ref:`custom extension <developer-extension>`.
14+
To implement a directive you need to create a class that extends :php:class:`\phpDocumentor\Guides\RestructuredText\Directives\BaseDirective`,
15+
and register it with the parser using a :ref:`custom extension <developer-extension>`.
1616

1717
.. code-block:: php
1818
:caption: your-extension.php
@@ -24,7 +24,7 @@ And register it with the parser using a :ref:`custom extension <developer-extens
2424
->set(YourDirective::class)
2525
->tag('phpdoc.guides.directive');
2626
27-
By design this library distinguishes between three types of directives:
27+
By design, this library distinguishes between three types of directives:
2828

2929
- :php:class:`phpDocumentor\Guides\RestructuredText\Directives\SubDirective`
3030
This is the most common directive type. It is used to add a new node type to the document tree that allows you to do
@@ -39,7 +39,7 @@ By design this library distinguishes between three types of directives:
3939
This is the most advanced directive type. You are on your own here. You need to do everything yourself.
4040

4141
Implement a sub directive
42-
========================
42+
=========================
4343

4444
A sub directivehandler is a node with child nodes. The parser will take care of the parsing of the directive content.
4545
All you need to do is create a node and add the content.

docs/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ your documentation from `reStructuredText Markup <https://docutils.sourceforge.i
2222
formats.
2323

2424
Besides the commandline tool it also provides a number of libraries that can be used to build your own application
25-
to render the supported formats. To any format you want. On these pages is explained how to use the commandline tool
25+
to render the supported formats, to any format you want. On these pages is explained how to use the commandline tool
2626
and how to use the libraries.
2727

2828
If you are looking for a complete solution to create a documentation website then you may want to look at

docs/installation.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ This will install the commandline tool in the vendor/bin directory. You can then
2727
2828
vendor/bin/guides ./docs
2929
30-
The commandline tool is build for extension, if you do not have special needs this is the
30+
The commandline tool is built for extension, if you do not have special needs this is the
3131
recommended way to get started. You can learn more about how to extend the commandline tool in the :doc:`/cli/index` section.
3232

3333
Library (advanced)
34-
===============================
34+
==================
3535

3636
.. _library:
3737

docs/reference/restructuredtext/admonitions.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Admonitions
77
===========
88

99
Admonitions are blocks of text that are rendered in a special way to draw attention to them. They are often used to
10-
provide additional information to the reader about the content that is being discussed. t6est
10+
provide additional information to the reader about the content that is being discussed.
1111

1212
.. index:: reST directives; seealso
1313

0 commit comments

Comments
 (0)