Chore: add RequireNumericLiteralSeparator style rule

Co-authored-by: Grégoire Paris <[email protected]>

Author: jaapio

packages/guides-restructured-text/src/RestructuredText/Parser/Productions/InlineRules/LiteralRule.php

@@ -36,6 +36,6 @@ public function apply(ParserContext $parserContext, InlineLexer $lexer): Literal
     public function getPriority(): int
     {
         // Should be executed first as any other rules within may not be interpreted
-        return 10000;
+        return 10_000;
     }
 }

packages/guides/src/Compiler/NodeTransformers/CitationTargetTransformer.php

@@ -40,6 +40,6 @@ public function supports(Node $node): bool
 
     public function getPriority(): int
     {
-        return 20000;
+        return 20_000;
     }
 }

packages/guides/src/Compiler/NodeTransformers/ClassNodeTransformer.php

@@ -61,6 +61,6 @@ public function supports(Node $node): bool
 
     public function getPriority(): int
     {
-        return 40000;
+        return 40_000;
     }
 }

packages/guides/src/Compiler/NodeTransformers/FootNodeNamedTransformer.php

@@ -41,6 +41,6 @@ public function supports(Node $node): bool
     public function getPriority(): int
     {
         // must be run *after* FootNodeNumberedTransformer
-        return 20000;
+        return 20_000;
     }
 }

packages/guides/src/Compiler/NodeTransformers/FootNodeNumberedTransformer.php

@@ -40,6 +40,6 @@ public function supports(Node $node): bool
     public function getPriority(): int
     {
         // must be run *before* FootNodeNamedTransformer
-        return 30000;
+        return 30_000;
     }
 }

packages/guides/src/Compiler/NodeTransformers/MoveAnchorTransformer.php

@@ -58,7 +58,7 @@ public function supports(Node $node): bool
 
     public function getPriority(): int
     {
-        return 30000;
+        return 30_000;
     }
 
     /** @param TreeNode<Node> $parent */

packages/guides/src/Compiler/NodeTransformers/VariableInlineNodeTransformer.php

@@ -59,6 +59,6 @@ public function supports(Node $node): bool
     public function getPriority(): int
     {
         // Late, other replacements should already have happened
-        return 30000;
+        return 30_000;
     }
 }

packages/guides/src/Compiler/Passes/ImplicitHyperlinkTargetPass.php

@@ -30,7 +30,7 @@ class ImplicitHyperlinkTargetPass implements CompilerPass
 {
     public function getPriority(): int
     {
-        return 20000; // must be run *before* MetasPass
+        return 20_000; // must be run *before* MetasPass
     }
 
     /** {@inheritDoc} */

packages/guides/tests/unit/Compiler/NodeTransformers/MoveAnchorTransformerTest.php

@@ -33,7 +33,7 @@ public function getPriorities(): array
             {
                 return [];
             }
-        }, 30000);
+        }, 30_000);
     }
 
     public function testAnchorNodeShouldBeMovedToNextSectionNodeWhenPositionedAboveSection(): void

phpcs.xml.dist

@@ -31,6 +31,12 @@
         <exclude-pattern>packages/guides/src/Setup/QuickStart.php</exclude-pattern>
     </rule>
 
+    <rule ref="SlevomatCodingStandard.Numbers.RequireNumericLiteralSeparator">
+        <properties>
+            <property name="minDigitsBeforeDecimalPoint" value="5"/>
+        </properties>
+    </rule>
+
     <rule ref="PSR2">
         <include-pattern>*\.php</include-pattern>
     </rule>