Skip to content

Commit efa5b75

Browse files
authored
Merge pull request #836 from wouterj/issue-829/version-is-string
Revert phpize for versions, never treat them like numbers
2 parents 612e00b + fa4f558 commit efa5b75

File tree

2 files changed

+17
-2
lines changed
  • packages/guides/src/DependencyInjection
  • tests/Integration/tests/meta/version-from-guides-xml/input

2 files changed

+17
-2
lines changed

packages/guides/src/DependencyInjection/GuidesExtension.php

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,10 @@
3838
use function assert;
3939
use function dirname;
4040
use function is_array;
41+
use function is_int;
42+
use function is_string;
4143
use function pathinfo;
44+
use function var_export;
4245

4346
final class GuidesExtension extends Extension implements CompilerPassInterface, ConfigurationInterface, PrependExtensionInterface
4447
{
@@ -55,7 +58,20 @@ public function getConfigTreeBuilder(): TreeBuilder
5558
->arrayNode('project')
5659
->children()
5760
->scalarNode('title')->end()
58-
->scalarNode('version')->end()
61+
->scalarNode('version')
62+
->beforeNormalization()
63+
->always(
64+
// We need to revert the phpize call in XmlUtils. Version is always a string!
65+
static function ($value) {
66+
if (!is_int($value) && !is_string($value)) {
67+
return var_export($value, true);
68+
}
69+
70+
return $value;
71+
},
72+
)
73+
->end()
74+
->end()
5975
->scalarNode('release')->end()
6076
->scalarNode('copyright')->end()
6177
->end()

tests/Integration/tests/meta/version-from-guides-xml/input/skip

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)