[TASK] Refactor isEqualAbsolutePath and isEqualRelativePath into matches

Author: linawolf

packages/guides/src/Compiler/NodeTransformers/MenuNodeTransformers/AbstractMenuEntryNodeTransformer.php

@@ -40,7 +40,7 @@ final public function enterNode(Node $node, CompilerContext $compilerContext): N
         return $node;
     }
 
-    public final function leaveNode(Node $node, CompilerContext $compilerContext): Node|null
+    final public function leaveNode(Node $node, CompilerContext $compilerContext): Node|null
     {
         if ($node instanceof MenuNode) {
             $this->currentMenu = null;

packages/guides/src/Compiler/NodeTransformers/MenuNodeTransformers/GlobMenuEntryNodeTransformer.php

@@ -38,8 +38,7 @@ protected function handleMenuEntry(MenuNode $currentMenu, MenuEntryNode $node, C
         $menuEntries = [];
         foreach ($documentEntries as $documentEntry) {
             if (
-                !self::isEqualAbsolutePath($documentEntry->getFile(), $node, $currentPath, $globExclude)
-                && !self::isEqualRelativePath($documentEntry->getFile(), $node, $currentPath, $globExclude)
+                !self::matches($documentEntry->getFile(), $node, $currentPath, $globExclude)
             ) {
                 continue;
             }
@@ -92,27 +91,15 @@ public function getPriority(): int
         return 4500;
     }
 
-    /** @param String[] $globExclude */
-    private static function isEqualAbsolutePath(string $actualFile, GlobMenuEntryNode $parsedMenuEntryNode, string $currentFile, array $globExclude): bool
+    private static function matches(string $actualFile, GlobMenuEntryNode $parsedMenuEntryNode, string $currentFile, array $globExclude): bool
     {
         $expectedFile = $parsedMenuEntryNode->getUrl();
-        if (!self::isAbsoluteFile($expectedFile)) {
-            return false;
-        }
-
-        if ($expectedFile === '/' . $actualFile) {
-            return true;
-        }
-
-        return self::isGlob($actualFile, $currentFile, $expectedFile, '/', $globExclude);
-    }
-
-    /** @param String[] $globExclude */
-    private static function isEqualRelativePath(string $actualFile, GlobMenuEntryNode $menuEntryNode, string $currentFile, array $globExclude): bool
-    {
-        $expectedFile = $menuEntryNode->getUrl();
         if (self::isAbsoluteFile($expectedFile)) {
-            return false;
+            if ($expectedFile === '/' . $actualFile) {
+                return true;
+            }
+
+            return self::isGlob($actualFile, $currentFile, $expectedFile, '/', $globExclude);
         }
 
         $current = explode('/', $currentFile);