TemplateImageValidator

Author: tatevikg1

resources/translations/messages.en.xlf

@@ -357,6 +357,23 @@
                 <target>Batch limit reached, sleeping %sleep%s to respect MAILQUEUE_BATCH_PERIOD</target>
             </trans-unit>
 
+            <trans-unit id="messaging.validation.image_url">
+                <source>Value must be an array of image URLs.</source>
+                <target>Value must be an array of image URLs.</target>
+            </trans-unit>
+            <trans-unit id="messaging.validation.image_url_not_full">
+                <source>Image "%url%" is not a full URL.</source>
+                <target>Image "%url%" is not a full URL.</target>
+            </trans-unit>
+            <trans-unit id="messaging.validation.image_url_not_exists">
+                <source>Image "%url%" does not exist (HTTP %code%)</source>
+                <target>Image "%url%" does not exist (HTTP %code%)</target>
+            </trans-unit>
+            <trans-unit id="messaging.validation.image_url_cant_validate">
+                <source>Image "%url%" could not be validated: %message%</source>
+                <target>Image "%url%" could not be validated: %message%</target>
+            </trans-unit>
+
             <!-- Subscription -->
             <trans-unit id="subscription.list_not_found">
                 <source>Subscriber list not found.</source>

src/Domain/Messaging/Validator/TemplateImageValidator.php

@@ -9,18 +9,21 @@
 use PhpList\Core\Domain\Common\Model\ValidationContext;
 use PhpList\Core\Domain\Common\Validator\ValidatorInterface;
 use Symfony\Component\Validator\Exception\ValidatorException;
+use Symfony\Contracts\Translation\TranslatorInterface;
 use Throwable;
 
 class TemplateImageValidator implements ValidatorInterface
 {
-    public function __construct(private readonly ClientInterface $httpClient)
-    {
+    public function __construct(
+        private readonly ClientInterface $httpClient,
+        private readonly TranslatorInterface $translator,
+    ) {
     }
 
     public function validate(mixed $value, ValidationContext $context = null): void
     {
         if (!is_array($value)) {
-            throw new InvalidArgumentException('Value must be an array of image URLs.');
+            throw new InvalidArgumentException($this->translator->trans('Value must be an array of image URLs.'));
         }
 
         $checkFull = $context?->get('checkImages', false);
@@ -42,7 +45,7 @@ private function validateFullUrls(array $urls): array
 
         foreach ($urls as $url) {
             if (!preg_match('#^https?://#i', $url)) {
-                $errors[] = sprintf('Image "%s" is not a full URL.', $url);
+                $errors[] = $this->translator->trans('Image "%url%" is not a full URL.', ['%url%' => $url]);
             }
         }
 
@@ -61,10 +64,16 @@ private function validateExistence(array $urls): array
             try {
                 $response = $this->httpClient->request('HEAD', $url);
                 if ($response->getStatusCode() !== 200) {
-                    $errors[] = sprintf('Image "%s" does not exist (HTTP %s)', $url, $response->getStatusCode());
+                    $errors[] = $this->translator->trans('Image "%url%" does not exist (HTTP %code%)', [
+                        '%url%' => $url,
+                        '%code%' => $response->getStatusCode()
+                    ]);
                 }
             } catch (Throwable $e) {
-                $errors[] = sprintf('Image "%s" could not be validated: %s', $url, $e->getMessage());
+                $errors[] = $this->translator->trans('Image "%url%" could not be validated: %message%', [
+                    '%url%' => $url,
+                    '%message%' => $e->getMessage()
+                ]);
             }
         }
 

tests/Unit/Domain/Messaging/Validator/TemplateImageValidatorTest.php

@@ -12,6 +12,7 @@
 use PhpList\Core\Domain\Messaging\Validator\TemplateImageValidator;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Translation\Translator;
 use Symfony\Component\Validator\Exception\ValidatorException;
 
 class TemplateImageValidatorTest extends TestCase
@@ -22,7 +23,7 @@ class TemplateImageValidatorTest extends TestCase
     protected function setUp(): void
     {
         $this->httpClient = $this->createMock(ClientInterface::class);
-        $this->validator = new TemplateImageValidator($this->httpClient);
+        $this->validator = new TemplateImageValidator($this->httpClient, new Translator('en'));
     }
 
     public function testThrowsExceptionIfValueIsNotArray(): void