Fix: cs

Author: tatevikg1

.github/workflows/ci.yml

@@ -75,4 +75,4 @@ jobs:
       - name: Running PHPMD
         run: vendor/bin/phpmd src/ text config/PHPMD/rules.xml;
       - name: Running PHP_CodeSniffer
-        run: vendor/bin/phpcs --standard=config/PhpCodeSniffer/ bin/ src/ tests/ public/;
+        run: vendor/bin/phpcs --standard=config/PhpCodeSniffer/ --ignore=*/Migrations/* bin/ src/ tests/ public/;

config/PHPMD/rules.xml

@@ -4,6 +4,8 @@
         PHPMD rules for phpList
     </description>
 
+    <exclude-pattern>*/Migrations/*</exclude-pattern>
+
     <!-- rules from the "clean code" rule set -->
     <rule ref="rulesets/cleancode.xml/BooleanArgumentFlag"/>
     <rule ref="rulesets/cleancode.xml/StaticAccess">
@@ -71,5 +73,4 @@
     <rule ref="rulesets/unusedcode.xml/UnusedPrivateField"/>
     <rule ref="rulesets/unusedcode.xml/UnusedLocalVariable"/>
     <rule ref="rulesets/unusedcode.xml/UnusedPrivateMethod"/>
-    <rule ref="rulesets/unusedcode.xml/UnusedFormalParameter"/>
 </ruleset>

src/Core/Doctrine/OnlyOrmTablesFilter.php

@@ -16,13 +16,15 @@ class OnlyOrmTablesFilter
     /** @var string[]|null */
     private ?array $allowPrefixes = null;
 
-    public function __construct(private readonly EntityManagerInterface $entityManager) {}
+    public function __construct(private readonly EntityManagerInterface $entityManager)
+    {
+    }
 
     public function __invoke(string|AbstractAsset $asset): bool
     {
         $name = \is_string($asset) ? $asset : $asset->getName();
-
-        if (false !== ($pos = strrpos($name, '.'))) {
+        $pos = strrpos($name, '.');
+        if (false !== $pos) {
             $name = substr($name, $pos + 1);
         }
         $nameLower = strtolower($name);
@@ -56,12 +58,13 @@ private function buildAllowOnce(): array
         }
 
         $tables = [];
-        foreach ($this->entityManager->getMetadataFactory()->getAllMetadata() as $m) {
-            if ($t = $m->getTableName()) {
-                $tables[] = strtolower($t);
+        foreach ($this->entityManager->getMetadataFactory()->getAllMetadata() as $metadatum) {
+            $tableName = $metadatum->getTableName();
+            if ($tableName) {
+                $tables[] = strtolower($tableName);
             }
             // many-to-many join tables
-            foreach ($m->getAssociationMappings() as $assoc) {
+            foreach ($metadatum->getAssociationMappings() as $assoc) {
                 if (!empty($assoc['joinTable']['name'])) {
                     $tables[] = strtolower($assoc['joinTable']['name']);
                 }
@@ -71,7 +74,7 @@ private function buildAllowOnce(): array
         $tables[] = 'doctrine_migration_versions';
 
         $tables = array_values(array_unique($tables));
-        $prefixes = array_map(static fn($t) => $t . '_', $tables);
+        $prefixes = array_map(static fn($table) => $table . '_', $tables);
 
         $this->allow = $tables;
         $this->allowPrefixes = $prefixes;

src/Domain/Identity/Command/CleanUpOldSessionTokens.php

@@ -28,9 +28,6 @@ public function __construct(AdministratorTokenRepository $tokenRepository, Entit
         $this->entityManager = $entityManager;
     }
 
-    /**
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
-     */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         try {

src/Domain/Messaging/Command/ProcessQueueCommand.php

@@ -57,9 +57,6 @@ public function __construct(
         $this->entityManager = $entityManager;
     }
 
-    /**
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
-     */
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $lock = $this->lockFactory->createLock('queue_processor');

src/Migrations/Version20251028092901MySql.php

@@ -18,10 +18,6 @@ public function getDescription(): string
         return 'Initial schema from SQL file generated from phplist3';
     }
 
-    /**
-     * @SuppressWarnings(PHPMD.ShortMethodName)
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
-     */
     public function up(Schema $schema): void
     {
         $platform = $this->connection->getDatabasePlatform();

src/Routing/ExtraLoader.php

@@ -43,8 +43,6 @@ public function __construct(ApplicationStructure $applicationStructure)
     /**
      * Loads a resource.
      *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
-     *
      * @param mixed $resource the resource (unused)
      * @param string|null $type the resource type or null if unknown (unused)
      *
@@ -69,8 +67,6 @@ public function load($resource, string $type = null): RouteCollection
     /**
      * Checks whether this class supports the given resource.
      *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
-     *
      * @param mixed $resource a resource (unused)
      * @param string|null $type The resource type or null if unknown
      *