ISSUE-345: attribute type validator

Author: tatevikg1

config/services/validators.yml

@@ -6,3 +6,7 @@ services:
   PhpList\Core\Domain\Messaging\Validator\TemplateImageValidator:
     autowire: true
     autoconfigure: true
+
+  PhpList\Core\Domain\Subscription\Validator\AttributeTypeValidator:
+    autowire: true
+    autoconfigure: true

src/Domain/Identity/Service/AdminAttributeDefinitionManager.php

@@ -8,14 +8,19 @@
 use PhpList\Core\Domain\Identity\Model\Dto\AdminAttributeDefinitionDto;
 use PhpList\Core\Domain\Identity\Repository\AdminAttributeDefinitionRepository;
 use PhpList\Core\Domain\Identity\Exception\AttributeDefinitionCreationException;
+use PhpList\Core\Domain\Subscription\Validator\AttributeTypeValidator;
 
 class AdminAttributeDefinitionManager
 {
     private AdminAttributeDefinitionRepository $definitionRepository;
+    private AttributeTypeValidator $attributeTypeValidator;
 
-    public function __construct(AdminAttributeDefinitionRepository $definitionRepository)
-    {
+    public function __construct(
+        AdminAttributeDefinitionRepository $definitionRepository,
+        AttributeTypeValidator $attributeTypeValidator
+    ) {
         $this->definitionRepository = $definitionRepository;
+        $this->attributeTypeValidator = $attributeTypeValidator;
     }
 
     public function create(AdminAttributeDefinitionDto $attributeDefinitionDto): AdminAttributeDefinition
@@ -24,6 +29,7 @@ public function create(AdminAttributeDefinitionDto $attributeDefinitionDto): Adm
         if ($existingAttribute) {
             throw new AttributeDefinitionCreationException('Attribute definition already exists', 409);
         }
+        $this->attributeTypeValidator->validate($attributeDefinitionDto->type);
 
         $attributeDefinition = (new AdminAttributeDefinition($attributeDefinitionDto->name))
             ->setType($attributeDefinitionDto->type)
@@ -45,6 +51,7 @@ public function update(
         if ($existingAttribute && $existingAttribute->getId() !== $attributeDefinition->getId()) {
             throw new AttributeDefinitionCreationException('Another attribute with this name already exists.', 409);
         }
+        $this->attributeTypeValidator->validate($attributeDefinitionDto->type);
 
         $attributeDefinition
             ->setName($attributeDefinitionDto->name)

src/Domain/Subscription/Service/Manager/AttributeDefinitionManager.php

@@ -8,14 +8,19 @@
 use PhpList\Core\Domain\Subscription\Model\Dto\AttributeDefinitionDto;
 use PhpList\Core\Domain\Subscription\Model\SubscriberAttributeDefinition;
 use PhpList\Core\Domain\Subscription\Repository\SubscriberAttributeDefinitionRepository;
+use PhpList\Core\Domain\Subscription\Validator\AttributeTypeValidator;
 
 class AttributeDefinitionManager
 {
     private SubscriberAttributeDefinitionRepository $definitionRepository;
+    private AttributeTypeValidator $attributeTypeValidator;
 
-    public function __construct(SubscriberAttributeDefinitionRepository $definitionRepository)
-    {
+    public function __construct(
+        SubscriberAttributeDefinitionRepository $definitionRepository,
+        AttributeTypeValidator $attributeTypeValidator
+    ) {
         $this->definitionRepository = $definitionRepository;
+        $this->attributeTypeValidator = $attributeTypeValidator;
     }
 
     public function create(AttributeDefinitionDto $attributeDefinitionDto): SubscriberAttributeDefinition
@@ -24,6 +29,7 @@ public function create(AttributeDefinitionDto $attributeDefinitionDto): Subscrib
         if ($existingAttribute) {
             throw new AttributeDefinitionCreationException('Attribute definition already exists', 409);
         }
+        $this->attributeTypeValidator->validate($attributeDefinitionDto->type);
 
         $attributeDefinition = (new SubscriberAttributeDefinition())
             ->setName($attributeDefinitionDto->name)
@@ -46,6 +52,7 @@ public function update(
         if ($existingAttribute && $existingAttribute->getId() !== $attributeDefinition->getId()) {
             throw new AttributeDefinitionCreationException('Another attribute with this name already exists.', 409);
         }
+        $this->attributeTypeValidator->validate($attributeDefinitionDto->type);
 
         $attributeDefinition
             ->setName($attributeDefinitionDto->name)

src/Domain/Subscription/Validator/AttributeTypeValidator.php

@@ -0,0 +1,44 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpList\Core\Domain\Subscription\Validator;
+
+use InvalidArgumentException;
+use PhpList\Core\Domain\Common\Model\ValidationContext;
+use PhpList\Core\Domain\Common\Validator\ValidatorInterface;
+use Symfony\Component\Validator\Exception\ValidatorException;
+
+class AttributeTypeValidator implements ValidatorInterface
+{
+    private const VALID_TYPES = [
+        'textline',
+        'checkbox',
+        'checkboxgroup',
+        'radio',
+        'select',
+        'hidden',
+        'textarea',
+        'date',
+    ];
+
+    public function validate(mixed $value, ValidationContext $context = null): void
+    {
+        if (!is_string($value)) {
+            throw new InvalidArgumentException('Value must be a string.');
+        }
+
+        $errors = [];
+        if (!in_array($value, self::VALID_TYPES, true)) {
+            $errors[] = sprintf(
+                'Invalid attribute type: "%s". Valid types are: %s',
+                $value,
+                implode(', ', self::VALID_TYPES)
+            );
+        }
+
+        if (!empty($errors)) {
+            throw new ValidatorException(implode("\n", $errors));
+        }
+    }
+}

tests/Unit/Domain/Identity/Service/AdminAttributeDefinitionManagerTest.php

@@ -9,6 +9,7 @@
 use PhpList\Core\Domain\Identity\Repository\AdminAttributeDefinitionRepository;
 use PhpList\Core\Domain\Identity\Service\AdminAttributeDefinitionManager;
 use PhpList\Core\Domain\Identity\Exception\AttributeDefinitionCreationException;
+use PhpList\Core\Domain\Subscription\Validator\AttributeTypeValidator;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
@@ -20,7 +21,8 @@ class AdminAttributeDefinitionManagerTest extends TestCase
     protected function setUp(): void
     {
         $this->repository = $this->createMock(AdminAttributeDefinitionRepository::class);
-        $this->subject = new AdminAttributeDefinitionManager($this->repository);
+        $attributeTypeValidator = $this->createMock(AttributeTypeValidator::class);
+        $this->subject = new AdminAttributeDefinitionManager($this->repository, $attributeTypeValidator);
     }
 
     public function testCreateCreatesNewAttributeDefinition(): void

tests/Unit/Domain/Subscription/Service/AttributeDefinitionManagerTest.php

@@ -9,14 +9,16 @@
 use PhpList\Core\Domain\Subscription\Model\SubscriberAttributeDefinition;
 use PhpList\Core\Domain\Subscription\Repository\SubscriberAttributeDefinitionRepository;
 use PhpList\Core\Domain\Subscription\Service\Manager\AttributeDefinitionManager;
+use PhpList\Core\Domain\Subscription\Validator\AttributeTypeValidator;
 use PHPUnit\Framework\TestCase;
 
 class AttributeDefinitionManagerTest extends TestCase
 {
     public function testCreateAttributeDefinition(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
-        $manager = new AttributeDefinitionManager($repository);
+        $validator = $this->createMock(AttributeTypeValidator::class);
+        $manager = new AttributeDefinitionManager($repository, $validator);
 
         $dto = new AttributeDefinitionDto(
             name: 'Country',
@@ -48,7 +50,8 @@ public function testCreateAttributeDefinition(): void
     public function testCreateThrowsWhenAttributeAlreadyExists(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
-        $manager = new AttributeDefinitionManager($repository);
+        $validator = $this->createMock(AttributeTypeValidator::class);
+        $manager = new AttributeDefinitionManager($repository, $validator);
 
         $dto = new AttributeDefinitionDto(
             name: 'Country',
@@ -74,7 +77,8 @@ public function testCreateThrowsWhenAttributeAlreadyExists(): void
     public function testUpdateAttributeDefinition(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
-        $manager = new AttributeDefinitionManager($repository);
+        $validator = $this->createMock(AttributeTypeValidator::class);
+        $manager = new AttributeDefinitionManager($repository, $validator);
 
         $attribute = new SubscriberAttributeDefinition();
         $attribute->setName('Old');
@@ -108,7 +112,8 @@ public function testUpdateAttributeDefinition(): void
     public function testUpdateThrowsWhenAnotherAttributeWithSameNameExists(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
-        $manager = new AttributeDefinitionManager($repository);
+        $validator = $this->createMock(AttributeTypeValidator::class);
+        $manager = new AttributeDefinitionManager($repository, $validator);
 
         $dto = new AttributeDefinitionDto(
             name: 'Existing',
@@ -138,7 +143,8 @@ public function testUpdateThrowsWhenAnotherAttributeWithSameNameExists(): void
     public function testDeleteAttributeDefinition(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
-        $manager = new AttributeDefinitionManager($repository);
+        $validator = $this->createMock(AttributeTypeValidator::class);
+        $manager = new AttributeDefinitionManager($repository, $validator);
 
         $attribute = new SubscriberAttributeDefinition();
 

tests/Unit/Domain/Subscription/Validator/AttributeTypeValidatorTest.php

@@ -0,0 +1,45 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpList\Core\Tests\Unit\Domain\Subscription\Validator;
+
+use InvalidArgumentException;
+use PhpList\Core\Domain\Subscription\Validator\AttributeTypeValidator;
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Validator\Exception\ValidatorException;
+
+class AttributeTypeValidatorTest extends TestCase
+{
+    private AttributeTypeValidator $validator;
+
+    protected function setUp(): void
+    {
+        $this->validator = new AttributeTypeValidator();
+    }
+
+    public function testValidatesValidType(): void
+    {
+        $this->validator->validate('textline');
+        $this->validator->validate('checkbox');
+        $this->validator->validate('date');
+        
+        $this->assertTrue(true);
+    }
+
+    public function testThrowsExceptionForInvalidType(): void
+    {
+        $this->expectException(ValidatorException::class);
+        $this->expectExceptionMessage('Invalid attribute type: "invalid_type"');
+        
+        $this->validator->validate('invalid_type');
+    }
+
+    public function testThrowsExceptionForNonStringValue(): void
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Value must be a string.');
+        
+        $this->validator->validate(123);
+    }
+}