@@ -13,13 +13,14 @@ reviews:
1313 instructions : |
1414 You are reviewing PHP domain-layer code. Enforce domain purity, with a relaxed policy for DynamicListAttr:
1515
16- - ❌ Do not allow persistence or transaction side effects here for *normal* domain models.
17- - Flag ANY usage of Doctrine persistence APIs on regular domain entities, especially:
16+ - ❌ Do not allow, flag ANY DB write / finalization:
1817 - `$entityManager->flush(...)`, `$this->entityManager->flush(...)`
19- - `$em->persist(... )`, `$em->remove (...)`
20- - `$em->beginTransaction()`, `$em->commit()`, `$em->rollback()`
18+ - `$em->beginTransaction( )`, `$em->commit()`, `$em->rollback()`, `$em->transactional (...)`
19+ - `$em->getConnection()->executeStatement(...)` for DML/DDL (INSERT/UPDATE/DELETE/ALTER/...)
2120 - ✅ Accessing Doctrine *metadata*, *schema manager*, or *read-only schema info* is acceptable
22- as long as it does not modify state or perform writes.
21+ as long as it does not modify state or perform writes. Accessing Doctrine *persistence APIs*
22+ persist, remove, flush, etc.) is acceptable,
23+ allow scheduling changes in the UnitOfWork (no DB writes)
2324
2425 - ✅ **Relaxed rule for DynamicListAttr-related code**:
2526 - DynamicListAttr is a special case dealing with dynamic tables/attrs.
0 commit comments