Add tests

Author: tatevikg1

src/Domain/Messaging/Command/ProcessBouncesCommand.php

@@ -21,6 +21,10 @@
 #[AsCommand(name: 'phplist:bounces:process', description: 'Process bounce mailbox')]
 class ProcessBouncesCommand extends Command
 {
+    private const IMAP_NOT_AVAILABLE = 'PHP IMAP extension not available. Falling back to Webklex IMAP.';
+    private const FORCE_LOCK_FAILED = 'Could not apply force lock. Aborting.';
+    private const ALREADY_LOCKED = 'Another bounce processing is already running. Aborting.';
+
     protected function configure(): void
     {
         $this
@@ -53,16 +57,16 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $inputOutput = new SymfonyStyle($input, $output);
 
         if (!function_exists('imap_open')) {
-            $inputOutput->note('PHP IMAP extension not available. Falling back to Webklex IMAP where applicable.');
+            $inputOutput->note(self::IMAP_NOT_AVAILABLE);
         }
 
         $force = (bool)$input->getOption('force');
         $lock = $this->lockService->acquirePageLock('bounce_processor', $force);
 
-        if (!$lock) {
-            $inputOutput->warning('Another bounce processing is already running. Aborting.');
+        if (($lock ?? 0) === 0) {
+            $inputOutput->warning($force ? self::FORCE_LOCK_FAILED : self::ALREADY_LOCKED);
 
-            return Command::SUCCESS;
+            return $force ? Command::FAILURE : Command::SUCCESS;
         }
 
         try {
@@ -71,14 +75,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
             $downloadReport = '';
 
-            $processor = null;
-            foreach ($this->protocolProcessors as $p) {
-                if ($p->getProtocol() === $protocol) {
-                    $processor = $p;
-                    break;
-                }
-            }
-
+            $processor = $this->findProcessorFor($protocol);
             if ($processor === null) {
                 $inputOutput->error('Unsupported protocol: '.$protocol);
 
@@ -103,4 +100,15 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $this->lockService->release($lock);
         }
     }
+
+    private function findProcessorFor(string $protocol): ?BounceProtocolProcessor
+    {
+        foreach ($this->protocolProcessors as $processor) {
+            if ($processor->getProtocol() === $protocol) {
+                return $processor;
+            }
+        }
+
+        return null;
+    }
 }

src/Domain/Messaging/Service/BounceActionResolver.php

@@ -55,7 +55,7 @@ public function handle(string $action, array $context): void
     private function find(string $action): ?BounceActionHandlerInterface
     {
         foreach ($this->handlers as $handler) {
-            if ($handler::supports($action)) {
+            if ($handler->supports($action)) {
                 return $handler;
             }
         }

src/Domain/Messaging/Service/Handler/BlacklistEmailAndDeleteBounceHandler.php

@@ -24,7 +24,7 @@ public function __construct(
         $this->blacklistService = $blacklistService;
     }
 
-    public static function supports(string $action): bool
+    public function supports(string $action): bool
     {
         return $action === 'blacklistemailanddeletebounce';
     }

src/Domain/Messaging/Service/Handler/BlacklistEmailHandler.php

@@ -20,7 +20,7 @@ public function __construct(
         $this->blacklistService = $blacklistService;
     }
 
-    public static function supports(string $action): bool
+    public function supports(string $action): bool
     {
         return $action === 'blacklistemail';
     }

src/Domain/Messaging/Service/Handler/BlacklistUserAndDeleteBounceHandler.php

@@ -24,7 +24,7 @@ public function __construct(
         $this->blacklistService = $blacklistService;
     }
 
-    public static function supports(string $action): bool
+    public function supports(string $action): bool
     {
         return $action === 'blacklistuseranddeletebounce';
     }

src/Domain/Messaging/Service/Handler/BlacklistUserHandler.php

@@ -20,7 +20,7 @@ public function __construct(
         $this->blacklistService = $blacklistService;
     }
 
-    public static function supports(string $action): bool
+    public function supports(string $action): bool
     {
         return $action === 'blacklistuser';
     }

src/Domain/Messaging/Service/Handler/BounceActionHandlerInterface.php

@@ -6,6 +6,6 @@
 
 interface BounceActionHandlerInterface
 {
-    public static function supports(string $action): bool;
+    public function supports(string $action): bool;
     public function handle(array $closureData): void;
 }

src/Domain/Messaging/Service/Handler/DecreaseCountConfirmUserAndDeleteBounceHandler.php

@@ -28,7 +28,7 @@ public function __construct(
         $this->subscriberRepository = $subscriberRepository;
     }
 
-    public static function supports(string $action): bool
+    public function supports(string $action): bool
     {
         return $action === 'decreasecountconfirmuseranddeletebounce';
     }

src/Domain/Messaging/Service/Handler/DeleteBounceHandler.php

@@ -15,7 +15,7 @@ public function __construct(BounceManager $bounceManager)
         $this->bounceManager = $bounceManager;
     }
 
-    public static function supports(string $action): bool
+    public function supports(string $action): bool
     {
         return $action === 'deletebounce';
     }

src/Domain/Messaging/Service/Handler/DeleteUserAndBounceHandler.php

@@ -18,7 +18,7 @@ public function __construct(BounceManager $bounceManager, SubscriberManager $sub
         $this->subscriberManager = $subscriberManager;
     }
 
-    public static function supports(string $action): bool
+    public function supports(string $action): bool
     {
         return $action === 'deleteuserandbounce';
     }