CampaignProcessor

Author: tatevikg1

resources/translations/messages.en.xlf

@@ -287,6 +287,15 @@
                 <target>mbox file path must be provided with --mailbox.</target>
             </trans-unit>
 
+            <trans-unit id="messaging.invalid_email_unconfirm">
+                <source>Invalid email, marking unconfirmed: %email%</source>
+                <target>Invalid email, marking unconfirmed: %email%</target>
+            </trans-unit>
+            <trans-unit id="messaging.failed_to_send">
+                <source>Failed to send to: %email%</source>
+                <target>Failed to send to: %email%</target>
+            </trans-unit>
+
             <!-- Subscription -->
             <trans-unit id="subscription.list_not_found">
                 <source>Subscriber list not found.</source>

src/Domain/Messaging/Service/Processor/CampaignProcessor.php

@@ -18,6 +18,7 @@
 use PhpList\Core\Domain\Subscription\Model\Subscriber;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Contracts\Translation\TranslatorInterface;
 use Throwable;
 
 /**
@@ -33,6 +34,7 @@ class CampaignProcessor
     private UserMessageRepository $userMessageRepository;
     private MaxProcessTimeLimiter $timeLimiter;
     private RequeueHandler $requeueHandler;
+    private TranslatorInterface $translator;
 
     public function __construct(
         RateLimitedCampaignMailer $mailer,
@@ -42,7 +44,8 @@ public function __construct(
         LoggerInterface $logger,
         UserMessageRepository $userMessageRepository,
         MaxProcessTimeLimiter $timeLimiter,
-        RequeueHandler $requeueHandler
+        RequeueHandler $requeueHandler,
+        TranslatorInterface $translator,
     ) {
         $this->mailer = $mailer;
         $this->entityManager = $entityManager;
@@ -52,6 +55,7 @@ public function __construct(
         $this->userMessageRepository = $userMessageRepository;
         $this->timeLimiter = $timeLimiter;
         $this->requeueHandler = $requeueHandler;
+        $this->translator = $translator;
     }
 
     public function process(Message $campaign, ?OutputInterface $output = null): void
@@ -82,7 +86,9 @@ public function process(Message $campaign, ?OutputInterface $output = null): voi
             if (!filter_var($subscriber->getEmail(), FILTER_VALIDATE_EMAIL)) {
                 $this->updateUserMessageStatus($userMessage, UserMessageStatus::InvalidEmailAddress);
                 $this->unconfirmSubscriber($subscriber);
-                $output?->writeln('Invalid email, marking unconfirmed: ' . $subscriber->getEmail());
+                $output?->writeln($this->translator->trans('Invalid email, marking unconfirmed: %email%', [
+                    '%email%' => $subscriber->getEmail(),
+                ]));
                 continue;
             }
 
@@ -98,7 +104,9 @@ public function process(Message $campaign, ?OutputInterface $output = null): voi
                     'subscriber_id' => $subscriber->getId(),
                     'campaign_id' => $campaign->getId(),
                 ]);
-                $output?->writeln('Failed to send to: ' . $subscriber->getEmail());
+                $output?->writeln($this->translator->trans('Failed to send to: %email%', [
+                    '%email%' => $subscriber->getEmail(),
+                ]));
             }
         }
 

tests/Unit/Domain/Messaging/Service/Processor/CampaignProcessorTest.php

@@ -22,6 +22,7 @@
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Mime\Email;
+use Symfony\Component\Translation\Translator;
 
 class CampaignProcessorTest extends TestCase
 {
@@ -32,7 +33,6 @@ class CampaignProcessorTest extends TestCase
     private LoggerInterface|MockObject $logger;
     private OutputInterface|MockObject $output;
     private CampaignProcessor $campaignProcessor;
-    private UserMessageRepository|MockObject $userMessageRepository;
 
     protected function setUp(): void
     {
@@ -42,17 +42,18 @@ protected function setUp(): void
         $this->messagePreparator = $this->createMock(MessageProcessingPreparator::class);
         $this->logger = $this->createMock(LoggerInterface::class);
         $this->output = $this->createMock(OutputInterface::class);
-        $this->userMessageRepository = $this->createMock(UserMessageRepository::class);
+        $userMessageRepository = $this->createMock(UserMessageRepository::class);
 
         $this->campaignProcessor = new CampaignProcessor(
             mailer: $this->mailer,
             entityManager: $this->entityManager,
             subscriberProvider: $this->subscriberProvider,
             messagePreparator: $this->messagePreparator,
             logger: $this->logger,
-            userMessageRepository: $this->userMessageRepository,
+            userMessageRepository: $userMessageRepository,
             timeLimiter: $this->createMock(MaxProcessTimeLimiter::class),
             requeueHandler: $this->createMock(RequeueHandler::class),
+            translator: new Translator('en'),
         );
     }