PhpCodeSniffer

Author: tatevikg1

config/PhpCodeSniffer/ruleset.xml

@@ -15,7 +15,6 @@
     <!-- Classes -->
     <rule ref="Generic.Classes.DuplicateClassName"/>
     <rule ref="Squiz.Classes.ClassFileName"/>
-    <rule ref="Squiz.Classes.DuplicateProperty"/>
     <rule ref="Squiz.Classes.LowercaseClassKeywords"/>
     <rule ref="Squiz.Classes.SelfMemberReference"/>
 
@@ -41,9 +40,6 @@
     <!-- Control structures -->
     <rule ref="PEAR.ControlStructures.ControlSignature"/>
 
-    <!-- Debug -->
-    <rule ref="Generic.Debug.ClosureLinter"/>
-
     <!-- Files -->
     <rule ref="Generic.Files.OneClassPerFile"/>
     <rule ref="Generic.Files.OneInterfacePerFile"/>
@@ -54,7 +50,6 @@
     <rule ref="PEAR.Formatting.MultiLineAssignment"/>
 
     <!-- Functions -->
-    <rule ref="Generic.Functions.CallTimePassByReference"/>
     <rule ref="Squiz.Functions.FunctionDuplicateArgument"/>
     <rule ref="Squiz.Functions.GlobalFunction"/>
 
@@ -66,9 +61,6 @@
     <rule ref="Generic.NamingConventions.ConstructorName"/>
     <rule ref="PEAR.NamingConventions.ValidClassName"/>
 
-    <!-- Objects -->
-    <rule ref="Squiz.Objects.ObjectMemberComma"/>
-
     <!-- Operators -->
     <rule ref="Squiz.Operators.IncrementDecrementUsage"/>
     <rule ref="Squiz.Operators.ValidLogicalOperators"/>
@@ -110,6 +102,5 @@
     <rule ref="Squiz.WhiteSpace.CastSpacing"/>
     <rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing"/>
     <rule ref="Squiz.WhiteSpace.OperatorSpacing"/>
-    <rule ref="Squiz.WhiteSpace.PropertyLabelSpacing"/>
     <rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
 </ruleset>

src/Domain/Common/ClientIpResolver.php

@@ -8,7 +8,12 @@
 
 class ClientIpResolver
 {
-    public function __construct(private readonly RequestStack $requestStack) {}
+    private RequestStack $requestStack;
+
+    public function __construct(RequestStack $requestStack)
+    {
+        $this->requestStack = $requestStack;
+    }
 
     public function resolve(): string
     {

src/Domain/Common/Mail/NativeImapMailReader.php

@@ -21,7 +21,8 @@ public function __construct(string $username, string $password)
 
     public function open(string $mailbox, int $options = 0): Connection
     {
-        $link = @imap_open($mailbox, $this->username, $this->password, $options);
+        $link = imap_open($mailbox, $this->username, $this->password, $options);
+
         if ($link === false) {
             throw new RuntimeException('Cannot open mailbox: '.(imap_last_error() ?: 'unknown error'));
         }

src/Domain/Common/SystemInfoCollector.php

@@ -70,7 +70,7 @@ public function collectAsString(): string
         }
         $lines = [];
         foreach ($pairs as $k => $v) {
-            $lines[] = sprintf("%s = %s", $k, $v);
+            $lines[] = sprintf('%s = %s', $k, $v);
         }
         return "\n" . implode("\n", $lines);
     }

src/Domain/Messaging/Command/ProcessBouncesCommand.php

@@ -25,7 +25,12 @@ protected function configure(): void
     {
         $this
             ->addOption('protocol', null, InputOption::VALUE_REQUIRED, 'Mailbox protocol: pop or mbox', 'pop')
-            ->addOption('purge-unprocessed', null, InputOption::VALUE_NONE, 'Delete/remove unprocessed messages from mailbox')
+            ->addOption(
+                'purge-unprocessed',
+                null,
+                InputOption::VALUE_NONE,
+                'Delete/remove unprocessed messages from mailbox'
+            )
             ->addOption('rules-batch-size', null, InputOption::VALUE_OPTIONAL, 'Advanced rules batch size', '1000')
             ->addOption('test', 't', InputOption::VALUE_NONE, 'Test mode: do not delete from mailbox')
             ->addOption('force', 'f', InputOption::VALUE_NONE, 'Force run: kill other processes if locked');

src/Domain/Messaging/Repository/BounceRegexRepository.php

@@ -21,12 +21,12 @@ public function findOneByRegexHash(string $regexHash): ?BounceRegex
     /** @return BounceRegex[] */
     public function fetchAllOrdered(): array
     {
-        return $this->findBy([],  ['listOrder' => 'ASC']);
+        return $this->findBy([], ['listOrder' => 'ASC']);
     }
 
     /** @return BounceRegex[] */
     public function fetchActiveOrdered(): array
     {
-        return $this->findBy(['active' => true],  ['listOrder' => 'ASC']);
+        return $this->findBy(['active' => true], ['listOrder' => 'ASC']);
     }
 }

src/Domain/Messaging/Service/BounceActionResolver.php

@@ -41,7 +41,9 @@ public function resolve(string $action): BounceActionHandlerInterface
             throw new RuntimeException(sprintf('No handler found for action "%s".', $action));
         }
 
-        return $this->cache[$action] = $handler;
+        $this->cache[$action] = $handler;
+
+        return $handler;
     }
 
     /** Convenience: resolve + execute */

src/Domain/Messaging/Service/Handler/BlacklistEmailAndDeleteBounceHandler.php

@@ -10,11 +10,19 @@
 
 class BlacklistEmailAndDeleteBounceHandler implements BounceActionHandlerInterface
 {
+    private SubscriberHistoryManager $subscriberHistoryManager;
+    private SubscriberManager $subscriberManager;
+    private BounceManager $bounceManager;
+
     public function __construct(
-        private readonly SubscriberHistoryManager $subscriberHistoryManager,
-        private readonly SubscriberManager $subscriberManager,
-        private readonly BounceManager $bounceManager,
-    ) {}
+        SubscriberHistoryManager $subscriberHistoryManager,
+        SubscriberManager $subscriberManager,
+        BounceManager $bounceManager,
+    ) {
+        $this->subscriberHistoryManager = $subscriberHistoryManager;
+        $this->subscriberManager = $subscriberManager;
+        $this->bounceManager = $bounceManager;
+    }
 
     public function supports(string $action): bool
     {

src/Domain/Messaging/Service/Handler/BlacklistEmailHandler.php

@@ -9,10 +9,16 @@
 
 class BlacklistEmailHandler implements BounceActionHandlerInterface
 {
+    private SubscriberHistoryManager $subscriberHistoryManager;
+    private SubscriberManager $subscriberManager;
+
     public function __construct(
-        private readonly SubscriberHistoryManager $subscriberHistoryManager,
-        private readonly SubscriberManager $subscriberManager,
-    ) {}
+        SubscriberHistoryManager $subscriberHistoryManager,
+        SubscriberManager $subscriberManager,
+    ) {
+        $this->subscriberHistoryManager = $subscriberHistoryManager;
+        $this->subscriberManager = $subscriberManager;
+    }
 
     public function supports(string $action): bool
     {

src/Domain/Messaging/Service/Handler/BlacklistUserAndDeleteBounceHandler.php

@@ -10,11 +10,19 @@
 
 class BlacklistUserAndDeleteBounceHandler implements BounceActionHandlerInterface
 {
+    private SubscriberHistoryManager $subscriberHistoryManager;
+    private SubscriberManager $subscriberManager;
+    private BounceManager $bounceManager;
+
     public function __construct(
-        private readonly SubscriberHistoryManager $subscriberHistoryManager,
-        private readonly SubscriberManager $subscriberManager,
-        private readonly BounceManager $bounceManager,
-    ) {}
+        SubscriberHistoryManager $subscriberHistoryManager,
+        SubscriberManager $subscriberManager,
+        BounceManager $bounceManager,
+    ) {
+        $this->subscriberHistoryManager = $subscriberHistoryManager;
+        $this->subscriberManager = $subscriberManager;
+        $this->bounceManager = $bounceManager;
+    }
 
     public function supports(string $action): bool
     {