Check max mail size in send campaign command (#373)

* Add: check max mail size

* MessageDataManager

* Update message status

* Update coderabbit config

* After review 0

* Use HTMLPurifier

* Use precached message data

* After review 1

---------

Co-authored-by: Tatevik <[email protected]>

Author: TatevikGr

.coderabbit.yaml

@@ -73,7 +73,3 @@ reviews:
 #  code_guidelines:
 #    filePatterns:
 #      - ".github/AGENT.md"
-
-checks:
-  docstring_coverage:
-    enabled: false

composer.json

@@ -78,7 +78,8 @@
         "webklex/php-imap": "^6.2",
         "ext-imap": "*",
         "tatevikgr/rss-feed": "dev-main",
-        "ext-pdo": "*"
+        "ext-pdo": "*",
+        "ezyang/htmlpurifier": "^4.19"
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5",

config/PhpCodeSniffer/ruleset.xml

@@ -30,7 +30,9 @@
 
     <!-- Commenting -->
     <rule ref="Generic.Commenting.Fixme"/>
-    <rule ref="Generic.Commenting.Todo"/>
+    <rule ref="Generic.Commenting.Todo">
+        <severity>0</severity>
+    </rule>
     <rule ref="PEAR.Commenting.InlineComment"/>
     <rule ref="Squiz.Commenting.DocCommentAlignment"/>
     <rule ref="Squiz.Commenting.EmptyCatchComment"/>

config/parameters.yml.dist

@@ -87,3 +87,5 @@ parameters:
     env(MAILQUEUE_THROTTLE): '5'
     messaging.max_process_time: '%%env(MESSAGING_MAX_PROCESS_TIME)%%'
     env(MESSAGING_MAX_PROCESS_TIME): '600'
+    messaging.max_mail_size: '%%env(MAX_MAILSIZE)%%'
+    env(MAX_MAILSIZE): '209715200'

config/services.yml

@@ -50,3 +50,21 @@ services:
     lazy: true
     tags:
       - { name: 'doctrine.dbal.schema_filter', connection: 'default' }
+
+  HTMLPurifier_Config:
+    class: HTMLPurifier_Config
+    factory: [ 'HTMLPurifier_Config', 'createDefault' ]
+    calls:
+      - [ set, [ 'Cache.SerializerPath', '%kernel.cache_dir%/htmlpurifier' ] ]
+      - [ set, [ 'HTML.ForbiddenElements', [ 'script', 'style' ] ] ]
+      - [ set, [ 'CSS.Disable', true ] ]
+      - [ set, [ 'URI.DisableJavaScript', true ] ]
+      - [ set, [ 'URI.DisableDataURI', true ] ]
+      - [ set, [ 'HTML.Doctype', 'HTML5' ] ]
+      - [ set, [ 'HTML.Allowed', 'p,br,b,strong,i,em,u,a[href|title],ul,ol,li,blockquote,img[src|alt|title],span,div'] ]
+
+  HTMLPurifier:
+    class: HTMLPurifier
+    arguments:
+      - '@HTMLPurifier_Config'
+

config/services/managers.yml

@@ -110,3 +110,7 @@ services:
   PhpList\Core\Domain\Messaging\Service\Manager\SendProcessManager:
     autowire: true
     autoconfigure: true
+
+  PhpList\Core\Domain\Messaging\Service\Manager\MessageDataManager:
+    autowire: true
+    autoconfigure: true

config/services/messenger.yml

@@ -29,6 +29,11 @@ services:
         autoconfigure: true
         tags: [ 'messenger.message_handler' ]
 
+    PhpList\Core\Domain\Messaging\MessageHandler\CampaignProcessorMessageHandler:
+        autowire: true
+        arguments:
+            $maxMailSize: '%messaging.max_mail_size%'
+
     PhpList\Core\Domain\Subscription\MessageHandler\DynamicTableMessageHandler:
         autowire: true
         autoconfigure: true

config/services/repositories.yml

@@ -140,3 +140,8 @@ services:
     parent: PhpList\Core\Domain\Common\Repository\AbstractRepository
     arguments:
       - PhpList\Core\Domain\Messaging\Model\SendProcess
+
+  PhpList\Core\Domain\Messaging\Repository\MessageDataRepository:
+    parent: PhpList\Core\Domain\Common\Repository\AbstractRepository
+    arguments:
+      - PhpList\Core\Domain\Messaging\Model\MessageData

src/Domain/Analytics/Service/LinkTrackService.php

@@ -9,6 +9,7 @@
 use PhpList\Core\Domain\Analytics\Model\LinkTrack;
 use PhpList\Core\Domain\Analytics\Repository\LinkTrackRepository;
 use PhpList\Core\Domain\Messaging\Model\Message;
+use PhpList\Core\Domain\Messaging\Model\Message\MessageContent;
 
 class LinkTrackService
 {
@@ -38,15 +39,12 @@ public function isExtractAndSaveLinksApplicable(): bool
      * @return LinkTrack[] The saved LinkTrack entities
      * @throws MissingMessageIdException
      */
-    public function extractAndSaveLinks(Message $message, int $userId): array
+    public function extractAndSaveLinks(MessageContent $content, int $userId, ?int $messageId = null): array
     {
         if (!$this->isExtractAndSaveLinksApplicable()) {
             return [];
         }
 
-        $content = $message->getContent();
-        $messageId = $message->getId();
-
         if ($messageId === null) {
             throw new MissingMessageIdException();
         }

src/Domain/Identity/Service/PermissionChecker.php

@@ -70,6 +70,8 @@ private function resolveRelatedEntity(DomainModel $resource, string $relatedClas
         }
 
         if ($resource instanceof Message && $relatedClass === SubscriberList::class) {
+            // todo: check which one is correct
+            // return $resource->getListMessages()->map(fn(ListMessage $lm) => $lm->getList())->toArray();
             return $resource->getListMessages()->map(fn($lm) => $lm->getSubscriberList())->toArray();
         }