Skip to content

Commit 88fc79d

Browse files
committed
save
1 parent 69c82d6 commit 88fc79d

File tree

17 files changed

+27
-69
lines changed

17 files changed

+27
-69
lines changed

src/Domain/Configuration/Service/Manager/ConfigManager.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ public function update(Config $config, string $value): void
4545
throw new ConfigNotEditableException($config->getKey());
4646
}
4747
$config->setValue($value);
48-
49-
$this->configRepository->save($config);
5048
}
5149

5250
public function create(string $key, string $value, bool $editable, ?string $type = null): void
@@ -57,7 +55,7 @@ public function create(string $key, string $value, bool $editable, ?string $type
5755
->setEditable($editable)
5856
->setType($type);
5957

60-
$this->configRepository->save($config);
58+
$this->configRepository->persist($config);
6159
}
6260

6361
public function delete(Config $config): void

src/Domain/Identity/Service/AdminAttributeDefinitionManager.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function create(AdminAttributeDefinitionDto $attributeDefinitionDto): Adm
4545
->setDefaultValue($attributeDefinitionDto->defaultValue)
4646
->setTableName($attributeDefinitionDto->tableName);
4747

48-
$this->definitionRepository->save($attributeDefinition);
48+
$this->definitionRepository->persist($attributeDefinition);
4949

5050
return $attributeDefinition;
5151
}
@@ -68,8 +68,6 @@ public function update(
6868
->setDefaultValue($attributeDefinitionDto->defaultValue)
6969
->setTableName($attributeDefinitionDto->tableName);
7070

71-
$this->definitionRepository->save($attributeDefinition);
72-
7371
return $attributeDefinition;
7472
}
7573

src/Domain/Identity/Service/AdminAttributeManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public function createOrUpdate(
3939
}
4040

4141
$adminAttribute->setValue($value);
42-
$this->attributeRepository->save($adminAttribute);
42+
$this->attributeRepository->persist($adminAttribute);
4343

4444
return $adminAttribute;
4545
}

src/Domain/Identity/Service/PasswordManager.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public function generatePasswordResetToken(string $email): string
6565
$expiryDate = new DateTime(self::TOKEN_EXPIRY);
6666
$passwordRequest = new AdminPasswordRequest(date: $expiryDate, admin: $administrator, keyValue: $token);
6767

68-
$this->passwordRequestRepository->save($passwordRequest);
68+
$this->passwordRequestRepository->persist($passwordRequest);
6969

7070
$message = new PasswordResetMessage(email: $email, token: $token);
7171
$this->messageBus->dispatch($message);
@@ -113,7 +113,7 @@ public function updatePasswordWithToken(string $token, string $newPassword): boo
113113

114114
$passwordHash = $this->hashGenerator->createPasswordHash($newPassword);
115115
$administrator->setPasswordHash($passwordHash);
116-
$this->administratorRepository->save($administrator);
116+
$this->administratorRepository->persist($administrator);
117117

118118
$passwordRequest = $this->passwordRequestRepository->findOneByToken($token);
119119
$this->passwordRequestRepository->remove($passwordRequest);

src/Domain/Identity/Service/SessionManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public function createSession(string $loginName, string $password): Administrato
5151
$token->setAdministrator($administrator);
5252
$token->generateExpiry();
5353
$token->generateKey();
54-
$this->tokenRepository->save($token);
54+
$this->tokenRepository->persist($token);
5555

5656
return $token;
5757
}

src/Domain/Messaging/Service/Manager/BounceRegexManager.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ public function createOrUpdateFromPattern(
4646
->setComment($comment ?? $existing->getComment())
4747
->setStatus($status ?? $existing->getStatus());
4848

49-
$this->bounceRegexRepository->save($existing);
50-
5149
return $existing;
5250
}
5351

@@ -62,7 +60,7 @@ public function createOrUpdateFromPattern(
6260
count: 0
6361
);
6462

65-
$this->bounceRegexRepository->save($bounceRegex);
63+
$this->bounceRegexRepository->persist($bounceRegex);
6664

6765
return $bounceRegex;
6866
}

src/Domain/Messaging/Service/Manager/MessageManager.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public function createMessage(MessageDtoInterface $createMessageDto, Administrat
2626
{
2727
$context = new MessageContext($authUser);
2828
$message = $this->messageBuilder->build($createMessageDto, $context);
29-
$this->messageRepository->save($message);
29+
$this->messageRepository->persist($message);
3030

3131
return $message;
3232
}
@@ -37,16 +37,12 @@ public function updateMessage(
3737
Administrator $authUser
3838
): Message {
3939
$context = new MessageContext($authUser, $message);
40-
$message = $this->messageBuilder->build($updateMessageDto, $context);
41-
$this->messageRepository->save($message);
42-
43-
return $message;
40+
return $this->messageBuilder->build($updateMessageDto, $context);
4441
}
4542

4643
public function updateStatus(Message $message, Message\MessageStatus $status): Message
4744
{
4845
$message->getMetadata()->setStatus($status);
49-
$this->messageRepository->save($message);
5046

5147
return $message;
5248
}

src/Domain/Subscription/Service/Manager/AttributeDefinitionManager.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function create(AttributeDefinitionDto $attributeDefinitionDto): Subscrib
4646
->setDefaultValue($attributeDefinitionDto->defaultValue)
4747
->setTableName($attributeDefinitionDto->tableName);
4848

49-
$this->definitionRepository->save($attributeDefinition);
49+
$this->definitionRepository->persist($attributeDefinition);
5050

5151
return $attributeDefinition;
5252
}
@@ -72,8 +72,6 @@ public function update(
7272
->setDefaultValue($attributeDefinitionDto->defaultValue)
7373
->setTableName($attributeDefinitionDto->tableName);
7474

75-
$this->definitionRepository->save($attributeDefinition);
76-
7775
return $attributeDefinition;
7876
}
7977

src/Domain/Subscription/Service/Manager/SubscriberManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public function createSubscriber(CreateSubscriberDto $subscriberDto): Subscriber
4848
$subscriber->setHtmlEmail((bool)$subscriberDto->htmlEmail);
4949
$subscriber->setDisabled(false);
5050

51-
$this->subscriberRepository->save($subscriber);
51+
$this->subscriberRepository->persist($subscriber);
5252

5353
return $subscriber;
5454
}

tests/Unit/Domain/Configuration/Service/Manager/ConfigManagerTest.php

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace PhpList\Core\Tests\Unit\Domain\Configuration\Service\Manager;
66

7+
use PhpList\Core\Domain\Configuration\Exception\ConfigNotEditableException;
78
use PhpList\Core\Domain\Configuration\Model\Config;
89
use PhpList\Core\Domain\Configuration\Repository\ConfigRepository;
910
use PhpList\Core\Domain\Configuration\Service\Manager\ConfigManager;
@@ -61,30 +62,13 @@ public function testGetAllReturnsAllConfigsFromRepository(): void
6162
$this->assertSame('value2', $result[1]->getValue());
6263
}
6364

64-
public function testUpdateSavesConfigToRepository(): void
65-
{
66-
$configRepository = $this->createMock(ConfigRepository::class);
67-
$manager = new ConfigManager($configRepository);
68-
69-
$config = new Config();
70-
$config->setKey('test_item');
71-
$config->setValue('test_value');
72-
$config->setEditable(true);
73-
74-
$configRepository->expects($this->once())
75-
->method('save')
76-
->with($config);
77-
78-
$manager->update($config, 'new_value');
79-
}
80-
8165
public function testCreateSavesNewConfigToRepository(): void
8266
{
8367
$configRepository = $this->createMock(ConfigRepository::class);
8468
$manager = new ConfigManager($configRepository);
8569

8670
$configRepository->expects($this->once())
87-
->method('save')
71+
->method('persist')
8872
->with($this->callback(function (Config $config) {
8973
return $config->getKey() === 'test_key' &&
9074
$config->getValue() === 'test_value' &&
@@ -119,10 +103,7 @@ public function testUpdateThrowsExceptionWhenConfigIsNotEditable(): void
119103
$config->setValue('test_value');
120104
$config->setEditable(false);
121105

122-
$configRepository->expects($this->never())
123-
->method('save');
124-
125-
$this->expectException(\PhpList\Core\Domain\Configuration\Exception\ConfigNotEditableException::class);
106+
$this->expectException(ConfigNotEditableException::class);
126107
$this->expectExceptionMessage('Configuration item "test_item" is not editable.');
127108

128109
$manager->update($config, 'new_value');

0 commit comments

Comments
 (0)