Skip to content

Commit af63048

Browse files
TatevikGrtatevikg1
andauthored
Fix import (#349)
* Add sendConfirmation * Temp disable graylog --------- Co-authored-by: Tatevik <[email protected]>
1 parent ab505c7 commit af63048

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

config/config_prod.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ imports:
44
monolog:
55
handlers:
66
# Primary handler for production is Graylog
7-
graylog:
8-
type: gelf
9-
publisher:
10-
hostname: '%graylog_host%'
11-
port: '%graylog_port%'
12-
level: error
7+
# graylog:
8+
# type: gelf
9+
# publisher:
10+
# hostname: '%graylog_host%'
11+
# port: '%graylog_port%'
12+
# level: error
1313
# Local file logging as backup
1414
main:
1515
type: fingers_crossed

src/Domain/Subscription/Model/Dto/ImportSubscriberDto.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ class ImportSubscriberDto
2828
/** @var array<string, string|int|bool|null> */
2929
public array $extraAttributes = [];
3030

31+
public bool $sendConfirmation;
32+
3133
public function __construct(
3234
string $email,
3335
bool $confirmed,
@@ -39,6 +41,7 @@ public function __construct(
3941
) {
4042
$this->email = $email;
4143
$this->confirmed = $confirmed;
44+
$this->sendConfirmation = !$confirmed;
4245
$this->blacklisted = $blacklisted;
4346
$this->htmlEmail = $htmlEmail;
4447
$this->disabled = $disabled;

src/Domain/Subscription/Service/Manager/SubscriberManager.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,11 @@ public function createFromImport(ImportSubscriberDto $subscriberDto): Subscriber
118118
$subscriber->setBlacklisted($subscriberDto->blacklisted);
119119
$subscriber->setHtmlEmail($subscriberDto->htmlEmail);
120120
$subscriber->setDisabled($subscriberDto->disabled);
121-
$subscriber->setExtraData($subscriberDto->extraData);
121+
$subscriber->setExtraData($subscriberDto->extraData ?? '');
122122

123123
$this->entityManager->persist($subscriber);
124124

125-
if (!$subscriberDto->confirmed) {
125+
if ($subscriberDto->sendConfirmation) {
126126
$this->sendConfirmationEmail($subscriber);
127127
}
128128

src/Domain/Subscription/Service/SubscriberCsvImporter.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ private function processRow(
143143
return;
144144
} else {
145145
$dto->email = 'invalid_' . $dto->email;
146+
$dto->sendConfirmation = false;
146147
}
147148
}
148149
$subscriber = $this->subscriberRepository->findOneByEmail($dto->email);

0 commit comments

Comments
 (0)