AttributeDefinitionManager

Author: tatevikg1

resources/translations/messages.en.xlf

@@ -395,6 +395,15 @@
                 <source>Subscription not found for this subscriber and list.</source>
                 <target>Subscription not found for this subscriber and list.</target>
             </trans-unit>
+            <trans-unit id="subscription.attribute_definition_exists">
+                <source>Attribute definition already exists</source>
+                <target>Attribute definition already exists</target>
+            </trans-unit>
+            <trans-unit id="subscription.attribute_definition_name_exists">
+                <source>Another attribute with this name already exists.</source>
+                <target>Another attribute with this name already exists.</target>
+            </trans-unit>
+
         </body>
     </file>
 </xliff>

src/Domain/Subscription/Service/Manager/AttributeDefinitionManager.php

@@ -9,25 +9,32 @@
 use PhpList\Core\Domain\Subscription\Model\SubscriberAttributeDefinition;
 use PhpList\Core\Domain\Subscription\Repository\SubscriberAttributeDefinitionRepository;
 use PhpList\Core\Domain\Subscription\Validator\AttributeTypeValidator;
+use Symfony\Contracts\Translation\TranslatorInterface;
 
 class AttributeDefinitionManager
 {
     private SubscriberAttributeDefinitionRepository $definitionRepository;
     private AttributeTypeValidator $attributeTypeValidator;
+    private TranslatorInterface $translator;
 
     public function __construct(
         SubscriberAttributeDefinitionRepository $definitionRepository,
-        AttributeTypeValidator $attributeTypeValidator
+        AttributeTypeValidator $attributeTypeValidator,
+        TranslatorInterface $translator,
     ) {
         $this->definitionRepository = $definitionRepository;
         $this->attributeTypeValidator = $attributeTypeValidator;
+        $this->translator = $translator;
     }
 
     public function create(AttributeDefinitionDto $attributeDefinitionDto): SubscriberAttributeDefinition
     {
         $existingAttribute = $this->definitionRepository->findOneByName($attributeDefinitionDto->name);
         if ($existingAttribute) {
-            throw new AttributeDefinitionCreationException('Attribute definition already exists', 409);
+            throw new AttributeDefinitionCreationException(
+                message: $this->translator->trans('Attribute definition already exists'),
+                statusCode: 409
+            );
         }
         $this->attributeTypeValidator->validate($attributeDefinitionDto->type);
 
@@ -50,7 +57,10 @@ public function update(
     ): SubscriberAttributeDefinition {
         $existingAttribute = $this->definitionRepository->findOneByName($attributeDefinitionDto->name);
         if ($existingAttribute && $existingAttribute->getId() !== $attributeDefinition->getId()) {
-            throw new AttributeDefinitionCreationException('Another attribute with this name already exists.', 409);
+            throw new AttributeDefinitionCreationException(
+                message: $this->translator->trans('Another attribute with this name already exists.'),
+                statusCode: 409
+            );
         }
         $this->attributeTypeValidator->validate($attributeDefinitionDto->type);
 

tests/Unit/Domain/Subscription/Service/Manager/AttributeDefinitionManagerTest.php

@@ -11,14 +11,19 @@
 use PhpList\Core\Domain\Subscription\Service\Manager\AttributeDefinitionManager;
 use PhpList\Core\Domain\Subscription\Validator\AttributeTypeValidator;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Translation\Translator;
 
 class AttributeDefinitionManagerTest extends TestCase
 {
     public function testCreateAttributeDefinition(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
         $validator = $this->createMock(AttributeTypeValidator::class);
-        $manager = new AttributeDefinitionManager($repository, $validator);
+        $manager = new AttributeDefinitionManager(
+            definitionRepository: $repository,
+            attributeTypeValidator: $validator,
+            translator: new Translator('en')
+        );
 
         $dto = new AttributeDefinitionDto(
             name: 'Country',
@@ -51,7 +56,11 @@ public function testCreateThrowsWhenAttributeAlreadyExists(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
         $validator = $this->createMock(AttributeTypeValidator::class);
-        $manager = new AttributeDefinitionManager($repository, $validator);
+        $manager = new AttributeDefinitionManager(
+            definitionRepository: $repository,
+            attributeTypeValidator: $validator,
+            translator: new Translator('en'),
+        );
 
         $dto = new AttributeDefinitionDto(
             name: 'Country',
@@ -78,7 +87,11 @@ public function testUpdateAttributeDefinition(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
         $validator = $this->createMock(AttributeTypeValidator::class);
-        $manager = new AttributeDefinitionManager($repository, $validator);
+        $manager = new AttributeDefinitionManager(
+            definitionRepository: $repository,
+            attributeTypeValidator: $validator,
+            translator: new Translator('en'),
+        );
 
         $attribute = new SubscriberAttributeDefinition();
         $attribute->setName('Old');
@@ -113,7 +126,11 @@ public function testUpdateThrowsWhenAnotherAttributeWithSameNameExists(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
         $validator = $this->createMock(AttributeTypeValidator::class);
-        $manager = new AttributeDefinitionManager($repository, $validator);
+        $manager = new AttributeDefinitionManager(
+            definitionRepository: $repository,
+            attributeTypeValidator: $validator,
+            translator: new Translator('en'),
+        );
 
         $dto = new AttributeDefinitionDto(
             name: 'Existing',
@@ -144,7 +161,11 @@ public function testDeleteAttributeDefinition(): void
     {
         $repository = $this->createMock(SubscriberAttributeDefinitionRepository::class);
         $validator = $this->createMock(AttributeTypeValidator::class);
-        $manager = new AttributeDefinitionManager($repository, $validator);
+        $manager = new AttributeDefinitionManager(
+            definitionRepository: $repository,
+            attributeTypeValidator: $validator,
+            translator: new Translator('en'),
+        );
 
         $attribute = new SubscriberAttributeDefinition();