Skip to content

Commit cad6ebb

Browse files
committed
After review 1
1 parent 525741a commit cad6ebb

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

src/Domain/Identity/Service/PermissionChecker.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ private function resolveRelatedEntity(DomainModel $resource, string $relatedClas
7070
}
7171

7272
if ($resource instanceof Message && $relatedClass === SubscriberList::class) {
73+
// todo: check which one is correct
74+
// return $resource->getListMessages()->map(fn(ListMessage $lm) => $lm->getList())->toArray();
7375
return $resource->getListMessages()->map(fn($lm) => $lm->getSubscriberList())->toArray();
7476
}
7577

src/Domain/Messaging/Service/MessagePrecacheService.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,9 @@ public function getOrCacheBaseMessageContent(Message $campaign): Message\Message
2222
{
2323
$cacheKey = sprintf('messaging.message.base.%d', $campaign->getId());
2424

25-
if ($this->cache->has($cacheKey) && $this->getFromCache($cacheKey)) {
26-
return $this->getFromCache($cacheKey);
25+
$cached = $this->getFromCache($cacheKey);
26+
if ($cached !== null) {
27+
return $cached;
2728
}
2829

2930
$content = $campaign->getContent();

tests/Unit/Domain/Messaging/Service/MessageProcessingPreparatorTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ public function testProcessMessageLinksWithLinksExtracted(): void
193193
$this->linkTrackService->method('isExtractAndSaveLinksApplicable')->willReturn(true);
194194
$this->linkTrackService
195195
->method('extractAndSaveLinks')
196-
->with($content, 123)
196+
->with($content, 123, 1)
197197
->willReturn($savedLinks);
198198

199199
$htmlContent = '<a href="https://example.com">Link 1</a> <a href="https://example.org">Link 2</a>';

0 commit comments

Comments
 (0)