SubscriberAttributeManager

Author: tatevikg1

resources/translations/messages.en.xlf

@@ -408,6 +408,10 @@
                 <source>Subscribe page not found</source>
                 <target>Subscribe page not found</target>
             </trans-unit>
+            <trans-unit id="subscription.value_is_required">
+                <source>Value is required</source>
+                <target>Value is required</target>
+            </trans-unit>
 
         </body>
     </file>

src/Domain/Subscription/Exception/SubscriberAttributeCreationException.php

@@ -10,7 +10,7 @@ class SubscriberAttributeCreationException extends RuntimeException
 {
     private int $statusCode;
 
-    public function __construct(string $message, int $statusCode)
+    public function __construct(string $message, ?int $statusCode = 400)
     {
         parent::__construct($message);
         $this->statusCode = $statusCode;

src/Domain/Subscription/Service/Manager/SubscriberAttributeManager.php

@@ -10,18 +10,22 @@
 use PhpList\Core\Domain\Subscription\Model\SubscriberAttributeDefinition;
 use PhpList\Core\Domain\Subscription\Model\SubscriberAttributeValue;
 use PhpList\Core\Domain\Subscription\Repository\SubscriberAttributeValueRepository;
+use Symfony\Contracts\Translation\TranslatorInterface;
 
 class SubscriberAttributeManager
 {
     private SubscriberAttributeValueRepository $attributeRepository;
     private EntityManagerInterface $entityManager;
+    private TranslatorInterface $translator;
 
     public function __construct(
         SubscriberAttributeValueRepository $attributeRepository,
         EntityManagerInterface $entityManager,
+        TranslatorInterface $translator,
     ) {
         $this->attributeRepository = $attributeRepository;
         $this->entityManager = $entityManager;
+        $this->translator = $translator;
     }
 
     public function createOrUpdate(
@@ -38,7 +42,7 @@ public function createOrUpdate(
 
         $value = $value ?? $definition->getDefaultValue();
         if ($value === null) {
-            throw new SubscriberAttributeCreationException('Value is required', 400);
+            throw new SubscriberAttributeCreationException($this->translator->trans('Value is required'));
         }
 
         $subscriberAttribute->setValue($value);

tests/Unit/Domain/Subscription/Service/Manager/SubscriberAttributeManagerTest.php

@@ -12,6 +12,7 @@
 use PhpList\Core\Domain\Subscription\Repository\SubscriberAttributeValueRepository;
 use PhpList\Core\Domain\Subscription\Service\Manager\SubscriberAttributeManager;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Translation\Translator;
 
 class SubscriberAttributeManagerTest extends TestCase
 {
@@ -34,7 +35,7 @@ public function testCreateNewSubscriberAttribute(): void
                 return $attr->getValue() === 'US';
             }));
 
-        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager);
+        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager, new Translator('en'));
         $attribute = $manager->createOrUpdate($subscriber, $definition, 'US');
 
         self::assertInstanceOf(SubscriberAttributeValue::class, $attribute);
@@ -60,7 +61,7 @@ public function testUpdateExistingSubscriberAttribute(): void
             ->method('persist')
             ->with($existing);
 
-        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager);
+        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager, new Translator('en'));
         $result = $manager->createOrUpdate($subscriber, $definition, 'Updated');
 
         self::assertSame('Updated', $result->getValue());
@@ -76,7 +77,7 @@ public function testCreateFailsWhenValueAndDefaultAreNull(): void
 
         $subscriberAttrRepo->method('findOneBySubscriberAndAttribute')->willReturn(null);
 
-        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager);
+        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager, new Translator('en'));
 
         $this->expectException(SubscriberAttributeCreationException::class);
         $this->expectExceptionMessage('Value is required');
@@ -95,7 +96,7 @@ public function testGetSubscriberAttribute(): void
             ->with(5, 10)
             ->willReturn($expected);
 
-        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager);
+        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager, new Translator('en'));
         $result = $manager->getSubscriberAttribute(5, 10);
 
         self::assertSame($expected, $result);
@@ -111,7 +112,7 @@ public function testDeleteSubscriberAttribute(): void
             ->method('remove')
             ->with($attribute);
 
-        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager);
+        $manager = new SubscriberAttributeManager($subscriberAttrRepo, $entityManager, new Translator('en'));
         $manager->delete($attribute);
 
         self::assertTrue(true);