After review 4

Author: tatevikg1

src/Domain/Subscription/Repository/DynamicListAttrRepository.php

@@ -151,7 +151,7 @@ public function fetchSingleOptionName(string $listTable, int $id): ?string
         return $val === false ? null : (string) $val;
     }
 
-    public function existsByName(string $listTable, DynamicListAttrDto $dto): bool
+    public function isNameTakenByOtherRecord(string $listTable, DynamicListAttrDto $dto): bool
     {
         if (!preg_match('/^[A-Za-z0-9_]+$/', $listTable)) {
             throw new InvalidArgumentException('Invalid list table');

src/Domain/Subscription/Service/Manager/AttributeDefinitionManager.php

@@ -85,7 +85,7 @@ public function update(
             ->setRequired($attributeDefinitionDto->required)
             ->setDefaultValue($attributeDefinitionDto->defaultValue);
 
-        if ($attributeDefinitionDto->type->isMultiValued()) {
+        if ($attributeDefinitionDto->type && $attributeDefinitionDto->type->isMultiValued()) {
             $tableName = $attributeDefinition->getTableName() ?? $this->dynamicTablesManager
                 ->resolveTableName(name: $attributeDefinitionDto->name, type: $attributeDefinitionDto->type);
             $this->dynamicTablesManager->createOptionsTableIfNotExists($tableName);

src/Domain/Subscription/Service/Manager/DynamicListAttrManager.php

@@ -241,7 +241,7 @@ private function updateRowsById(array $incomingById, array $currentById, string
                 $cur = $currentById[$dto->id];
                 $updates = [];
                 if ($cur->name !== $dto->name) {
-                    $nameExists = $this->dynamicListAttrRepository->existsByName($listTable, $dto);
+                    $nameExists = $this->dynamicListAttrRepository->isNameTakenByOtherRecord($listTable, $dto);
                     if ($nameExists) {
                         throw new RuntimeException('Option name ' . $dto->name . ' already exists.');
                     }

tests/Integration/Domain/Subscription/Service/DynamicListAttrManagerFunctionalTest.php

@@ -44,7 +44,6 @@ protected function setUp(): void
             dynamicListTablePrefix: 'listattr_'
         );
 
-        $subscriberAttributeValueRepo = null;
         $subscriberAttributeValueRepo = self::getContainer()->get(SubscriberAttributeValueRepository::class);
 
         // Get tables manager from container for creating/ensuring dynamic tables

tests/Support/DBAL/FakeDriverException.php

@@ -15,7 +15,7 @@
  */
 class FakeDriverException extends Exception implements DriverException
 {
-    private string|null $sqlState;
+    private ?string $sqlState;
 
     public function __construct(
         string $message = '',