consider an installer superuser and handle PHP8 better (#777)

* consider an installer superuser and handle PHP8 better

* bring home.php from theme into the application

* treat installer as superuser

* update bootlist theme to latest

* remove step that's failing

* mark menu as wip, as it's failing

* update the behat screenshots on failure

* run more steps on failure

* work from correct folder

* remove wip, it's not the cause

* debug

* add /

* mark feature as javascript

* use a working location for screenshots

* set the output dir

* use different extension

* try debugging on self-hosted runner

* don't use FailAid extension

* roll back self-hosted

* add script to get composer 2

* why are the screenshots not there

* check find result works

* try goutte

* check FF

* use chrome and keep behat output as artifact

Author: michield

.github/workflows/main.yml

@@ -1,7 +1,7 @@
 
 name: CI
 
-on: [push, pull_request]
+on: [pull_request]
 
 jobs:
   test:
@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false     
       matrix:   
-        php-version: ['7.2', '7.3', '7.4']
+        php-version: ['7.2', '7.2', '7.3', '7.4']
         experimental: [false]
         include:
         - php-version: '8.0'
@@ -31,6 +31,7 @@ jobs:
         run: |
           cd $GITHUB_WORKSPACE
           sudo apt update
+          sudo apt install rsync
 
       - name: Cache Composer dependencies
         uses: actions/cache@v2
@@ -57,20 +58,21 @@ jobs:
           sudo mysqladmin -proot create phplistdb
           sudo mysql -proot -e 'grant all on phplistdb.* to phplist@"%" identified by "phplist"'
 
-      # - name: Set bootlist theme
-      #   run: |
-      #     cd $GITHUB_WORKSPACE/public_html/lists/admin/ui/
-      #     wget https://github.com/phpList/phplist-ui-bootlist/archive/master.tar.gz
-      #     tar -xzf master.tar.gz
-      #     mv phplist-ui-bootlist-master phplist-ui-bootlist
-      #     rm master.tar.gz
+      - name: Set bootlist theme
+        run: |
+          cd $GITHUB_WORKSPACE/public_html/lists/admin/ui/
+          wget https://github.com/phpList/phplist-ui-bootlist/archive/master.tar.gz
+          tar -xzf master.tar.gz
+          mv phplist-ui-bootlist-master phplist-ui-bootlist
+          rm master.tar.gz
 
       - name: Start Test Server
         run: |
           cd $GITHUB_WORKSPACE
           cp -fv tests/default.behat.yml tests/behat.yml
           cp -fv tests/ci/config.php public_html/lists/config/config.php
           mkdir -p output/screenshots
+          touch output/screenshots/README.md
           mkdir -p build/mails
           ./bin/start-selenium > output/selenium.log 2>&1 &
           sleep 5
@@ -81,26 +83,36 @@ jobs:
         with:
           path: ./public_html
 
-      # - name: Report Versions
-      #   run: |
-      #     google-chrome --version
-      #     php -v
-      #     chromedriver -v
-      #     geckodriver -V
-      #     which geckodriver
-      #     which chromedriver
-      #     firefox -v
-      #     vendor/bin/behat -V
+      - name: Report Versions
+        run: |
+          google-chrome --version
+          php -v
+          chromedriver -v
+          geckodriver -V
+          which geckodriver
+          which chromedriver
+          firefox -v
+          vendor/bin/behat -V
 
       - name: Run BDD Tests
         run: |
           cd $GITHUB_WORKSPACE/tests
-          ../vendor/bin/behat -n -fprogress -p chrome --strict --stop-on-failure --tags=@initialise
-          ../vendor/bin/behat -n -fprogress -p chrome --strict --stop-on-failure --tags="~@initialise && ~@wip"
+          ../vendor/bin/behat -p chrome --stop-on-failure --tags=@initialise
+          ../vendor/bin/behat -p chrome --tags="~@initialise && ~@wip"
+
+      - name: Upload the screenshots
+        if: always()
+        uses: actions/upload-artifact@v2
+        with:
+          path: "output"
+          name: "behat output"
+          retention-days: 3
 
       - name: Display output
         run: |
           cd $GITHUB_WORKSPACE
-          cat output/selenium.log
+        #  find . -type f
+        #  cat output/selenium.log
+        if: ${{ failure() }}
 
 

bin/update-composer.sh

@@ -0,0 +1,17 @@
+#!/bin/sh
+
+EXPECTED_CHECKSUM="$(php -r 'copy("https://composer.github.io/installer.sig", "php://stdout");')"
+php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
+ACTUAL_CHECKSUM="$(php -r "echo hash_file('sha384', 'composer-setup.php');")"
+
+if [ "$EXPECTED_CHECKSUM" != "$ACTUAL_CHECKSUM" ]
+then
+    >&2 echo 'ERROR: Invalid installer checksum'
+    rm composer-setup.php
+    exit 1
+fi
+echo installing composer
+php composer-setup.php --quiet
+RESULT=$?
+rm composer-setup.php
+exit $RESULT