only alert when the new version is newer

michield · michield · commit c3c7d26e2268 · 2020-12-12T11:45:11.000Z
diff --git a/public_html/lists/admin/updateLib.php b/public_html/lists/admin/updateLib.php
@@ -33,7 +33,7 @@ function checkForUpdate()
     }
     $versionString = isset($serverResponse['versionstring']) ? $serverResponse['versionstring'] : '';
 
-    if ($version !== '' && $version !== VERSION && version_compare(VERSION, $version) && $enabledNotification) {
+    if ($version !== '' && $version !== VERSION && version_compare(VERSION, $version) < 0 && $enabledNotification) {
         $updateMessage = s('A new version of phpList is available: %s',htmlentities($versionString));
     } else {
         $updateMessage = '';

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ function checkForUpdate()`
`33`	`33`	`}`
`34`	`34`	`$versionString = isset($serverResponse['versionstring']) ? $serverResponse['versionstring'] : '';`
`35`	`35`
`36`		`- if ($version !== '' && $version !== VERSION && version_compare(VERSION, $version) && $enabledNotification) {`
	`36`	`+ if ($version !== '' && $version !== VERSION && version_compare(VERSION, $version) < 0 && $enabledNotification) {`
`37`	`37`	`$updateMessage = s('A new version of phpList is available: %s',htmlentities($versionString));`
`38`	`38`	`} else {`
`39`	`39`	`$updateMessage = '';`