Own namespace for attributes

Author: tatevikg1

src/Subscription/Controller/SubscriberAttributeDefinitionController.php

@@ -20,7 +20,7 @@
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Routing\Attribute\Route;
 
-#[Route('/subscribers/attributes', name: 'subscriber_attribute_definition_')]
+#[Route('/attributes', name: 'subscriber_attribute_definition_')]
 class SubscriberAttributeDefinitionController extends BaseController
 {
     private AttributeDefinitionManager $definitionManager;
@@ -43,7 +43,7 @@ public function __construct(
 
     #[Route('', name: 'create', methods: ['POST'])]
     #[OA\Post(
-        path: '/api/v2/subscribers/attributes',
+        path: '/api/v2/attributes',
         description: '🚧 **Status: Beta** – This method is under development. Avoid using in production. ' .
             'Returns created subscriber attribute definition.',
         summary: 'Create a subscriber attribute definition.',
@@ -96,7 +96,7 @@ public function create(Request $request): JsonResponse
 
     #[Route('/{definitionId}', name: 'update', requirements: ['definitionId' => '\d+'], methods: ['PUT'])]
     #[OA\Put(
-        path: '/api/v2/subscribers/attributes/{definitionId}',
+        path: '/api/v2/attributes/{definitionId}',
         description: '🚧 **Status: Beta** – This method is under development. Avoid using in production. ' .
             'Returns updated subscriber attribute definition.',
         summary: 'Update a subscriber attribute definition.',
@@ -164,7 +164,7 @@ public function update(
 
     #[Route('/{definitionId}', name: 'delete', requirements: ['definitionId' => '\d+'], methods: ['DELETE'])]
     #[OA\Delete(
-        path: '/api/v2/subscribers/attributes/{definitionId}',
+        path: '/api/v2/attributes/{definitionId}',
         description: '🚧 **Status: Beta** – This method is under development. Avoid using in production. ' .
             'Deletes a single subscriber attribute definition.',
         summary: 'Deletes an attribute definition.',
@@ -219,7 +219,7 @@ public function delete(
 
     #[Route('', name: 'get_list', methods: ['GET'])]
     #[OA\Get(
-        path: '/api/v2/subscribers/attributes',
+        path: '/api/v2/attributes',
         description: '🚧 **Status: Beta** – This method is under development. Avoid using in production. ' .
             'Returns a JSON list of all subscriber attribute definitions.',
         summary: 'Gets a list of all subscriber attribute definitions.',
@@ -286,7 +286,7 @@ public function getPaginated(Request $request): JsonResponse
 
     #[Route('/{definitionId}', name: 'get_one', requirements: ['definitionId' => '\d+'], methods: ['GET'])]
     #[OA\Get(
-        path: '/api/v2/subscribers/attributes/{definitionId}',
+        path: '/api/v2/attributes/{definitionId}',
         description: '🚧 **Status: Beta** – This method is under development. Avoid using in production. ' .
             'Returns a single attribute with specified ID.',
         summary: 'Gets attribute with specified ID.',

tests/Integration/Subscription/Controller/SubscriberAttributeDefinitionControllerTest.php

@@ -23,21 +23,21 @@ public function testControllerIsAvailableViaContainer()
 
     public function testGetAttributesWithoutSessionKeyReturnsForbidden()
     {
-        self::getClient()->request('GET', '/api/v2/subscribers/attributes');
+        self::getClient()->request('GET', '/api/v2/attributes');
         $this->assertHttpForbidden();
     }
 
     public function testGetAttributesWithSessionKeyReturnsOk()
     {
         $this->loadFixtures([AdministratorFixture::class, AdministratorTokenFixture::class]);
-        $this->authenticatedJsonRequest('GET', '/api/v2/subscribers/attributes');
+        $this->authenticatedJsonRequest('GET', '/api/v2/attributes');
         $this->assertHttpOkay();
     }
 
     public function testGetAttributeWithInvalidIdReturnsNotFound()
     {
         $this->loadFixtures([AdministratorFixture::class, AdministratorTokenFixture::class]);
-        $this->authenticatedJsonRequest('GET', '/api/v2/subscribers/attributes/999');
+        $this->authenticatedJsonRequest('GET', '/api/v2/attributes/999');
         $this->assertHttpNotFound();
     }
 
@@ -53,7 +53,7 @@ public function testCreateAttributeDefinition()
             'required' => true,
         ]);
 
-        $this->authenticatedJsonRequest('POST', '/api/v2/subscribers/attributes', [], [], [], $payload);
+        $this->authenticatedJsonRequest('POST', '/api/v2/attributes', [], [], [], $payload);
 
         $this->assertHttpCreated();
 
@@ -77,7 +77,7 @@ public function testUpdateAttributeDefinition()
             'required' => false,
         ]);
 
-        $this->authenticatedJsonRequest('PUT', '/api/v2/subscribers/attributes/1', [], [], [], $payload);
+        $this->authenticatedJsonRequest('PUT', '/api/v2/attributes/1', [], [], [], $payload);
         $this->assertHttpOkay();
         $response = $this->getDecodedJsonResponseContent();
         self::assertSame('Updated Country', $response['name']);
@@ -91,7 +91,7 @@ public function testDeleteAttributeDefinition()
             SubscriberAttributeDefinitionFixture::class,
         ]);
 
-        $this->authenticatedJsonRequest('DELETE', '/api/v2/subscribers/attributes/1');
+        $this->authenticatedJsonRequest('DELETE', '/api/v2/attributes/1');
         $this->assertHttpNoContent();
 
         $repo = self::getContainer()->get(SubscriberAttributeDefinitionRepository::class);
@@ -108,7 +108,7 @@ public function testCreateAttributeDefinitionMissingNameReturnsValidationError()
             'required' => false
         ]);
 
-        $this->authenticatedJsonRequest('POST', '/api/v2/subscribers/attributes', [], [], [], $payload);
+        $this->authenticatedJsonRequest('POST', '/api/v2/attributes', [], [], [], $payload);
         $this->assertHttpUnprocessableEntity();
     }
 }