ISSUE-345: phpstan + phpcs fix

Author: tatevikg1

tests/Integration/Controller/SubscriptionControllerTest.php

@@ -54,7 +54,7 @@ public function testCreateSubscriptionWithValidEmailsReturns201(): void
 
         $payload = json_encode(['emails' => ['[email protected]']]);
 
-        $this->authenticatedJsonRequest('POST', '/api/v2/lists/1/subscribers',  [], [], [], $payload);
+        $this->authenticatedJsonRequest('POST', '/api/v2/lists/1/subscribers', [], [], [], $payload);
         $this->assertHttpCreated();
     }
 

tests/Unit/Service/Manager/SubscriberListManagerTest.php

@@ -9,11 +9,12 @@
 use PhpList\Core\Domain\Repository\Subscription\SubscriberListRepository;
 use PhpList\RestBundle\Entity\Request\CreateSubscriberListRequest;
 use PhpList\RestBundle\Service\Manager\SubscriberListManager;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class SubscriberListManagerTest extends TestCase
 {
-    private SubscriberListRepository $subscriberListRepository;
+    private SubscriberListRepository&MockObject $subscriberListRepository;
     private SubscriberListManager $manager;
 
     protected function setUp(): void

tests/Unit/Service/Manager/SubscriptionManagerTest.php

@@ -11,12 +11,13 @@
 use PhpList\Core\Domain\Repository\Subscription\SubscriptionRepository;
 use PhpList\RestBundle\Exception\SubscriptionCreationException;
 use PhpList\RestBundle\Service\Manager\SubscriptionManager;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 
 class SubscriptionManagerTest extends TestCase
 {
-    private SubscriptionRepository $subscriptionRepository;
-    private SubscriberRepository $subscriberRepository;
+    private SubscriptionRepository&MockObject $subscriptionRepository;
+    private SubscriberRepository&MockObject $subscriberRepository;
     private SubscriptionManager $manager;
 
     protected function setUp(): void
@@ -83,7 +84,7 @@ public function testDeleteSubscriptionSkipsNotFound(): void
 
         $this->manager->deleteSubscriptions($subscriberList, [$email]);
 
-        $this->addToAssertionCount(1); // if no exception thrown, test is OK
+        $this->addToAssertionCount(1);
     }
 
     public function testGetSubscriberListMembersReturnsList(): void

tests/Unit/Validator/EmailExistsValidatorTest.php

@@ -8,6 +8,7 @@
 use PhpList\Core\Domain\Repository\Subscription\SubscriberRepository;
 use PhpList\RestBundle\Validator\EmailExists;
 use PhpList\RestBundle\Validator\EmailExistsValidator;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\Context\ExecutionContextInterface;
@@ -17,7 +18,7 @@
 
 class EmailExistsValidatorTest extends TestCase
 {
-    private SubscriberRepository $subscriberRepository;
+    private SubscriberRepository&MockObject $subscriberRepository;
     private EmailExistsValidator $validator;
 
     protected function setUp(): void
@@ -33,7 +34,7 @@ public function testValidateSkipsNull(): void
     {
         $this->subscriberRepository->expects($this->never())->method('findOneBy');
         $this->validator->validate(null, new EmailExists());
-        $this->assertTrue(true); // to mark test as passed
+        $this->assertTrue(true);
     }
 
     public function testValidateSkipsEmptyString(): void

tests/Unit/Validator/TemplateExistsValidatorTest.php

@@ -8,6 +8,7 @@
 use PhpList\Core\Domain\Repository\Messaging\TemplateRepository;
 use PhpList\RestBundle\Validator\TemplateExists;
 use PhpList\RestBundle\Validator\TemplateExistsValidator;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\Context\ExecutionContextInterface;
@@ -17,7 +18,7 @@
 
 class TemplateExistsValidatorTest extends TestCase
 {
-    private TemplateRepository $templateRepository;
+    private TemplateRepository&MockObject $templateRepository;
     private TemplateExistsValidator $validator;
 
     protected function setUp(): void