blacklist request

Author: tatevikg1

src/Subscription/Controller/BlacklistController.php

@@ -10,6 +10,7 @@
 use PhpList\Core\Security\Authentication;
 use PhpList\RestBundle\Common\Controller\BaseController;
 use PhpList\RestBundle\Common\Validator\RequestValidator;
+use PhpList\RestBundle\Subscription\Request\AddToBlacklistRequest;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
@@ -144,20 +145,13 @@ public function addEmailToBlacklist(Request $request): JsonResponse
             throw $this->createAccessDeniedException('You are not allowed to add emails to blacklist.');
         }
 
-        $data = json_decode($request->getContent(), true);
-        if (!isset($data['email']) || empty($data['email'])) {
-            return $this->json(['error' => 'Email is required'], Response::HTTP_UNPROCESSABLE_ENTITY);
-        }
-
-        $email = $data['email'];
-        $reason = $data['reason'] ?? null;
+        /** @var AddToBlacklistRequest $definitionRequest */
+        $definitionRequest = $this->validator->validate($request, AddToBlacklistRequest::class);
 
-        $this->blacklistManager->addEmailToBlacklist($email, $reason);
+        $userBlacklisted = $this->blacklistManager->addEmailToBlacklist($definitionRequest->email, $definitionRequest->reason);
+        $json = $this->normalizer->normalize($userBlacklisted, 'json');
 
-        return $this->json([
-            'success' => true,
-            'message' => sprintf('Email %s has been added to the blacklist', $email),
-        ], Response::HTTP_CREATED);
+        return $this->json($json, Response::HTTP_CREATED);
     }
 
     #[Route('/remove/{email}', name: 'remove', methods: ['DELETE'])]
@@ -209,10 +203,7 @@ public function removeEmailFromBlacklist(Request $request, string $email): JsonR
 
         $this->blacklistManager->removeEmailFromBlacklist($email);
 
-        return $this->json([
-            'success' => true,
-            'message' => sprintf('Email %s has been removed from the blacklist', $email),
-        ]);
+        return $this->json(null, Response::HTTP_NO_CONTENT);
     }
 
     #[Route('/info/{email}', name: 'info', methods: ['GET'])]
@@ -270,14 +261,16 @@ public function getBlacklistInfo(Request $request, string $email): JsonResponse
 
         $blacklistInfo = $this->blacklistManager->getBlacklistInfo($email);
         if (!$blacklistInfo) {
-            return $this->json(['error' => sprintf('Email %s is not blacklisted', $email)], Response::HTTP_NOT_FOUND);
+            return $this->json([
+                'error' => sprintf('Email %s is not blacklisted', $email)
+            ], Response::HTTP_NOT_FOUND);
         }
 
         $reason = $this->blacklistManager->getBlacklistReason($email);
 
         return $this->json([
             'email' => $blacklistInfo->getEmail(),
-            'added' => $blacklistInfo->getAdded() ? $blacklistInfo->getAdded()->format('c') : null,
+            'added' => $blacklistInfo->getAdded()?->format('c'),
             'reason' => $reason,
         ]);
     }

src/Subscription/Request/AddToBlacklistRequest.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace PhpList\RestBundle\Subscription\Request;
+
+use PhpList\RestBundle\Common\Request\RequestInterface;
+use Symfony\Component\Validator\Constraints as Assert;
+
+class AddToBlacklistRequest implements RequestInterface
+{
+    #[Assert\NotBlank]
+    #[Assert\Email]
+    public string $email;
+
+    #[Assert\Type(type: 'string')]
+    public ?string $reason = null;
+
+    public function getDto(): self
+    {
+        return $this;
+    }
+}