Merge pull request #75 from phpList/old-php-versions-support

Don't use constant expressions (to support old PHP versions)

Author: Sam Tuke

index.php

@@ -13,11 +13,8 @@ class updater
 {
     /** @var bool */
     private $availableUpdate = false;
-
     const DOWNLOAD_PATH = '../tmp_uploaded_update';
     const ELIGIBLE_SESSION_KEY = 'phplist_updater_eligible';
-    const CONFIG_FILE = __DIR__ . '/../config/config.php';
-
     private $excludedFiles = array(
         'dl.php',
         'index.php',
@@ -278,20 +275,27 @@ function deleteFiles()
 
     }
 
+    /**
+     * Get config file path
+     * @return string
+     */
+    function getConfigFilePath()
+    {
+        return  __DIR__ . '/../config/config.php';
+    }
+
     /**
      * Get a PDO connection
      * @return PDO
      * @throws UpdateException
      */
     function getConnection()
     {
-        $standardConfig = self::CONFIG_FILE;
-
         if (isset($_SERVER['ConfigFile']) && is_file($_SERVER['ConfigFile'])) {
             include $_SERVER['ConfigFile'];
 
-        } elseif (file_exists($standardConfig)) {
-            include $standardConfig;
+        } elseif (file_exists($this->getConfigFilePath())) {
+            include $this->getConfigFilePath();
         } else {
             throw new \UpdateException("Error: Cannot find config file");
         }
@@ -325,11 +329,10 @@ function getConnection()
      */
     function addMaintenanceMode()
     {
-        $standardConfig = self::CONFIG_FILE;
         if (isset($_SERVER['ConfigFile']) && is_file($_SERVER['ConfigFile'])) {
             include $_SERVER['ConfigFile'];
-        } elseif (file_exists($standardConfig)) {
-            include $standardConfig;
+        } elseif (file_exists($this->getConfigFilePath())) {
+            include $this->getConfigFilePath();
         } else {
             throw new \UpdateException("Error: Cannot find config file");
         }
@@ -367,11 +370,10 @@ function addMaintenanceMode()
      */
     function removeMaintenanceMode()
     {
-        $standardConfig = self::CONFIG_FILE;
         if (isset($_SERVER['ConfigFile']) && is_file($_SERVER['ConfigFile'])) {
             include $_SERVER['ConfigFile'];
-        } elseif (file_exists($standardConfig)) {
-            include $standardConfig;
+        } elseif (file_exists($this->getConfigFilePath())) {
+            include $this->getConfigFilePath();
         } else {
             throw new \UpdateException("Error: Cannot find config file");
         }