Performance patch.

Maikuolan · Maikuolan · commit 2cd65c63e5c0 · 2023-04-04T19:55:51.000+08:00
Only check each unique value ONCE.
diff --git a/src/Loader.php b/src/Loader.php
@@ -8,7 +8,7 @@
  * License: GNU/GPLv2
  * @see LICENSE.txt
  *
- * This file: The loader (last modified: 2023.04.03).
+ * This file: The loader (last modified: 2023.04.04).
  */
 
 namespace phpMussel\Core;
@@ -773,7 +773,7 @@ public function parse(array $Needles, string $Haystack = '', bool $L10N = false)
             return '';
         }
         if ($L10N && preg_match_all('~\{([A-Za-z\d_ -]+)\}~', $Haystack, $Matches)) {
-            foreach ($Matches[1] as $Key) {
+            foreach (array_unique($Matches[1]) as $Key) {
                 if (($Value = $this->L10N->getString($Key)) !== '') {
                     $Haystack = str_replace('{' . $Key . '}', $Value, $Haystack);
                 }

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`* License: GNU/GPLv2`
`9`	`9`	`* @see LICENSE.txt`
`10`	`10`	`*`
`11`		`- * This file: The loader (last modified: 2023.04.03).`
	`11`	`+ * This file: The loader (last modified: 2023.04.04).`
`12`	`12`	`*/`
`13`	`13`
`14`	`14`	`namespace phpMussel\Core;`
`@@ -773,7 +773,7 @@ public function parse(array $Needles, string $Haystack = '', bool $L10N = false)`
`773`	`773`	`return '';`
`774`	`774`	`}`
`775`	`775`	`if ($L10N && preg_match_all('~\{([A-Za-z\d_ -]+)\}~', $Haystack, $Matches)) {`
`776`		`- foreach ($Matches[1] as $Key) {`
	`776`	`+ foreach (array_unique($Matches[1]) as $Key) {`
`777`	`777`	`if (($Value = $this->L10N->getString($Key)) !== '') {`
`778`	`778`	`$Haystack = str_replace('{' . $Key . '}', $Value, $Haystack);`
`779`	`779`	`}`