Skip to content

Commit 04deab9

Browse files
committed
Configuration page aesthetic patch.
Changelog excerpt: - Added flexrow for dropdown menus with included input fields for other values at the configuration page.
1 parent 9bcf0f2 commit 04deab9

File tree

10 files changed

+27
-2
lines changed

10 files changed

+27
-2
lines changed

Changelog.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,3 +181,9 @@ __*Why "v3.0.0" instead of "v1.0.0?"*__ Prior to phpMussel v3, the "phpMussel Co
181181
[2023.12.26; Maikuolan]: Refactored the page greeting.
182182

183183
[2023.12.29; Bug-fix; Maikuolan]: Some of the more unusual available number formatting choices (e.g., choices not using base-10 or Arabic numerals) didn't mesh well with the JavaScript code responsible for using them; Fixed.
184+
185+
### v3.5.1
186+
187+
[2024.04.12; Maikuolan]: Code-style patch.
188+
189+
[2024.04.18; Maikuolan]: Added flexrow for dropdown menus with included input fields for other values at the configuration page.

assets/bluemetal/frontend.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,3 +145,5 @@ input[type=button].reset:hover,input[type=button].reset:active{color:#ffc}
145145
.txtGn::selection,.txtGn>*:not(.txtOe,.txtRd)::selection{color:#dfc}
146146
.txtOe::selection,.txtOe>*:not(.txtGn,.txtRd)::selection{color:#fec}
147147
.txtRd::selection,.txtRd>*:not(.txtGn,.txtOe)::selection{color:#fcc}
148+
.flexrow{display:flex}
149+
.flexin{margin-{FE_Align}:-1px;margin-{FE_Align_Reverse}:1px;width:auto;flex-grow:1}

assets/default/frontend.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,3 +150,5 @@ input[type=button].reset:hover,input[type=button].reset:active{color:#f88}
150150
.txtOe::selection,.txtOe>*:not(.txtGn,.txtRd)::selection{color:#fec}
151151
.txtRd::selection,.txtRd>*:not(.txtGn,.txtOe)::selection{color:#fcc}
152152
input[type=file]::file-selector-button{background-image:url(data:image/svg+xml;base64,{Base64Encode}{Asset:folder.svg}{/Base64Encode});padding-{FE_Align}:20px;background-repeat:no-repeat;background-position:top 1px {FE_Align} 4px}
153+
.flexrow{display:flex}
154+
.flexin{margin-{FE_Align}:-1px;margin-{FE_Align_Reverse}:1px;width:auto;flex-grow:1}

assets/fullmoon/frontend.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,3 +126,5 @@ input[type=button].reset:hover,input[type=button].reset:active{color:#fcefcf}
126126
.txtGn::selection,.txtGn>*:not(.txtOe,.txtRd)::selection{color:#dfc}
127127
.txtOe::selection,.txtOe>*:not(.txtGn,.txtRd)::selection{color:#fec}
128128
.txtRd::selection,.txtRd>*:not(.txtGn,.txtOe)::selection{color:#fcc}
129+
.flexrow{display:flex}
130+
.flexin{margin-{FE_Align}:-1px;margin-{FE_Align_Reverse}:1px;width:auto;flex-grow:1}

assets/moss/frontend.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,3 +147,5 @@ input[type=button].reset:hover,input[type=button].reset:active{color:#b77}
147147
.txtOe::selection,.txtOe>*:not(.txtGn,.txtRd)::selection{color:#fec}
148148
.txtRd::selection,.txtRd>*:not(.txtGn,.txtOe)::selection{color:#fcc}
149149
input[type=file]::file-selector-button{background-image:url(data:image/svg+xml;base64,{Base64Encode}{Asset:folder.svg}{/Base64Encode});padding-{FE_Align}:20px;background-repeat:no-repeat;background-position:top 1px {FE_Align} 4px}
150+
.flexrow{display:flex}
151+
.flexin{margin-{FE_Align}:-1px;margin-{FE_Align_Reverse}:1px;width:auto;flex-grow:1}

assets/primer/frontend.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,3 +152,5 @@ input[type=button].reset:hover,input[type=button].reset:active{color:#f88}
152152
.txtOe::selection,.txtOe>*:not(.txtGn,.txtRd)::selection{color:#fec}
153153
.txtRd::selection,.txtRd>*:not(.txtGn,.txtOe)::selection{color:#fcc}
154154
input[type=file]::file-selector-button{position:relative;top:-2px}
155+
.flexrow{display:flex}
156+
.flexin{margin-{FE_Align}:-1px;margin-{FE_Align_Reverse}:1px;width:auto;flex-grow:1}

assets/primerdark/frontend.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,3 +155,5 @@ input[type=button].reset:hover,input[type=button].reset:active{color:#eaa}
155155
.txtOe::selection,.txtOe>*:not(.txtGn,.txtRd)::selection{color:#fec}
156156
.txtRd::selection,.txtRd>*:not(.txtGn,.txtOe)::selection{color:#fcc}
157157
input[type=file]::file-selector-button{position:relative;top:-2px}
158+
.flexrow{display:flex}
159+
.flexin{margin-{FE_Align}:-1px;margin-{FE_Align_Reverse}:1px;width:auto;flex-grow:1}

assets/rbi/frontend.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,3 +150,5 @@ input[type=button].reset:hover,input[type=button].reset:active{color:#f88}
150150
.txtOe::selection,.txtOe>*:not(.txtGn,.txtRd)::selection{color:#fec}
151151
.txtRd::selection,.txtRd>*:not(.txtGn,.txtOe)::selection{color:#fcc}
152152
input[type=file]::file-selector-button{background-image:url(data:image/svg+xml;base64,{Base64Encode}{Asset:folder.svg}{/Base64Encode});padding-{FE_Align}:20px;background-repeat:no-repeat;background-position:top 1px {FE_Align} 4px}
153+
.flexrow{display:flex}
154+
.flexin{margin-{FE_Align}:-1px;margin-{FE_Align_Reverse}:1px;width:auto;flex-grow:1}

assets/slate/frontend.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,3 +148,5 @@ input[type=button].reset:hover,input[type=button].reset:active{color:#fa7}
148148
.txtOe::selection,.txtOe>*:not(.txtGn,.txtRd)::selection{color:#fec}
149149
.txtRd::selection,.txtRd>*:not(.txtGn,.txtOe)::selection{color:#fcc}
150150
input[type=file]::file-selector-button{background-image:url(data:image/svg+xml;base64,{Base64Encode}{Asset:folder.svg}{/Base64Encode});padding-{FE_Align}:20px;background-repeat:no-repeat;background-position:top 1px {FE_Align} 4px}
151+
.flexrow{display:flex}
152+
.flexin{margin-{FE_Align}:-1px;margin-{FE_Align_Reverse}:1px;width:auto;flex-grow:1}

src/pages/config.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* License: GNU/GPLv2
99
* @see LICENSE.txt
1010
*
11-
* This file: The configuration page (last modified: 2023.12.29).
11+
* This file: The configuration page (last modified: 2024.04.18).
1212
*/
1313

1414
namespace phpMussel\FrontEnd;
@@ -306,6 +306,9 @@
306306
$ThisDir['DirLangKey'],
307307
$ThisDir['Trigger']
308308
);
309+
if (!empty($DirValue['allow_other'])) {
310+
$ThisDir['FieldOut'] = '<div class="flexrow">' . $ThisDir['FieldOut'];
311+
}
309312
}
310313
$DirValue['gridH'] = 'gridHB';
311314
foreach ($DirValue['choices'] as $ChoiceKey => $ChoiceValue) {
@@ -434,7 +437,7 @@
434437
} else {
435438
$ThisDir['SelectOther'] = !isset($DirValue['choices'][$this->Loader->Configuration[$CatKey][$DirKey]]);
436439
$ThisDir['FieldOut'] .= empty($DirValue['allow_other']) ? '</select>' : sprintf(
437-
'<option value="Other"%1$s>%2$s</option></select><input type="text"%3$s class="auto" name="%4$s" id="%4$s_field" value="%5$s" />',
440+
'<option value="Other"%1$s>%2$s</option></select><input type="text"%3$s class="flexin" name="%4$s" id="%4$s_field" value="%5$s" /></div>',
438441
$ThisDir['SelectOther'] ? ' selected' : '',
439442
$this->Loader->L10N->getString('label.Other'),
440443
$ThisDir['SelectOther'] ? '' : ' style="display:none"',

0 commit comments

Comments
 (0)