Use promoted properties

This change (by `ClassPropertyAssignToConstructorPromotionRector`
Rector rule) does not touch properties with initializers as default
value (to be done separately).

Author: przepompownia

bin/serve.php

@@ -46,7 +46,7 @@
 
 require __DIR__ . '/../vendor/autoload.php';
 
-if ($argc === 1) {
+if (($argc ?? 0) === 1) {
     echo <<<DOC
 Usage: serve.php --address=127.0.0.1:9000 --type=tcp
 

lib/Core/Command/ClosureCommand.php

@@ -6,14 +6,8 @@
 
 class ClosureCommand implements Command
 {
-    /**
-     * @var Closure
-     */
-    private $closure;
-
-    public function __construct(Closure $closure)
+    public function __construct(private Closure $closure)
     {
-        $this->closure = $closure;
     }
 
     /**

lib/Core/Diagnostics/AggregateDiagnosticsProvider.php

@@ -16,15 +16,9 @@ class AggregateDiagnosticsProvider implements DiagnosticsProvider
      */
     private $providers;
 
-    /**
-     * @var LoggerInterface
-     */
-    private $logger;
-
-    public function __construct(LoggerInterface $logger, DiagnosticsProvider ...$providers)
+    public function __construct(private LoggerInterface $logger, DiagnosticsProvider ...$providers)
     {
         $this->providers = $providers;
-        $this->logger = $logger;
     }
 
     /**

lib/Core/Diagnostics/ClosureDiagnosticsProvider.php

@@ -9,17 +9,8 @@
 
 class ClosureDiagnosticsProvider implements DiagnosticsProvider
 {
-    /**
-     * @var Closure
-     */
-    private $closure;
-
-    private string $name;
-
-    public function __construct(Closure $closure, string $name = 'closure')
+    public function __construct(private Closure $closure, private string $name = 'closure')
     {
-        $this->closure = $closure;
-        $this->name = $name;
     }
 
     public function provideDiagnostics(TextDocumentItem $textDocument, CancellationToken $cancel): Promise

lib/Core/Dispatcher/Dispatcher/ClosureDispatcher.php

@@ -10,17 +10,11 @@
 
 final class ClosureDispatcher implements Dispatcher
 {
-    /**
-     * @var Closure
-     */
-    private $closure;
-
     /**
      * @param Closure(Message): Promise<ResponseMessage|null> $closure
      */
-    public function __construct(Closure $closure)
+    public function __construct(private Closure $closure)
     {
-        $this->closure = $closure;
     }
 
     /**

lib/Core/Dispatcher/Factory/ClosureDispatcherFactory.php

@@ -11,14 +11,8 @@
 
 final class ClosureDispatcherFactory implements DispatcherFactory
 {
-    /**
-     * @var Closure
-     */
-    private $factory;
-
-    public function __construct(Closure $factory)
+    public function __construct(private Closure $factory)
     {
-        $this->factory = $factory;
     }
 
     public function create(MessageTransmitter $transmitter, InitializeParams $initializeParams): Dispatcher

lib/Core/Handler/ClosureHandler.php

@@ -6,20 +6,8 @@
 
 final class ClosureHandler implements Handler
 {
-    /**
-     * @var string
-     */
-    private $methodName;
-
-    /**
-     * @var Closure
-     */
-    private $closure;
-
-    public function __construct(string $methodName, Closure $closure)
+    public function __construct(private string $methodName, private Closure $closure)
     {
-        $this->methodName = $methodName;
-        $this->closure = $closure;
     }
 
     /**

lib/Core/Handler/HandlerMethodRunner.php

@@ -17,11 +17,6 @@
 
 final class HandlerMethodRunner implements MethodRunner
 {
-    /**
-     * @var Handlers
-     */
-    private $handlers;
-
     /**
      * @var HandlerMethodResolver
      */
@@ -43,12 +38,11 @@ final class HandlerMethodRunner implements MethodRunner
     private $argumentResolver;
 
     public function __construct(
-        Handlers $handlers,
+        private Handlers $handlers,
         ?ArgumentResolver $argumentResolver = null,
         ?LoggerInterface $logger = null,
         ?HandlerMethodResolver $resolver = null
     ) {
-        $this->handlers = $handlers;
         $this->resolver = $resolver ?: new HandlerMethodResolver();
         $this->logger = $logger ?: new NullLogger();
         $this->argumentResolver = $argumentResolver ?: new PassThroughArgumentResolver();

lib/Core/Middleware/RequestHandler.php

@@ -9,14 +9,10 @@
 
 final class RequestHandler
 {
-    /**
-     * @var array<Middleware>
-     */
-    private $queue;
-
-    public function __construct(array $queue = [])
-    {
-        $this->queue = $queue;
+    public function __construct(
+        /** @var array<Middleware> */
+        private array $queue = []
+    ) {
     }
 
     /**

lib/Core/Rpc/NotificationMessage.php

@@ -4,19 +4,10 @@
 
 final class NotificationMessage extends Message
 {
-    /**
-     * @var string
-     */
-    public $method;
-
-    /**
-     * @var array<string,mixed>|null
-     */
-    public $params;
-
-    public function __construct(string $method, ?array $params = null)
-    {
-        $this->method = $method;
-        $this->params = $params;
+    public function __construct(
+        public string $method,
+        /** @var array<string,mixed>|null */
+        public ?array $params = null
+    ) {
     }
 }