Add better type hints

dantleech · dantleech · commit 595830fe7be8 · 2022-10-16T10:48:22.000+02:00
diff --git a/lib/ExtractOffset.php b/lib/ExtractOffset.php
@@ -9,21 +9,21 @@
 class ExtractOffset
 {
     /**
-     * @return array<string>
+     * @return array{string,int,int}
      */
     public static function fromSource(string $source, string $marker = '<>'): array
     {
         list($source, $offsetStart) = self::extractOffset($source, $marker);
         list($source, $offsetEnd) = self::extractOffset($source, $marker);
 
-        return [$source, $offsetStart, $offsetEnd];
+        return [$source, (int)$offsetStart, (int)$offsetEnd];
     }
 
     /**
      * Extract the byte offset from the given marked source
      * and remove the <> mark.
      *
-     * @return array<mixed>
+     * @return array{string,int}
      */
     private static function extractOffset(string $source, string $marker): array
     {

Original file line number	Diff line number	Diff line change
`@@ -9,21 +9,21 @@`
`9`	`9`	`class ExtractOffset`
`10`	`10`	`{`
`11`	`11`	`/**`
`12`		`- * @return array<string>`
	`12`	`+ * @return array{string,int,int}`
`13`	`13`	`*/`
`14`	`14`	`public static function fromSource(string $source, string $marker = '<>'): array`
`15`	`15`	`{`
`16`	`16`	`list($source, $offsetStart) = self::extractOffset($source, $marker);`
`17`	`17`	`list($source, $offsetEnd) = self::extractOffset($source, $marker);`
`18`	`18`
`19`		`- return [$source, $offsetStart, $offsetEnd];`
	`19`	`+ return [$source, (int)$offsetStart, (int)$offsetEnd];`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`/**`
`23`	`23`	`* Extract the byte offset from the given marked source`
`24`	`24`	`* and remove the <> mark.`
`25`	`25`	`*`
`26`		`- * @return array<mixed>`
	`26`	`+ * @return array{string,int}`
`27`	`27`	`*/`
`28`	`28`	`private static function extractOffset(string $source, string $marker): array`
`29`	`29`	`{`