Skip to content

Commit 97b6e9a

Browse files
committed
Revert: regression test already covered by existing test
test_is_not_abstract_in_that_should_include_final_classes already verifies that final classes are not skipped by IsNotAbstract in that(). The added test was redundant. https://claude.ai/code/session_01WbCDSrm9TuAEGEZ3nQz7A3
1 parent d09feb6 commit 97b6e9a

File tree

1 file changed

+0
-28
lines changed

1 file changed

+0
-28
lines changed

tests/Integration/IsAbstractTest.php

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -161,34 +161,6 @@ public function test_is_not_abstract_in_should_validates_final_classes_correctly
161161
self::assertCount(0, $runner->getParsingErrors());
162162
}
163163

164-
public function test_is_not_abstract_in_that_does_not_skip_final_readonly_classes(): void
165-
{
166-
$structure = [
167-
'My' => [
168-
'Namespace' => [
169-
'TreeTypeID.php' => '<?php namespace My\Namespace; final readonly class TreeTypeID extends ID {}',
170-
],
171-
],
172-
];
173-
174-
$runner = TestRunner::create('8.4');
175-
176-
$rule = Rule::allClasses()
177-
->that(new ResideInOneOfTheseNamespaces('My\Namespace'))
178-
->andThat(new IsNotTrait())
179-
->andThat(new IsNotAbstract())
180-
->andThat(new IsNotInterface())
181-
->andThat(new IsNotEnum())
182-
->should(new HaveNameMatching('My*'))
183-
->because('we want to prefix classes in this namespace with My');
184-
185-
$runner->run(vfsStream::setup('root', null, $structure)->url(), $rule);
186-
187-
self::assertCount(1, $runner->getViolations());
188-
self::assertEquals('My\Namespace\TreeTypeID', $runner->getViolations()->get(0)->getFqcn());
189-
self::assertCount(0, $runner->getParsingErrors());
190-
}
191-
192164
public function test_it_can_check_multiple_class_properties(): void
193165
{
194166
$structure = [

0 commit comments

Comments
 (0)