Remove dead getExtends/addExtends from ClassDescription

Now that Extend/NotExtend/HaveTrait/NotHaveTrait/Implement/NotImplement
resolve the full inheritance chain via reflection, the static extends
list stored in ClassDescription is never consulted. Remove addExtends()
from ClassDescriptionBuilder, getExtends() from ClassDescription, the
corresponding wiring in FileVisitor, and update all call sites in tests.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: fain182

src/Analyzer/ClassDescription.php

@@ -13,9 +13,6 @@ class ClassDescription
     /** @var list<ClassDependency> */
     private array $dependencies;
 
-    /** @var list<FullyQualifiedClassName> */
-    private array $extends;
-
     /** @var list<string> */
     private array $docBlock;
 
@@ -39,15 +36,13 @@ class ClassDescription
 
     /**
      * @param list<ClassDependency>         $dependencies
-     * @param list<FullyQualifiedClassName> $extends
      * @param list<string>                  $docBlock
      * @param list<FullyQualifiedClassName> $attributes
      * @param list<FullyQualifiedClassName> $traits
      */
     public function __construct(
         FullyQualifiedClassName $FQCN,
         array $dependencies,
-        array $extends,
         bool $final,
         bool $readonly,
         bool $abstract,
@@ -62,7 +57,6 @@ public function __construct(
         $this->FQCN = $FQCN;
         $this->filePath = $filePath;
         $this->dependencies = $dependencies;
-        $this->extends = $extends;
         $this->final = $final;
         $this->readonly = $readonly;
         $this->abstract = $abstract;
@@ -131,14 +125,6 @@ public function getDependencies(): array
         return $this->dependencies;
     }
 
-    /**
-     * @return list<FullyQualifiedClassName>
-     */
-    public function getExtends(): array
-    {
-        return $this->extends;
-    }
-
     public function isFinal(): bool
     {
         return $this->final;

src/Analyzer/ClassDescriptionBuilder.php

@@ -12,9 +12,6 @@ class ClassDescriptionBuilder
 
     private ?FullyQualifiedClassName $FQCN = null;
 
-    /** @var list<FullyQualifiedClassName> */
-    private array $extends = [];
-
     private bool $final = false;
 
     private bool $readonly = false;
@@ -42,7 +39,6 @@ public function clear(): void
     {
         $this->FQCN = null;
         $this->classDependencies = [];
-        $this->extends = [];
         $this->final = false;
         $this->readonly = false;
         $this->abstract = false;
@@ -79,14 +75,6 @@ public function addDependency(ClassDependency $cd): self
         return $this;
     }
 
-    public function addExtends(string $FQCN, int $line): self
-    {
-        $this->addDependency(new ClassDependency($FQCN, $line));
-        $this->extends[] = FullyQualifiedClassName::fromString($FQCN);
-
-        return $this;
-    }
-
     public function setFinal(bool $final): self
     {
         $this->final = $final;
@@ -160,7 +148,6 @@ public function build(): ClassDescription
         return new ClassDescription(
             $this->FQCN,
             $this->classDependencies,
-            $this->extends,
             $this->final,
             $this->readonly,
             $this->abstract,

src/Analyzer/FileVisitor.php

@@ -134,7 +134,7 @@ private function handleClassNode(Node $node): void
 
         if (null !== $node->extends) {
             $this->classDescriptionBuilder
-                ->addExtends($node->extends->toString(), $node->getLine());
+                ->addDependency(new ClassDependency($node->extends->toString(), $node->getLine()));
         }
 
         $this->classDescriptionBuilder->setFinal($node->isFinal());
@@ -293,7 +293,7 @@ private function handleInterfaceNode(Node $node): void
 
         foreach ($node->extends as $interface) {
             $this->classDescriptionBuilder
-                ->addExtends($interface->toString(), $interface->getLine());
+                ->addDependency(new ClassDependency($interface->toString(), $interface->getLine()));
         }
     }
 

tests/Unit/Analyzer/FileParser/CanParseClassTest.php

@@ -208,7 +208,7 @@ class Cat extends Animal
         $cd = $this->parseCode($code);
         $cd = $cd[1];
 
-        self::assertEquals('Root\Animals\Animal', $cd->getExtends()[0]->toString());
+        self::assertEquals('Root\Animals\Animal', $cd->getDependencies()[0]->getFQCN()->toString());
     }
 
     public function test_it_should_not_parse_extends_from_insider_anonymousclass(): void
@@ -234,7 +234,7 @@ public function methodWithAnonymous(): void
         $cd = $this->parseCode($code);
         $cd = $cd[1];
 
-        self::assertEquals('Root\Animals\Animal', $cd->getExtends()[0]->toString());
+        self::assertEquals('Root\Animals\Animal', $cd->getDependencies()[0]->getFQCN()->toString());
     }
 
     public function test_should_depends_on_these_namespaces(): void
@@ -500,8 +500,8 @@ public function foobar();
         $cd = $this->parseCode($code, TargetPhpVersion::PHP_8_1);
 
         self::assertCount(3, $cd);
-        self::assertEquals('MyProject\AppBundle\Application\FooAble', $cd[2]->getExtends()[0]->toString());
-        self::assertEquals('MyProject\AppBundle\Application\BarAble', $cd[2]->getExtends()[1]->toString());
+        self::assertEquals('MyProject\AppBundle\Application\FooAble', $cd[2]->getDependencies()[0]->getFQCN()->toString());
+        self::assertEquals('MyProject\AppBundle\Application\BarAble', $cd[2]->getDependencies()[1]->getFQCN()->toString());
     }
 
     public function test_it_handles_return_types(): void

tests/Unit/Expressions/ForClasses/ExtendTest.php

@@ -124,7 +124,6 @@ public function test_it_should_detect_grandparent_via_reflection(): void
         $classDescription = (new ClassDescriptionBuilder())
             ->setFilePath('src/Foo.php')
             ->setClassName(ChildClass::class)
-            ->addExtends(MiddleClass::class, 10)
             ->build();
 
         $violations = new Violations();

tests/Unit/Expressions/ForClasses/HaveTraitTest.php

@@ -166,7 +166,6 @@ public function test_it_should_detect_trait_inherited_from_parent_via_reflection
         $classDescription = (new ClassDescriptionBuilder())
             ->setFilePath('src/Foo.php')
             ->setClassName(ChildInheritingSomeTrait::class)
-            ->addExtends(ClassUsingSomeTrait::class, 1)
             ->build();
 
         $violations = new Violations();

tests/Unit/Expressions/ForClasses/ImplementTest.php

@@ -102,7 +102,6 @@ public function test_it_should_detect_interface_inherited_from_parent_via_reflec
         $classDescription = (new ClassDescriptionBuilder())
             ->setFilePath('src/Foo.php')
             ->setClassName(DerivedClass::class)
-            ->addExtends(ConcreteClass::class, 1)
             ->build();
 
         $violations = new Violations();

tests/Unit/Expressions/ForClasses/IsATest.php

@@ -38,7 +38,6 @@ public function test_it_should_have_no_violation_when_it_extends(): void
         $classDescription = (new ClassDescriptionBuilder())
             ->setFilePath('src/Foo.php')
             ->setClassName(DwarfCavendishBanana::class)
-            ->addExtends($class, 10)
             ->build();
 
         $violations = new Violations();

tests/Unit/Expressions/ForClasses/NotExtendTest.php

@@ -83,7 +83,6 @@ public function test_it_should_detect_grandparent_as_violation_via_reflection():
         $classDescription = (new ClassDescriptionBuilder())
             ->setFilePath('src/Foo.php')
             ->setClassName(ChildClass::class)
-            ->addExtends(MiddleClass::class, 1)
             ->build();
 
         $violations = new Violations();

tests/Unit/Expressions/ForClasses/NotHaveTraitTest.php

@@ -164,7 +164,6 @@ public function test_it_should_detect_trait_inherited_from_parent_as_violation_v
         $classDescription = (new ClassDescriptionBuilder())
             ->setFilePath('src/Foo.php')
             ->setClassName(ChildInheritingSomeTrait::class)
-            ->addExtends(ClassUsingSomeTrait::class, 1)
             ->build();
 
         $violations = new Violations();