Skip to content

Commit 0c6cbd4

Browse files
committed
Fix issue with empty strings
1 parent 706e6a3 commit 0c6cbd4

File tree

1 file changed

+24
-7
lines changed

1 file changed

+24
-7
lines changed

.github/workflows/tests.yml

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -316,11 +316,18 @@ jobs:
316316
DB: ${{steps.database-type.outputs.db}}
317317
COVERAGE: ${{ matrix.COVERAGE == '1' && '1' || '0' }}
318318
run: |
319+
args=()
320+
if [ "$COVERAGE" == "1" ]; then
321+
args+=(--coverage-clover build/logs/clover.xml)
322+
fi
323+
if [ "$FUNCTIONAL_TESTS" == "0" ]; then
324+
args+=(--exclude-group functional)
325+
fi
326+
319327
phpBB/vendor/bin/phpunit \
320-
--configuration "phpBB/ext/$EXTNAME/.github/phpunit-$DB-github.xml" \
321-
--bootstrap ./tests/bootstrap.php \
322-
"$( [[ "$COVERAGE" == "1" ]] && echo "--coverage-clover build/logs/clover.xml" )" \
323-
"$( [[ "$FUNCTIONAL_TESTS" == "0" ]] && echo "--exclude-group functional" )"
328+
--configuration "phpBB/ext/$EXTNAME/.github/phpunit-$DB-github.xml" \
329+
--bootstrap ./tests/bootstrap.php \
330+
"${args[@]}"
324331
working-directory: ./phpBB3
325332

326333
- name: Send code coverage
@@ -465,10 +472,15 @@ jobs:
465472
env:
466473
DB: ${{steps.database-type.outputs.db}}
467474
run: |
468-
phpBB/vendor/bin/phpunit \
475+
args=()
476+
if [ "$FUNCTIONAL_TESTS" == "0" ]; then
477+
args+=(--exclude-group functional)
478+
fi
479+
480+
phpBB/vendor/bin/phpunit \
469481
--configuration "phpBB/ext/$EXTNAME/.github/phpunit-$DB-github.xml" \
470482
--bootstrap ./tests/bootstrap.php \
471-
"$( [[ "$FUNCTIONAL_TESTS" == "0" ]] && echo "--exclude-group functional" )"
483+
"${args[@]}"
472484
working-directory: ./phpBB3
473485
# END PostgreSQL Job
474486

@@ -605,10 +617,15 @@ jobs:
605617
env:
606618
DB: ${{steps.database-type.outputs.db}}
607619
run: |
620+
args=()
621+
if [ "$FUNCTIONAL_TESTS" == "0" ]; then
622+
args+=(--exclude-group functional)
623+
fi
624+
608625
phpBB/vendor/bin/phpunit \
609626
--configuration "phpBB/ext/$EXTNAME/.github/phpunit-$DB-github.xml" \
610627
--bootstrap ./tests/bootstrap.php \
611-
"$( [[ "$FUNCTIONAL_TESTS" == "0" ]] && echo "--exclude-group functional" )"
628+
"${args[@]}"
612629
working-directory: ./phpBB3
613630
# END Other Tests Job
614631

0 commit comments

Comments
 (0)