Merge pull request #30 from Elsensee/fix-shortarraysyntax

Allow short array syntax

Author: nickvergessen

src/Phpbb/TranslationValidator/Tests/FileValidator/ValidateNoPhpClosingTagTest.php

@@ -28,6 +28,11 @@ public function validateNoPhpClosingTagData()
 				Output::FATAL . '-File must not contain a PHP closing tag, but end with one new line-nophpclosingtag/withtag.php-',
 			)),
 			array('3.1', 'nophpclosingtag/withcrlf.php', array()),
+			array('3.1', 'nophpclosingtag/shortarraysyntax.php', array(
+				Output::FATAL . '-File must not contain short array syntax for any version prior to 3.2-nophpclosingtag/shortarraysyntax.php-',
+			)),
+
+			array('3.2', 'nophpclosingtag/shortarraysyntax.php', array()),
 		);
 	}
 

src/Phpbb/TranslationValidator/Tests/FileValidator/fixtures/origin/nophpclosingtag/shortarraysyntax.php

@@ -0,0 +1,5 @@
+<?php
+
+$synonyms = [
+	'Cacao'			=> 'Kakao',
+];

src/Phpbb/TranslationValidator/Validator/FileValidator.php

@@ -594,7 +594,14 @@ public function validateNoPhpClosingTag($originFile)
 		// Does the file contain anything after the last ");"
 		if (substr($fileContents, -3) !== ");\n")
 		{
-			$this->output->addMessage(Output::FATAL, 'File must not contain a PHP closing tag, but end with one new line', $originFile);
+			if (substr($fileContents, -3) !== "];\n")
+			{
+				$this->output->addMessage(Output::FATAL, 'File must not contain a PHP closing tag, but end with one new line', $originFile);
+			}
+			else if ($this->phpbbVersion === '3.1')
+			{
+				$this->output->addMessage(OUTPUT::FATAL, 'File must not contain short array syntax for any version prior to 3.2', $originFile);
+			}
 		}
 	}