Better handle webdav io errors in advanced settings window

Author: samuelchemla

app/src/main/java/com/phpbg/easysync/ui/AdvancedSyncSettingsActivity.kt

@@ -36,16 +36,20 @@ import androidx.compose.foundation.layout.height
 import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.rememberScrollState
 import androidx.compose.foundation.verticalScroll
+import androidx.compose.material.icons.Icons
+import androidx.compose.material.icons.filled.Warning
 import androidx.compose.material3.CircularProgressIndicator
 import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.Surface
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.livedata.observeAsState
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.phpbg.easysync.R
+import com.phpbg.easysync.ui.components.StatusTitle
 import com.phpbg.easysync.ui.components.StdText
 import com.phpbg.easysync.ui.components.SwitchSetting
 import com.phpbg.easysync.ui.components.Title
@@ -70,7 +74,7 @@ class AdvancedSyncSettingsActivity : ComponentActivity() {
                 ) {
                     val uiState = viewModel.advancedSyncSettingsUiState.observeAsState()
                     Main(
-                        uiState = uiState.value ?: AdvancedSyncSettingsUiState(paths = listOf()),
+                        uiState = uiState.value ?: AdvancedSyncSettingsUiState(paths = listOf(), errorMsg = null),
                         toggleExclusionHandler = viewModel::toggleExclusion
                     )
                 }
@@ -95,6 +99,14 @@ private fun Main(
         StdText(text = stringResource(R.string.advanced_sync_settings_activity_help))
         Spacer(modifier = Modifier.height(16.dp))
 
+        if (!uiState.errorMsg.isNullOrEmpty()) {
+            StatusTitle(
+                title = uiState.errorMsg,
+                statusColor = Color.Red,
+                statusIcon = Icons.Default.Warning
+            )
+        }
+
         if (uiState.paths.isEmpty()) {
             CircularProgressIndicator(color = MaterialTheme.colorScheme.outline)
         } else {
@@ -125,6 +137,28 @@ private fun MainPreview() {
                     SyncPath(relativePath = "/bar/baz", enabled = false),
                     SyncPath(relativePath = "/quuux", enabled = true)
                 ),
+                errorMsg = null
+            ),
+            toggleExclusionHandler = { _, _ -> }
+        )
+    }
+}
+
+@Preview(name = "Light Mode", showBackground = true)
+@Composable
+private fun MainPreviewError() {
+    EasySyncTheme {
+        Main(
+            uiState = AdvancedSyncSettingsUiState(
+                paths = listOf(
+                    SyncPath(
+                        relativePath = "/foo",
+                        enabled = true
+                    ),
+                    SyncPath(relativePath = "/bar/baz", enabled = false),
+                    SyncPath(relativePath = "/quuux", enabled = true)
+                ),
+                errorMsg = "WebDav error: unable to resolve host"
             ),
             toggleExclusionHandler = { _, _ -> }
         )

app/src/main/java/com/phpbg/easysync/ui/AdvancedSyncSettingsUiState.kt

@@ -26,4 +26,4 @@ package com.phpbg.easysync.ui
 
 data class SyncPath(val relativePath: String, val enabled: Boolean)
 
-data class AdvancedSyncSettingsUiState(val paths: List<SyncPath>)
+data class AdvancedSyncSettingsUiState(val paths: List<SyncPath>, val errorMsg: String?)

app/src/main/java/com/phpbg/easysync/ui/AdvancedSyncSettingsViewModel.kt

@@ -32,7 +32,6 @@ import androidx.lifecycle.viewModelScope
 import com.phpbg.easysync.dav.CollectionPath
 import com.phpbg.easysync.dav.WebDavService
 import com.phpbg.easysync.mediastore.MediaStoreService
-import com.phpbg.easysync.settings.Settings
 import com.phpbg.easysync.settings.SettingsDataStore
 import kotlinx.coroutines.async
 import kotlinx.coroutines.awaitAll
@@ -47,24 +46,32 @@ class AdvancedSyncSettingsViewModel(application: Application) : AndroidViewModel
 
     fun load() {
         viewModelScope.launch {
-            val (_paths, _settings, _davPaths) = awaitAll(
+            var error: String? = null
+            val settings = settingsDataStore.getSettings()
+            val (paths, davPaths) = awaitAll(
                 async { mediaStoreService.getAllPaths() },
-                async { settingsDataStore.getSettings() },
                 async {
-                    val webDavService = WebDavService.create(settingsDataStore.getSettings())
-                    webDavService.getAllCollections(CollectionPath("/"))
+                    try {
+                        val webDavService = WebDavService.create(settingsDataStore.getSettings())
+                        webDavService.getAllCollections(CollectionPath("/"))
+                    } catch (e: Exception) {
+                        error = "WebDav error: ${e.message ?: "unknown webdav error"}"
+                        setOf()
+                    }
                 }
             )
-            val paths = _paths as Set<String>
-            val davPaths = _davPaths as Set<String>
-            val settings = _settings as Settings
             val syncPaths = (paths + davPaths).toSortedSet().map {
                 SyncPath(
                     relativePath = it,
                     enabled = !settings.pathExclusions.contains(it)
                 )
             }
-            _advancedSyncSettingsUiState.postValue(AdvancedSyncSettingsUiState(paths = syncPaths))
+            _advancedSyncSettingsUiState.postValue(
+                AdvancedSyncSettingsUiState(
+                    paths = syncPaths,
+                    errorMsg = error
+                )
+            )
         }
     }
 
@@ -75,7 +82,7 @@ class AdvancedSyncSettingsViewModel(application: Application) : AndroidViewModel
                     it.takeIf { it.relativePath != relativePath }
                         ?: SyncPath(relativePath = it.relativePath, enabled = activated)
                 }
-                _advancedSyncSettingsUiState.postValue(AdvancedSyncSettingsUiState(paths = updatedList))
+                _advancedSyncSettingsUiState.postValue(uiState.copy(paths = updatedList))
                 settingsDataStore.updateExclusionPath(relativePath, !activated)
             }
         }