Changes for the extension class

- Phpbrew uses 'stable' as the default version for extensions, we should
  use it here too.
- We can't assume httpd/apache is installed on the system, so we start
  with an undefined service to reload which will do nothing. To reload a
  service your should pass it explicitly.
- Cleanup if statement

Author: EdwinHoksberg

manifests/extension.pp

@@ -17,8 +17,9 @@
 define phpbrew::extension(
   $extension = undef,
   $php_version = undef,
-  $version = undef,
+  $version = 'stable',
   $install_dir = '/opt/phpbrew',
+  $reload_service = undef,
 ) {
   if ! $extension {
     $extension_name = $title
@@ -27,14 +28,14 @@
   }
 
   if ! $php_version {
-    warning('No php version for extension given. Install aborted.')
-  } else {
-    exec { "phpbrew_extension_${extension_name}-${php_version}-${version}":
-      command => "/root/.phpbrew/install_extension.sh ${php_version} ${extension_name} ${version}",
-      timeout => 0,
-      user    => 'root',
-      creates => "${install_dir}/php/php-${php_version}/var/db/${extension_name}.ini",
-      notify  => Service['httpd']
-    }
+    fail('No php version for extension given. Install aborted.')
+  }
+
+  exec { "phpbrew_extension_${extension_name}-${php_version}-${version}":
+    command => "/root/.phpbrew/install_extension.sh ${php_version} ${extension_name} ${version}",
+    timeout => 0,
+    user    => 'root',
+    creates => "${install_dir}/php/php-${php_version}/var/db/${extension_name}.ini",
+    notify  => Service[$reload_service]
   }
-}
+}