fix bug default argument value

Author: phpdevcommunity

src/CommandRunner.php

@@ -94,6 +94,11 @@ private function execute(CommandInterface $command, CommandParser $commandParser
         $argvOptions = [];
 
         $options = $command->getOptions();
+        foreach ($options as $option) {
+            if ($option->isFlag()) {
+                $argvOptions["--{$option->getName()}"] = false;
+            }
+        }
         foreach ($commandParser->getOptions() as $name => $value) {
             $hasOption = false;
             foreach ($options as $option) {
@@ -121,6 +126,8 @@ private function execute(CommandInterface $command, CommandParser $commandParser
             }
             if ($commandParser->hasArgument($key)) {
                 $argv["--{$argument->getName()}"] = $commandParser->getArgumentValue($key);
+            }else {
+                $argv["--{$argument->getName()}"] = $argument->getDefaultValue();
             }
         }
 

src/Input.php

@@ -39,7 +39,6 @@ public function hasOption(string $name): bool
         if (!self::startsWith($name, '--')) {
             $name = "--$name";
         }
-
         return array_key_exists($name, $this->options);
     }
 
@@ -57,6 +56,9 @@ public function getOptionValue(string $name)
 
     public function getArgumentValue(string $name)
     {
+        if (!self::startsWith($name, '--')) {
+            $name = "--$name";
+        }
         if (!$this->hasArgument($name)) {
             throw new \InvalidArgumentException(sprintf('Argument "%s" is not defined.', $name));
         }
@@ -65,6 +67,9 @@ public function getArgumentValue(string $name)
 
     public function hasArgument(string $name): bool
     {
+        if (!self::startsWith($name, '--')) {
+            $name = "--$name";
+        }
         return array_key_exists($name, $this->arguments);
     }
 

tests/Command/FooCommand.php

@@ -31,7 +31,7 @@ public function getOptions(): array
     public function getArguments(): array
     {
         return [
-            new CommandArgument('input', false, null, 'The input file for the foo operation')
+            new CommandArgument('input', false, 'none', 'The input file for the foo operation')
         ];
     }
 

tests/CommandTest.php

@@ -93,4 +93,4 @@ public function testExecute(): void
 
         $this->assertEquals(6, $lines);
     }
-}
+}

tests/InputTest.php

@@ -71,7 +71,7 @@ public function testGetOptionValue()
 
     public function testGetArgumentValue()
     {
-        $input = new Input('test', [], ['argument' => 'value']);
+        $input = new Input('test', [], ['--argument' => 'value']);
         $this->assertEquals('value', $input->getArgumentValue('argument'));
         $this->expectException(\InvalidArgumentException::class, function () use ($input) {
             $input->getArgumentValue('invalid');
@@ -80,8 +80,8 @@ public function testGetArgumentValue()
 
     public function testHasArgument()
     {
-        $input = new Input('test', [], ['argument' => 'value']);
+        $input = new Input('test', [], ['--argument' => 'value']);
         $this->assertTrue($input->hasArgument('argument'));
         $this->assertFalse($input->hasArgument('invalid'));
     }
-}
+}