Occur no understand SIGSEGV.

Author: jmjoy

examples/hello/src/lib.rs

@@ -2,7 +2,7 @@ use phper::{
     arrays::Array,
     classes::{DynamicClass, Visibility},
     functions::Argument,
-    ini::Policy,
+    ini::{Ini, Policy},
     modules::{Module, ModuleArgs},
     objects::Object,
     php_get_module,
@@ -31,10 +31,10 @@ pub fn get_module() -> Module {
     );
 
     // register module ini
-    module.add_ini("hello.enable", false, Policy::All);
-    module.add_ini("hello.num", 100, Policy::All);
-    module.add_ini("hello.ratio", 1.5, Policy::All);
-    module.add_ini("hello.description", "hello world.".to_owned(), Policy::All);
+    Ini::add("hello.enable", false, Policy::All);
+    Ini::add("hello.num", 100, Policy::All);
+    Ini::add("hello.ratio", 1.5, Policy::All);
+    Ini::add("hello.description", "hello world.".to_owned(), Policy::All);
 
     // register hook functions
     module.on_module_init(module_init);
@@ -50,10 +50,10 @@ pub fn get_module() -> Module {
         |_: &mut [Val]| {
             let mut arr = Array::new();
 
-            let hello_enable = Val::new(Module::get_ini::<bool>("hello.enable"));
+            let hello_enable = Val::new(Ini::get::<bool>("hello.enable"));
             arr.insert("hello.enable", hello_enable);
 
-            let hello_description = Val::new(Module::get_ini::<String>("hello.description"));
+            let hello_description = Val::new(Ini::get::<String>("hello.description"));
             arr.insert("hello.description", hello_description);
 
             arr

phper/src/ini.rs

@@ -14,7 +14,7 @@ use std::{
     collections::HashMap,
     convert::TryFrom,
     ffi::CStr,
-    mem::{size_of, transmute, transmute_copy, zeroed},
+    mem::{forget, size_of, transmute, transmute_copy, zeroed},
     os::raw::{c_char, c_void},
     ptr::null_mut,
     str,
@@ -23,7 +23,9 @@ use std::{
 pub struct Ini;
 
 impl Ini {
+    // TODO Remove thread_local.
     thread_local! {
+        static REGISTERED: bool = false;
         static INI_ENTITIES: DashMap<String, IniEntity> = DashMap::new();
     }
 
@@ -36,7 +38,7 @@ impl Ini {
         });
     }
 
-    fn get<T: TransformIniValue>(name: &str) -> Option<T> {
+    pub fn get<T: TransformIniValue>(name: &str) -> Option<T> {
         Self::INI_ENTITIES.with(|ini_entities| {
             ini_entities
                 .get(name)
@@ -48,8 +50,8 @@ impl Ini {
         let mut entries = Vec::new();
 
         Self::INI_ENTITIES.with(|ini_entities| {
-            for entity in ini_entities {
-                entries.push(entity.value().entry());
+            for mut entity in ini_entities.iter_mut() {
+                entries.push(entity.value_mut().entry());
             }
         });
 
@@ -234,8 +236,14 @@ pub(crate) fn create_ini_entry_ex(
     ))]
     let (modifiable, name_length) = (modifiable as std::os::raw::c_int, name.len() as u32);
 
+    let name = name.to_string();
+    let boxed_name = name.into_boxed_str();
+    let name = boxed_name.as_ptr().cast();
+    forget(boxed_name);
+
     zend_ini_entry_def {
-        name: name.as_ptr().cast(),
+        // name: name.as_ptr().cast(),
+        name,
         on_modify,
         mh_arg1: null_mut(),
         mh_arg2: arg2,

phper/src/modules.rs

@@ -221,13 +221,13 @@ impl ModuleArgs {
 
     pub(crate) fn register_ini_entries(&self, ini_entries: *const zend_ini_entry_def) {
         unsafe {
-            zend_register_ini_entries(ini_entries, self.module_number);
+            // zend_register_ini_entries(ini_entries, self.module_number);
         }
     }
 
     pub(crate) fn unregister_ini_entries(&self) {
         unsafe {
-            zend_unregister_ini_entries(self.module_number);
+            // zend_unregister_ini_entries(self.module_number);
         }
     }
 }

tests/integration/src/arguments.rs

@@ -1,5 +1,11 @@
 use phper::{
-    alloc::EBox, arrays::Array, functions::Argument, modules::Module, objects::Object, values::Val,
+    alloc::EBox,
+    arrays::Array,
+    functions::Argument,
+    ini::{Ini, Policy},
+    modules::Module,
+    objects::Object,
+    values::Val,
 };
 
 pub fn integrate(module: &mut Module) {