Fix clippy

Author: jmjoy

phper-doc/doc/_03_integrate_with_pecl/index.md

@@ -10,8 +10,7 @@ This chapter will guide you on how to integrate the phper project with `pecl` an
 
 ### Adapt to `phpize`
 
-1. At first, imagine you have finished the hello project follow [write your first extension](_02_quick_start::_01_write_your_first_extension), can build the
-php extension `.so` file successfully.
+1. At first, imagine you have finished the hello project follow [write your first extension](_02_quick_start::_01_write_your_first_extension), can build the php extension `.so` file successfully.
 
 1. And then, create the `config.m4` file using by `phpize` (In theory,
    `config.w32` is also required for compatibility with Windows, but now phper

phper-test/src/cli.rs

@@ -41,8 +41,7 @@ pub type ScriptCondition<'a> = (&'a dyn AsRef<Path>, &'a dyn Fn(Output) -> bool)
 /// checkers are pass, than the test is pass.
 ///
 /// - `exec_path` is the path of the make executable, which will be used to
-///   detect the path of
-/// extension lib.
+///   detect the path of extension lib.
 ///
 /// - `scripts` is the slice of the tuple, format is `(path of your php test
 ///   script, checker function or closure)`.
@@ -93,6 +92,7 @@ pub fn test_php_scripts_with_condition(
 
 /// Check your extension by executing the long term php script such as http
 /// server, if the all your specified checkers are pass, than the test is pass.
+#[allow(clippy::zombie_processes)]
 pub fn test_long_term_php_script_with_condition(
     lib_path: impl AsRef<Path>, script: impl AsRef<Path>,
     condition: impl FnOnce(&Child) + UnwindSafe,

phper-test/src/context.rs

@@ -98,7 +98,7 @@ impl Context {
                 .and_then(|name| {
                     let mut p = p.to_path_buf();
                     p.push("sbin");
-                    p.push(&format!(
+                    p.push(format!(
                         "php-fpm{}",
                         if name.starts_with("php") {
                             name.chars().skip(3).collect::<String>()

phper/src/arrays.rs

@@ -49,7 +49,7 @@ pub enum InsertKey<'a> {
     ZStr(&'a ZStr),
 }
 
-impl<'a> From<()> for InsertKey<'a> {
+impl From<()> for InsertKey<'_> {
     fn from(_: ()) -> Self {
         Self::NextIndex
     }
@@ -474,7 +474,7 @@ struct RawIter<'a> {
     _p: PhantomData<&'a ()>,
 }
 
-impl<'a> RawIter<'a> {
+impl RawIter<'_> {
     fn new(arr: *mut zend_array) -> Self {
         let mut pos: HashPosition = 0;
         unsafe {

phper/src/output.rs

@@ -33,7 +33,7 @@ pub fn log(level: LogLevel, message: impl Into<String>) {
     unsafe {
         php_error_docref1(
             null(),
-            "\0".as_ptr().cast(),
+            c"".as_ptr().cast(),
             level as i32,
             message.as_ptr().cast(),
         );