Skip to content

Commit dc75ec7

Browse files
committed
Re-add php version 7.0.
1 parent 1cfb115 commit dc75ec7

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
os:
2323
- ubuntu-latest
2424
php-version:
25-
# - "7.0"
25+
- "7.0"
2626
- "7.1"
2727
- "7.2"
2828
- "7.3"

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ A library that allows us to write PHP extensions using pure Rust and using safe
2525

2626
*version*
2727

28-
- [ ] 7.0
28+
- [x] 7.0
2929
- [x] 7.1
3030
- [x] 7.2
3131
- [x] 7.3

phper-macros/src/derives.rs

Whitespace-only changes.

tests/integration/tests/php/classes.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,13 @@
22

33
require_once __DIR__ . '/_common.php';
44

5-
assert_throw(function () { new \IntegrationTest\A(); }, "ArgumentCountError", 0, "IntegrationTest\\A::__construct(): expects at least 2 parameter(s), 0 given");
5+
if (PHP_VERSION_ID >= 70100) {
6+
$argumentCountErrorName = "ArgumentCountError";
7+
} else {
8+
$argumentCountErrorName = "TypeError";
9+
}
10+
11+
assert_throw(function () { new \IntegrationTest\A(); }, $argumentCountErrorName, 0, "IntegrationTest\\A::__construct(): expects at least 2 parameter(s), 0 given");
612

713
$a = new \IntegrationTest\A("foo", 99);
814
assert_eq($a->speak(), "name: foo, number: 99");

0 commit comments

Comments
 (0)