Skip to content

Commit 50c123b

Browse files
Unwrap exception
1 parent d57e14c commit 50c123b

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

src/Util/Log/JUnit.php

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -127,21 +127,26 @@ public function addError(PHPUnit_Framework_Test $test, Exception $e, $time)
127127
}
128128

129129
if ($test instanceof PHPUnit_Framework_SelfDescribing) {
130-
$buffer = $test->toString() . "\n";
130+
$buffer = $test->toString() . PHP_EOL;
131131
} else {
132132
$buffer = '';
133133
}
134134

135-
$buffer .= PHPUnit_Framework_TestFailure::exceptionToString($e) .
136-
"\n" .
137-
PHPUnit_Util_Filter::getFilteredStacktrace($e);
135+
if ($e instanceof PHPUnit_Framework_ExceptionWrapper) {
136+
$type = $e->getClassname();
137+
$buffer .= (string) $e;
138+
} else {
139+
$type = get_class($e);
140+
$buffer .= PHPUnit_Framework_TestFailure::exceptionToString($e) . PHP_EOL .
141+
PHPUnit_Util_Filter::getFilteredStacktrace($e);
142+
}
138143

139144
$error = $this->document->createElement(
140145
'error',
141146
PHPUnit_Util_XML::prepareString($buffer)
142147
);
143148

144-
$error->setAttribute('type', get_class($e));
149+
$error->setAttribute('type', $type);
145150

146151
$this->currentTestCase->appendChild($error);
147152

tests/TextUI/log-junit.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Failed asserting that false is true.
2626
</failure>
2727
</testcase>
2828
<testcase name="testError" class="StatusTest" file="%s/StatusTest.php" line="%d" assertions="0" time="%s">
29-
<error type="PHPUnit_Framework_ExceptionWrapper">StatusTest::testError
29+
<error type="Exception">StatusTest::testError
3030
Exception:
3131

3232
%s/StatusTest.php:%d

0 commit comments

Comments
 (0)