Code cleanup

Author: phpfui

.php-cs-fixer.dist.php

@@ -11,5 +11,6 @@
 return $config->setFinder(PhpCsFixer\Finder::create()
 			->exclude('vendor')
 			->in(__DIR__.'\src')
+			->in(__DIR__.'\examples')
 			->in(__DIR__.'\tests')
     );

composer.json

@@ -36,6 +36,7 @@
 		"require-dev": {
         "phpunit/phpunit": "^8.4 | ^9.0",
         "friendsofphp/php-cs-fixer": "^3.3",
-        "phpstan/phpstan": "^1.8"
+        "phpstan/phpstan": "^1.8",
+        "phpfui/phpunit-syntax-coverage": "^1.0"
     }
 }

examples/parseicalendar.php

@@ -8,7 +8,6 @@
  * @license     GNU GPLv3 <http://www.gnu.org/licenses/gpl.html>
  * @link	http://icalendar.org/php-library.html
  */
-
 include '../vendor/autoload.php';
 
 /**
@@ -18,9 +17,8 @@
  * or leave blank to parse the default file.
  *
  */
-
 $icalfile = isset($arg[1]) ? $argv[1] : 'abrahamlincoln.ics';
-$icalfeed = file_get_contents($icalfile);
+$icalfeed = \file_get_contents($icalfile);
 
 // create the ical object
 $icalobj = new \ICalendarOrg\ZCiCal($icalfeed);
@@ -31,28 +29,29 @@
 
 // read back icalendar data that was just parsed
 if(isset($icalobj->tree->child))
-{
-	foreach($icalobj->tree->child as $node)
 	{
-		if($node->getName() == 'VEVENT')
+	foreach($icalobj->tree->child as $node)
 		{
+		if('VEVENT' == $node->getName())
+			{
 			$ecount++;
-			echo "Event $ecount:\n";
+			echo "Event {$ecount}:\n";
+
 			foreach($node->data as $key => $value)
-			{
-				if(is_array($value))
 				{
-					for($i = 0; $i < count($value); $i++)
+				if(\is_array($value))
 					{
+					for($i = 0; $i < \count($value); $i++)
+						{
 						$p = $value[$i]->getParameters();
-						echo "  $key: " . $value[$i]->getValues() . "\n";
+						echo "  {$key}: " . $value[$i]->getValues() . "\n";
+						}
 					}
-				}
 				else
-				{
-					echo "  $key: " . $value->getValues() . "\n";
+					{
+					echo "  {$key}: " . $value->getValues() . "\n";
+					}
 				}
 			}
 		}
 	}
-}

examples/recurringdate.php

@@ -8,7 +8,6 @@
  * @license     GNU GPLv3 <http://www.gnu.org/licenses/gpl.html>
  * @link	http://icalendar.org/php-library.html
  */
-
 include '../vendor/autoload.php';
 
 /**
@@ -17,33 +16,33 @@
  * Recurring date examples with RRULE property
  *
  */
-
 $examples =
-array(
-	array(
-		'name' => "Abraham Lincon's birthday",
-		'date' => '2015-02-12',
-		'rule' => 'FREQ=YEARLY;INTERVAL=1;BYMONTH=2;BYMONTHDAY=12'
-	),
+	[
+		[
+			'name' => "Abraham Lincon's birthday",
+			'date' => '2015-02-12',
+			'rule' => 'FREQ=YEARLY;INTERVAL=1;BYMONTH=2;BYMONTHDAY=12'
+		],
 
-	array(
-		'name' => 'Start of U.S. Supreme Court Session (1st Monday in October)',
-		'date' => '2015-10-01',
-		'rule' => 'FREQ=YEARLY;INTERVAL=1;BYMONTH=10;BYDAY=1MO'
-	)
-);
+		[
+			'name' => 'Start of U.S. Supreme Court Session (1st Monday in October)',
+			'date' => '2015-10-01',
+			'rule' => 'FREQ=YEARLY;INTERVAL=1;BYMONTH=10;BYDAY=1MO'
+		]
+	];
 
 // Use maxdate to limit # of infinitely repeating events
-$maxdate = strtotime('2021-01-01');
+$maxdate = \strtotime('2021-01-01');
 
 foreach($examples as $example)
-{
+	{
 	echo $example['name'] . ":\n";
-	$rd = new \ICalendarOrg\ZCRecurringDate($example['rule'],strtotime($example['date']));
+	$rd = new \ICalendarOrg\ZCRecurringDate($example['rule'], \strtotime($example['date']));
 	$dates = $rd->getDates($maxdate);
+
 	foreach($dates as $d)
-	{
-		echo '  ' . date('l, F j, Y ',$d) . "\n";
-	}
+		{
+		echo '  ' . \date('l, F j, Y ', $d) . "\n";
+		}
 	echo "\n";
-}
+	}

examples/simpleevent.php

@@ -8,7 +8,6 @@
  * @license     GNU GPLv3 <http://www.gnu.org/licenses/gpl.html>
  * @link	http://icalendar.org/php-library.html
  */
-
 include '../vendor/autoload.php';
 
 /**
@@ -40,7 +39,7 @@
 
 // UID is a required item in VEVENT, create unique string for this event
 // Adding your domain to the end is a good way of creating uniqueness
-$uid = date('Y-m-d-H-i-s') . '@demo.icalendar.org';
+$uid = \date('Y-m-d-H-i-s') . '@demo.icalendar.org';
 $eventobj->addNode(new \ICalendarOrg\ZCiCalDataNode('UID:' . $uid));
 
 // DTSTAMP is a required item in VEVENT
@@ -51,4 +50,3 @@
 
 // write iCalendar feed to stdout
 echo $icalobj->export();
-

examples/timezoneevent.php

@@ -8,12 +8,9 @@
  * @license     GNU GPLv3 <http://www.gnu.org/licenses/gpl.html>
  * @link	http://icalendar.org/php-library.html
  */
-
 include '../vendor/autoload.php';
 
-/*
- * Create Event Example With Local Timezone
- */
+// Create Event Example With Local Timezone
 
 $title = 'Event in New York timezone';
 // date/time is in SQL datetime format
@@ -28,7 +25,7 @@
 $icalobj = new \ICalendarOrg\ZCiCal();
 
 // Add timezone data
-\ICalendarOrg\ZCTimeZoneHelper::getTZNode(substr($event_start,0,4),substr($event_end,0,4),$tzid, $icalobj->curnode);
+\ICalendarOrg\ZCTimeZoneHelper::getTZNode(\substr($event_start, 0, 4), \substr($event_end, 0, 4), $tzid, $icalobj->curnode);
 
 // create the event within the ical object
 $eventobj = new \ICalendarOrg\ZCiCalNode('VEVENT', $icalobj->curnode);
@@ -44,12 +41,11 @@
 
 // UID is a required item in VEVENT, create unique string for this event
 // Adding your domain to the end is a good way of creating uniqueness
-$uid = date('Y-m-d-H-i-s') . '@demo.icalendar.org';
+$uid = \date('Y-m-d-H-i-s') . '@demo.icalendar.org';
 $eventobj->addNode(new \ICalendarOrg\ZCiCalDataNode('UID:' . $uid));
 
 // DTSTAMP is a required item in VEVENT
 $eventobj->addNode(new \ICalendarOrg\ZCiCalDataNode('DTSTAMP:' . \ICalendarOrg\ZDateHelper::fromSqlDateTime()));
 
 // write iCalendar feed to stdout
 echo $icalobj->export();
-