test: improve missing file generation consistency

g105b · g105b · commit 972fdb7e5bc4 · 2025-07-29T08:46:59.000+01:00
diff --git a/test/phpunit/Migration/MigratorTest.php b/test/phpunit/Migration/MigratorTest.php
@@ -659,7 +659,10 @@ private static function generateFileList($missingFiles = false, $duplicateFiles
 		if($missingFiles) {
 			$numToRemove = rand(1, (int)($migLength / 10));
 			for($i = 0; $i < $numToRemove; $i++) {
-				$keyToRemove = array_rand($fileList);
+				do {
+					$keyToRemove = array_rand($fileList);
+				}
+				while($keyToRemove === array_key_last($fileList));
 				unset($fileList[$keyToRemove]);
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -659,7 +659,10 @@ private static function generateFileList($missingFiles = false, $duplicateFiles`
`659`	`659`	`if($missingFiles) {`
`660`	`660`	`$numToRemove = rand(1, (int)($migLength / 10));`
`661`	`661`	`for($i = 0; $i < $numToRemove; $i++) {`
`662`		`- $keyToRemove = array_rand($fileList);`
	`662`	`+ do {`
	`663`	`+ $keyToRemove = array_rand($fileList);`
	`664`	`+ }`
	`665`	`+ while($keyToRemove === array_key_last($fileList));`
`663`	`666`	`unset($fileList[$keyToRemove]);`
`664`	`667`	`}`
`665`	`668`	`}`